[pgAdmin4] Update Chrome driver to latest version

2018-05-04 Thread Murtuza Zabuawala
Hi, Please find attached minor patch to update chrome-driver to latest version to support Chrome v.66 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company update_chrome_driver.diff Description: Binary data

pgAdmin 4 commit: Scroll cells into the viewport if needed during the C

2018-05-04 Thread Dave Page
Scroll cells into the viewport if needed during the CheckForViewData feature test. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3ff56b2d497a428ea0d8db32926415e17d9427c8 Author: Anthony Emengo Modified Files -- web/pgadmin/feat

Re: [pgAdmin4][patch] - Fix CheckForViewDataTest

2018-05-04 Thread Dave Page
Thanks - applied! On Thu, May 3, 2018 at 7:49 PM, Anthony Emengo wrote: > Here's an updated patch that scrolls the cells into view before making an > assertion. > > Joao && Anthony > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.co

pgAdmin 4 commit: Update chromedriver version to support Chrome 66.

2018-05-04 Thread Dave Page
Update chromedriver version to support Chrome 66. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=455c45ea852c986e900ab38134be4429fa09c892 Author: Murtuza Zabuawala Modified Files -- web/regression/requirements.txt | 2 +- 1 file c

Re: [pgAdmin4] Update Chrome driver to latest version

2018-05-04 Thread Dave Page
Thanks, applied. On Fri, May 4, 2018 at 10:09 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > Please find attached minor patch to update chrome-driver to latest version > to support Chrome v.66 > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterpris

pgAdmin 4 commit: Add support for SSH tunneled connections. Fixes #1447

2018-05-04 Thread Dave Page
Add support for SSH tunneled connections. Fixes #1447 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b7fb01ab04e69fe558f0f2654f9940c549529959 Author: Akshay Joshi Modified Files -- docs/en_US/images/server_advanced.png

Re: [pgAdmin4][Patch] Feature #1447 SSH Tunnel

2018-05-04 Thread Dave Page
On Thu, May 3, 2018 at 10:06 AM, Akshay Joshi wrote: > Hi > > On Thu, May 3, 2018 at 2:20 PM, Dave Page wrote: > >> >> >> On Thu, May 3, 2018 at 6:58 AM, Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Hi >>> >>> On Wed, May 2, 2018 at 9:05 PM, Victoria Henry >>> wrote: >>>

pgAdmin 4 commit: Bump version to avoid confusion

2018-05-04 Thread Dave Page
Bump version to avoid confusion Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=554a199fd2875e443a51fdaec9e066b850d54bcc Modified Files -- web/config.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

pgAdmin 4 commit: One day I'll remember to update the version everywher

2018-05-04 Thread Dave Page
One day I'll remember to update the version everywhere... Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4f79f00d6107f5b6b6e6c48d3bbaecaca483a147 Modified Files -- runtime/Info.plist | 4 ++-- runtime/pgAdmin4.pro | 2 +- 2 files

pgAdmin 4 commit: Standardise the error handling for parsing of JSON re

2018-05-04 Thread Dave Page
Standardise the error handling for parsing of JSON response messages from the server. Fixes #3238 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=893737588509425849b0fde3068d34f4950e9ce2 Modified Files -- docs/en_US/release_notes_

Re: [pgAdmin4][Patch] Feature #3270 Add support for running regression tests against Firefox

2018-05-04 Thread Anthony Emengo
Hey Akshay, Regarding your previous comment: As I know time.sleep is not a good idea and I am new to feature test and in > learning phase, can someone correct/suggest the way to fix those issues. Although the feature tests already have some sleeps, it’s generally not a best practice for browser