pgAdmin 4 commit: Correct the runtime options list.

2018-07-05 Thread Dave Page
Correct the runtime options list. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=165c4744b0ee239fd804d208b3b33fbae6b52914 Modified Files -- docs/en_US/desktop_deployment.rst | 9 +++-- 1 file changed, 3 insertions(+), 6 deletio

[pgAdmin4][Patch]: Feature tests for PG utilities

2018-07-05 Thread Khushboo Vashi
Hi, Please find the attached patch which contains the feature tests for PG utilities #3206. Thanks, Khushboo RM_3206_partial.patch Description: Binary data

pgAdmin 4 commit: Don't create a session when the /misc/ping test endpo

2018-07-05 Thread Dave Page
Don't create a session when the /misc/ping test endpoint is called. Fixes #3371 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=82d77c4608b92304c7737ec4a3d5ab331efd82e9 Author: Aditya Toshniwal Modified Files -- docs/en_US/release

Re: [pgAdmin4][RM3371] Ping endpoint still send a pg4a_session cookie

2018-07-05 Thread Dave Page
Thanks, patch applied. On Wed, Jul 4, 2018 at 6:38 AM, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Dave, > > I tested with apache2 and it works fine. Below is the log: > > adityatoshniwal@ubuntu:~/.pgadmin/sessions$ ls -ltr > total 0 > adityatoshniwal@ubuntu:~/.pgadmin/sessi

Re: [pgAdmin4][Patch]: RM #3397 Add support for JIT stats in EXPLAIN output in PG11

2018-07-05 Thread Akshay Joshi
Hi Dave As per discussion attached is the modified patch with following review comments has been fixed : - Hide statistics button if not applicable(no statistics to show). - Extract 'StatisticsModel' into a separate file and added jasmine test for this. On Tue, Jul 3, 2018 at 6:40 PM

pgAdmin 4 commit: Infrastructure and changes to the Query Tool for real

2018-07-05 Thread Dave Page
Infrastructure and changes to the Query Tool for realtime preference handling. Refs #3294 Highlights of this patch include: - Changes will affect SQL Editors in Create dialog boxes, SQL tab of the main screen, Query tool, History entries in the query tool, Query tool opened in New Tab/Window -

Re: [pgAdmin4][RM3294] User need to reset the layout to see the changed preferences parameters

2018-07-05 Thread Dave Page
Thanks - patch applied! On Wed, Jul 4, 2018 at 10:19 AM, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the updated patch for the RM. Change of the flags like auto > commit, explain->verbose, etc. will reflect in all other open sql editors. > Kindly rev

pgAdmin 4 commit: Add missing files related to previous commit: Infrast

2018-07-05 Thread Dave Page
Add missing files related to previous commit: Infrastructure and changes to the Query Tool for realtime preference handling. Refs #3294 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=73530c05aa3fbef4f51ddc06316acbdb46e7133d Author: Aditya Tos

Re: [pgAdmin4][Patch]: Feature tests for PG utilities

2018-07-05 Thread Khushboo Vashi
On Thu, Jul 5, 2018 at 4:39 PM, Dave Page wrote: > Hi > > On Thu, Jul 5, 2018 at 10:42 AM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> Please find the attached patch which contains the feature tests for PG >> utilities #3206. >> >> Thanks, >> Khushboo >> > > I'm seei

Re: [pgAdmin4][Patch]: Feature tests for PG utilities

2018-07-05 Thread Dave Page
On Thu, Jul 5, 2018 at 12:30 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Thu, Jul 5, 2018 at 4:39 PM, Dave Page wrote: > >> Hi >> >> On Thu, Jul 5, 2018 at 10:42 AM, Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> Hi, >>> >>> Please find the attached p

Re: [pgAdmin4][Patch]: Feature tests for PG utilities

2018-07-05 Thread Khushboo Vashi
On Thu, Jul 5, 2018 at 5:09 PM, Dave Page wrote: > > > On Thu, Jul 5, 2018 at 12:30 PM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >> On Thu, Jul 5, 2018 at 4:39 PM, Dave Page wrote: >> >>> Hi >>> >>> On Thu, Jul 5, 2018 at 10:42 AM, Khushboo Vashi < >>> khushboo.va...@en

Re: [pgAdmin4][Patch]: RM #3397 Add support for JIT stats in EXPLAIN output in PG11

2018-07-05 Thread Dave Page
Hi Looks good to me - the only remaining issue is that the button still isn't the same colours as the zoom ones. I haven't found all the differences, but there seems to be an 'opacity: 0.5" on the stats area, and the disabled attribute is still being set. On Thu, Jul 5, 2018 at 11:21 AM, Akshay J

pgAdmin 4 commit: Cleanup some late-night commit ugliness.

2018-07-05 Thread Dave Page
Cleanup some late-night commit ugliness. Branch -- electron Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fdb0fbf3b008bd43a3f5179072944b5552645809 Modified Files -- pkg/setup-macos.sh | 52 ++-- 1 fi

Re: [pgAdmin4][Patch]: RM #3397 Add support for JIT stats in EXPLAIN output in PG11

2018-07-05 Thread Akshay Joshi
Hi On Thu, Jul 5, 2018 at 7:17 PM, Dave Page wrote: > Hi > > Looks good to me - the only remaining issue is that the button still isn't > the same colours as the zoom ones. I haven't found all the differences, but > there seems to be an 'opacity: 0.5" on the stats area, and the disabled > attrib