Re: [pgAdmin4][Patch]: Feature tests for PG utilities

2018-07-09 Thread Khushboo Vashi
Hi Dave, On Thu, Jul 5, 2018 at 7:47 PM, Dave Page wrote: > > > On Thu, Jul 5, 2018 at 12:49 PM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >> On Thu, Jul 5, 2018 at 5:09 PM, Dave Page wrote: >> >>> >>> >>> On Thu, Jul 5, 2018 at 12:30 PM, Khushboo Vashi < >>> khushboo.

Re: [pgAdmin4][Patch]: Feature tests for PG utilities

2018-07-09 Thread Dave Page
On Mon, Jul 9, 2018 at 10:30 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Dave, > > > On Thu, Jul 5, 2018 at 7:47 PM, Dave Page wrote: > >> >> >> On Thu, Jul 5, 2018 at 12:49 PM, Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> >>> >>> On Thu, Jul 5, 2018 at

pgAdmin 4 commit: Add feature tests for Backup/Restore and Maintenance.

2018-07-09 Thread Dave Page
Add feature tests for Backup/Restore and Maintenance. Fixes #3206 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=81312d17e280fabd5c77bf4a5e3b8c1ab93f1637 Author: Khushboo Vashi Modified Files -- .../pg_utilities_backup_restore_te

[pgAdmin4][RM3478] User should able to type any query in SQL Filter

2018-07-09 Thread Aditya Toshniwal
​Hi Hackers, Attached is the patch to fix the issue where SQL area in filter dialog was not allowing to type. Actually it was allowing to type but the font size of the SQL area was 0em and so the characters were not visible. This bug occurred because of RM3294

pgAdmin 4 commit: Replace deprecated success, error callbacks in $.ajax

2018-07-09 Thread Dave Page
Replace deprecated success, error callbacks in $.ajax call with new functions .done and .fail. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=41a8333145f011945def779033b86c4adaebe292 Author: Aditya Toshniwal Modified Files -- ..

Re: [pgAdmin4][patch] AJAX call related changes for jQuery 3

2018-07-09 Thread Dave Page
Thanks - patch applied. On Mon, Jul 9, 2018 at 11:49 AM, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to replace deprecated success, error callbacks in > $.ajax call with new functions .done and .fail. > > Kindly review. > > -- > Thanks and

pgAdmin 4 commit: Ensure text is visible in the SQL Filter dialogue. Fi

2018-07-09 Thread Dave Page
Ensure text is visible in the SQL Filter dialogue. Fixes #3478 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d1784137a5b9d19746bd04f9733915bf15d2a9cd Author: Aditya Toshniwal Modified Files -- web/pgadmin/static/js/backform.pgad

Re: [pgAdmin4][RM3478] User should able to type any query in SQL Filter

2018-07-09 Thread Dave Page
Thanks, applied. On Mon, Jul 9, 2018 at 1:12 PM, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > ​Hi Hackers, > > Attached is the patch to fix the issue where SQL area in filter dialog was > not allowing to type. Actually it was allowing to type but the font size of > the SQL area