[pgAdmin4][patch] jQuery 3 migration few more leftovers

2018-07-10 Thread Aditya Toshniwal
Hi Hackers, Attached is the patch to migrate few more occurrences of deprecated functions of older jQuery versions in pgAdmin4 to jQuery 3 (which were missed in previous patches of jQuery migration :( ). Kindly review. -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Sof

[pgAdmin4][RM3480] User can not see any SQL query in SQL pane

2018-07-10 Thread Aditya Toshniwal
Hi Hackers, Attached is the fix. It is again related to changed made for RM3294, the font size was set to 0em. Also included changes to make sure CodeMirror font size is never set to 0em but to default 1em if font size is not available from preferences. -- Thanks and Regards, Aditya Toshniwal So

pgAdmin 4 commit: More jQuery 3 updates.

2018-07-10 Thread Dave Page
More jQuery 3 updates. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3b862bd70bc1804f28e557dc8dd1cbde71f67f34 Author: Aditya Toshniwal Modified Files -- web/pgadmin/browser/static/js/wizard.js| 2 +- web/pgadmin/misc

Re: [pgAdmin4][patch] jQuery 3 migration few more leftovers

2018-07-10 Thread Dave Page
Thanks, applied. On Tue, Jul 10, 2018 at 8:14 AM, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to migrate few more occurrences of deprecated > functions of older jQuery versions in pgAdmin4 to jQuery 3 (which were > missed in previous patche

Re: [pgAdmin4][RM3480] User can not see any SQL query in SQL pane

2018-07-10 Thread Dave Page
Hi On Tue, Jul 10, 2018 at 10:36 AM, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the fix. It is again related to changed made for RM3294, the > font size was set to 0em. Also included changes to make sure CodeMirror > font size is never set to 0em bu

Re: [pgAdmin4][RM3480] User can not see any SQL query in SQL pane

2018-07-10 Thread Aditya Toshniwal
Hi Hackers, On Tue, Jul 10, 2018 at 3:37 PM, Dave Page wrote: > Hi > > On Tue, Jul 10, 2018 at 10:36 AM, Aditya Toshniwal enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the fix. It is again related to changed made for RM3294, the >> font size was set to 0em. Also included changes t

Re: [pgAdmin4][RM3480] User can not see any SQL query in SQL pane

2018-07-10 Thread Dave Page
I think you forgot the patch :-/ On Tue, Jul 10, 2018 at 11:48 AM, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > On Tue, Jul 10, 2018 at 3:37 PM, Dave Page wrote: > >> Hi >> >> On Tue, Jul 10, 2018 at 10:36 AM, Aditya Toshniwal < >> aditya.toshni...@enterprisedb.

Re: [pgAdmin4][RM3480] User can not see any SQL query in SQL pane

2018-07-10 Thread Aditya Toshniwal
Hi, On Tue, Jul 10, 2018 at 4:24 PM, Dave Page wrote: > I think you forgot the patch :-/ > ​Apologies. I know this is annoying :( ​ PFA. > > > On Tue, Jul 10, 2018 at 11:48 AM, Aditya Toshniwal enterprisedb.com> wrote: > >> Hi Hackers, >> >> On Tue, Jul 10, 2018 at 3:37 PM, Dave Page wrote: >

Re: [pgAdmin4][RM3480] User can not see any SQL query in SQL pane

2018-07-10 Thread Dave Page
Thanks - patch applied! On Tue, Jul 10, 2018 at 11:58 AM, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > On Tue, Jul 10, 2018 at 4:24 PM, Dave Page wrote: > >> I think you forgot the patch :-/ >> > ​Apologies. I know this is annoying :( > ​ > PFA. > >> >> >> On Tue, Jul 1

pgAdmin 4 commit: Ensure CodeMirror always has a non-zero font size. Fi

2018-07-10 Thread Dave Page
Ensure CodeMirror always has a non-zero font size. Fixes #3480 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2b9c0a63fba2aaf1dcfbde7d396fe9f324557e42 Author: Aditya Toshniwal Modified Files -- web/pgadmin/browser/static/css/brow

Re: Regarding RM #3316 Pgadmin4 No Tray Crash

2018-07-10 Thread Dave Page
Hi On Tue, Jul 10, 2018 at 11:20 AM, Akshay Joshi < akshay.jo...@enterprisedb.com> wrote: > Hi Hackers, > > I have implemented the fix for RM #3316 "Pgadmin4 No Tray Crash". I have > implemented it as follows: > >- Check the availability of System Tray for 30 seconds (no changes >made her

Re: Regarding RM #3316 Pgadmin4 No Tray Crash

2018-07-10 Thread Akshay Joshi
On Tue, 10 Jul 2018, 18:32 Dave Page, wrote: > Hi > > On Tue, Jul 10, 2018 at 11:20 AM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> I have implemented the fix for RM #3316 "Pgadmin4 No Tray Crash". I have >> implemented it as follows: >> >>- Check the availab

Re: Regarding RM #3316 Pgadmin4 No Tray Crash

2018-07-10 Thread Dave Page
On Tue, Jul 10, 2018 at 4:05 PM, Akshay Joshi wrote: > > > On Tue, 10 Jul 2018, 18:32 Dave Page, wrote: > >> Hi >> >> On Tue, Jul 10, 2018 at 11:20 AM, Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> I have implemented the fix for RM #3316 "Pgadmin4 No Tray Cra

[pgAdmin4][Patch]: Fix RM #3191 : Debug option is not working

2018-07-10 Thread Khushboo Vashi
Hi, Please find the attached patch to fix #3191 : Debug option is not working. Issues fixed: 1. EPAS packages' function/procedure does not honour INOUT arguments, it converts INOUT to OUT. 2. Packages' functions and procedures are not getting listed in their respected nodes in some scenarios l

pgAgent commit: Using the FindBoost.cmake from cmake 3.11.4 to work wit

2018-07-10 Thread Ashesh Vashi
Using the FindBoost.cmake from cmake 3.11.4 to work with the boost version 1.67.0, or lesser. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgagent.git;a=commitdiff;h=54130ee9bf394ca6ef6ff89d6cf3265543468be7 Author: Sandeep Thankkar Modified Files -- cmake

pgAgent commit: Using mutex around the logging functionality to avoid l

2018-07-10 Thread Ashesh Vashi
Using mutex around the logging functionality to avoid logging at the same time from different threads in the same file, and make a mess of the log file. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgagent.git;a=commitdiff;h=5706a7738f566686ab8a5046572e4c67dccfcc4a Mo