Re: [pgAdmin4][Patch]: RM 1253 - Store and reload current location in treeview

Hi Khushboo Patch looks good to me, following are my review comments: - Logic doesn't work when we disconnect and re-connect to the database server. We have duplicated RM #1335. - Instead of -1 we should use 0 to stop the tree saving functionality. Send request at 0 second doesn't mak

Re: [pgAdmin4][Patch]: RM #3420 Merge latest code of pgcli with pgAdmin4

Hi, Did a basic testing. Looks good to me. Test cases run successfully. On Fri, Aug 24, 2018 at 10:55 AM Akshay Joshi wrote: > Hi Hackers > > I have merged the latest code of "*pgcli*" used for auto complete feature > in pgAdmin4. We haven't merged that code since last 2 years and they have > f

pgAdmin 4 commit: Merge pgcli code with version 1.10.3, which is used f

Merge pgcli code with version 1.10.3, which is used for auto complete feature. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7a3f3046df7fa0bdcfab4f0ce7011898ffd75bf6 Modified Files -- docs/en_US/release_notes_3_3.rst

Build failed in Jenkins: pgadmin4-master-python26 #870

See Changes: [akshay.joshi] Merge pgcli code with version 1.10.3, which is used for auto complete -- [...truncated 24.85 KB...] Requirement already satisfied: un

Re: [pgAdmin4][Patch]: RM #3420 Merge latest code of pgcli with pgAdmin4

Hi Akshay, Attached is the patch to make autocomplete changes python 2.6 compatible. Please note, this patch should be applied over your patch. On Mon, Aug 27, 2018 at 2:28 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > Did a basic testing. Looks good to me. Test cases

pgAdmin 4 commit: Fixed auto complete issues for Python 2.6

Fixed auto complete issues for Python 2.6 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ea787b30eb8cbda1adac26d3d6a9c6288e9ca6fa Author: Aditya Toshniwal Modified Files -- .../query_tool_auto_complete_tests.py | 1

Re: [pgAdmin4][Patch]: RM #3420 Merge latest code of pgcli with pgAdmin4

Thanks patch applied. On Mon, Aug 27, 2018 at 4:22 PM, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Akshay, > > Attached is the patch to make autocomplete changes python 2.6 compatible. > Please note, this patch should be applied over your patch. > > On Mon, Aug 27, 2018 at 2

[pgAdmin4][RM#3590] Fix refresh button on Dashboard

Hi, PFA minor patch to fix the issue on Dashboard where Refresh button is not working. Reported by: Vishal Sawale -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_3590.diff Description: Binary data

Jenkins build is back to normal : pgadmin4-master-python26 #871

See

[pgAdmin4][RM3554] Debugger scroll issue for long procedures

Hi Hackers, Attached is the patch to make debugger scroll automatically to current active line and scroll along with StepIn/StepOut. Previously, we had to manually scroll. Kindly review. -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Co

Re: [pgAdmin4][RM3554] Debugger scroll issue for long procedures

Hi Hackers, Please hold on with the patch. As discussed and found by Ashesh Vashi, if we the function called recursively then it is loading the debugger with source code again which can be avoided and will improve performance if the function is large. Will send the updated patch along with the re

pgAdmin 4 commit: Ensure external table node should be visible only for

Ensure external table node should be visible only for GPDB. Fixes #3548 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=dd3c7c94e68fa5284d0d549abdee056af0be5970 Modified Files -- docs/en_US/release_notes_3_3.rst

Re: [pgAdmin4][RM3554] Debugger scroll issue for long procedures

Hi Hackers, Attached is the updated patch which also includes code changes to avoid reloading same proc/function again in case of a recursive call. On Mon, Aug 27, 2018 at 6:44 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Please hold on with the patch. As dis

Re: [pgAdmin4][RM#3590] Fix refresh button on Dashboard

Hi Murtuza, The patch is working fine for the server nodes but not for database. Thanks, Khushboo On Mon, Aug 27, 2018 at 4:48 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA minor patch to fix the issue on Dashboard where Refresh button is not > working. > Repo