[pgAdmin4][Patch]: RM #3630 Autocomplete broken in v3.3 release, works in v3.2

2018-09-10 Thread Akshay Joshi
Hi Hackers, Attached is the patch to fix the RM #3630 Autocomplete broken in v3.3 release, works in v3.2. Actual issue is due to merge the pgcli code, we only consider "pg_catalog and public" schema's which I have fixed. -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mob

pgAdmin 4 commit: Further stability fixes for the feature tests.

2018-09-10 Thread Dave Page
Further stability fixes for the feature tests. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=22776d2e14e93ad661ef0c504121c7fdc071a6a1 Author: Usman Muzaffar Modified Files -- web/pgadmin/feature_tests/query_tool_tests.py | 47 ++

pgAdmin 4 commit: Remove unnecessary screenshot.

2018-09-10 Thread Dave Page
Remove unnecessary screenshot. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1850a3a9954d973b1994d867f3b8993fb7310bb4 Modified Files -- web/pgadmin/feature_tests/query_tool_tests.py | 3 --- 1 file changed, 3 deletions(-)

Re: [pgAdmin4][RM3136] Stabilise feature tests for continuous running on CI sytems

2018-09-10 Thread Dave Page
Thanks, patch applied (I've removed a screenshot call that seemed to be left there by mistake). On Fri, Sep 7, 2018 at 5:47 PM, Usman Muzaffar < usman.muzaf...@enterprisedb.com> wrote: > Hi Hackers, > > Please find here attached patch for query_tool_tests.py. On > Jenkins(windows platform), the t

Re: [pgAdmin4][Patch]: Feature 3564 pgAdmin4 should have shortcut tools bar for frequently used features

2018-09-10 Thread Dave Page
Hi On Mon, Sep 10, 2018 at 8:03 AM, Akshay Joshi wrote: > Hi Dave > > On Thu, Sep 6, 2018 at 7:38 PM, Dave Page wrote: > >> Hi >> >> On Thu, Sep 6, 2018 at 1:19 PM, Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> I have implemented the Feature #3564 pgAdmin4 s

Re: [pgAdmin4][Patch]: RM #3630 Autocomplete broken in v3.3 release, works in v3.2

2018-09-10 Thread Dave Page
Hi On Mon, Sep 10, 2018 at 12:50 PM, Akshay Joshi < akshay.jo...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to fix the RM #3630 Autocomplete broken in v3.3 > release, works in v3.2. Actual issue is due to merge the pgcli code, we > only consider "pg_catalog and public" schem

Re: [pgAdmin4][Patch]: RM #3630 Autocomplete broken in v3.3 release, works in v3.2

2018-09-10 Thread Akshay Joshi
On Mon, Sep 10, 2018 at 6:21 PM, Dave Page wrote: > Hi > > On Mon, Sep 10, 2018 at 12:50 PM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch to fix the RM #3630 Autocomplete broken in v3.3 >> release, works in v3.2. Actual issue is due to merge

Re: [pgAdmin4][Patch]: RM #3630 Autocomplete broken in v3.3 release, works in v3.2

2018-09-10 Thread Dave Page
On Mon, Sep 10, 2018 at 2:03 PM, Akshay Joshi wrote: > > > On Mon, Sep 10, 2018 at 6:21 PM, Dave Page wrote: > >> Hi >> >> On Mon, Sep 10, 2018 at 12:50 PM, Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Attached is the patch to fix the RM #3630 Autocomplete b

Re: [pgAdmin4][Patch]: RM #3630 Autocomplete broken in v3.3 release, works in v3.2

2018-09-10 Thread Akshay Joshi
On Mon, Sep 10, 2018 at 6:38 PM, Dave Page wrote: > > > On Mon, Sep 10, 2018 at 2:03 PM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> >> >> On Mon, Sep 10, 2018 at 6:21 PM, Dave Page wrote: >> >>> Hi >>> >>> On Mon, Sep 10, 2018 at 12:50 PM, Akshay Joshi < >>> akshay.jo...@enterpr

Re: [pgAdmin4][Patch]: RM #3630 Autocomplete broken in v3.3 release, works in v3.2

2018-09-10 Thread Akshay Joshi
On Mon, Sep 10, 2018 at 6:41 PM, Akshay Joshi wrote: > > > On Mon, Sep 10, 2018 at 6:38 PM, Dave Page wrote: > >> >> >> On Mon, Sep 10, 2018 at 2:03 PM, Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> >>> >>> On Mon, Sep 10, 2018 at 6:21 PM, Dave Page wrote: >>> Hi

Re: [pgAdmin4][Patch]: RM #3630 Autocomplete broken in v3.3 release, works in v3.2

2018-09-10 Thread Dave Page
On Mon, Sep 10, 2018 at 2:26 PM, Akshay Joshi wrote: > > > On Mon, Sep 10, 2018 at 6:41 PM, Akshay Joshi .com> wrote: > >> >> >> On Mon, Sep 10, 2018 at 6:38 PM, Dave Page wrote: >> >>> >>> >>> On Mon, Sep 10, 2018 at 2:03 PM, Akshay Joshi < >>> akshay.jo...@enterprisedb.com> wrote: >>> >>

pgAdmin 4 commit: Add shortcuts for View Data and the Query tool to the

2018-09-10 Thread Dave Page
Add shortcuts for View Data and the Query tool to the Browser header bar. Fixes #3564 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=532cbe216a649b238ceeaf8cb05926ce3c3bf589 Author: Akshay Joshi Modified Files -- docs/en_US/gett

Re: [pgAdmin4][Patch]: Feature 3564 pgAdmin4 should have shortcut tools bar for frequently used features

2018-09-10 Thread Dave Page
Thanks! Patch applied. On Mon, Sep 10, 2018 at 2:05 PM, Akshay Joshi wrote: > > On Mon, Sep 10, 2018 at 6:09 PM, Dave Page wrote: > >> Hi >> >> On Mon, Sep 10, 2018 at 8:03 AM, Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Hi Dave >>> >>> On Thu, Sep 6, 2018 at 7:38 PM, Dave Pa

Re: [pgAdmin4][Patch]: Feature 3564 pgAdmin4 should have shortcut tools bar for frequently used features

2018-09-10 Thread Aditya Toshniwal
Hi Akshay, You have used hardcoded hash values for colors in class pg-toolbar-btn. Kindly use SCSS variables and move pg-toolbar-btn related to browser/static/scss/_browser.scss On Mon, Sep 10, 2018 at 7:46 PM Dave Page wrote: > Thanks! Patch applied. > > On Mon, Sep 10, 2018 at 2:05 PM, Akshay

pgAdmin 4 commit: Used SCSS variables instead of hardcoded value for co

2018-09-10 Thread Akshay Joshi
Used SCSS variables instead of hardcoded value for color and moved code from CSS to SCSS file. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9c5e42c7a6544c9c6d4827f5e4d3ea9cc653745e Modified Files -- web/pgadmin/browser/static/c

Re: [pgAdmin4][Patch]: Feature 3564 pgAdmin4 should have shortcut tools bar for frequently used features

2018-09-10 Thread Akshay Joshi
Thanks Aditya. I have changed and committed the code. On Tue, Sep 11, 2018 at 10:33 AM, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Akshay, > > You have used hardcoded hash values for colors in class pg-toolbar-btn. > Kindly use SCSS variables and move pg-toolbar-btn related

Re: [pgAdmin4][Patch]: RM #3630 Autocomplete broken in v3.3 release, works in v3.2

2018-09-10 Thread Akshay Joshi
On Mon, Sep 10, 2018 at 7:08 PM, Dave Page wrote: > > > On Mon, Sep 10, 2018 at 2:26 PM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> >> >> On Mon, Sep 10, 2018 at 6:41 PM, Akshay Joshi > .com> wrote: >> >>> >>> >>> On Mon, Sep 10, 2018 at 6:38 PM, Dave Page wrote: >>> >