[pgAdmin4][Patch]: RM #3607 Edit Data: Not able to remove filter SQL condition

2018-09-11 Thread Akshay Joshi
Hi Hackers, Attached is the patch to fix the following for filter dialog: - OK button should be disabled for Filter dialog when filter string is empty. Filter dialog should be opened using context menu View Data -> Filtered Rows or shortcut toolbar. - On validation error dialog should

Re: [pgAdmin4][Patch]: RM #3630 Autocomplete broken in v3.3 release, works in v3.2

2018-09-11 Thread Dave Page
Thanks, patch applied. On Tue, Sep 11, 2018 at 7:21 AM, Akshay Joshi wrote: > > > On Mon, Sep 10, 2018 at 7:08 PM, Dave Page wrote: > >> >> >> On Mon, Sep 10, 2018 at 2:26 PM, Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> >>> >>> On Mon, Sep 10, 2018 at 6:41 PM, Akshay Joshi >>

pgAdmin 4 commit: Ensure auto-complete works for objects in schemas oth

2018-09-11 Thread Dave Page
Ensure auto-complete works for objects in schemas other than public and pg_catalog. Fixes #3630 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4010dc80a912ae956bedae367435d172d2da33cf Author: Akshay Joshi Modified Files -- docs/

Re: [pgAdmin4][Patch]: RM #3607 Edit Data: Not able to remove filter SQL condition

2018-09-11 Thread Dave Page
Hi On Tue, Sep 11, 2018 at 10:12 AM, Akshay Joshi < akshay.jo...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to fix the following for filter dialog: > >- OK button should be disabled for Filter dialog when filter string is >empty. Filter dialog should be opened using

pgAdmin 4 commit: Fixed issue where wrong menu id passed when click on

2018-09-11 Thread Akshay Joshi
Fixed issue where wrong menu id passed when click on 'View Data' tool button Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d6c64e8f11880f6492493145750b3bc59ff8ca6d Modified Files -- web/pgadmin/browser/static/js/toolbar.js | 2 +-