pgAdmin 4 commit: Remove session from the grid on the dashboard when it

Remove session from the grid on the dashboard when it is terminated. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=cd311ca8a951743b9e3696aa297ce5d6be8aab3a Author: Murtuza Zabuawala Modified Files -- web/pgadmin/dashboard/static

Re: [pgAdmin4][Patch] Grid on the dashboard is not getting refresh after killing the session

Thanks patch applied. On Tue, Jan 22, 2019 at 12:21 PM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > ++ Gentle reminder > > > On Fri, Jan 18, 2019 at 8:02 PM Murtuza Zabuawala < > murtuza.zabuaw...@enterprisedb.com> wrote: > >> Hi, >> >> PFA minor patch to fix the regression is

Re: [pgAdmin4] [RM3862] Fix Dialog tabset keyboard navigation

The patch looks good to me. On Mon, Jan 21, 2019 at 4:39 PM Akshay Joshi wrote: > Hi Khushboo > > Can you please review it. > > On Wed, Jan 16, 2019 at 12:55 PM Harshal Dhumal < > harshal.dhu...@enterprisedb.com> wrote: > >> Hi, >> >> Please find attached updated patch. >> In this patch I have f

Re: [pgAdmin4][RM3849] Ask to save unsaved query changes stopped working

Hi On Tue, Jan 22, 2019 at 6:27 AM Akshay Joshi wrote: > > Hi Aditya > > Below are my review comments: > > You have added new config parameter "DISABLE_BEFOREUNLOAD_MESSAGE" to make > this request configurable, should it be the part of preferences setting > instead of configuration? @Dave can y

Re: [pgAdmin4][RM3908] backgrid navigation fix for Select2Cell and PrivilegeCell

Hi Harshal, The Selec2Cell and PrivilegeCell are working properly but I think we should also consider below: 1. The Backgrid and sub-node should have accessibility including every button, cell and control. 2. The Backgrid table header is accessible through keyboard but it should be highlighted wh

Re: [pgAdmin4][Patch] - RM 3853 - Incorrect SQL generated for create script of domain type interval with precision. ERROR: syntax error at or near "["

Hi Akshay, Please find the attached updated patch. On Mon, Jan 21, 2019 at 2:57 PM Akshay Joshi wrote: > Hi Khushboo > > Can you please fix the following and send the patch again > >- PEP8 issue > > Fixed > >- Test cases is failing with Python 3.5. > > I have tested with Python 3.7 and

pgAdmin 4 commit: Drop-down should be closed when click on any other to

Drop-down should be closed when click on any other toolbar button. Fixes #3858 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3e7381414ff12fe1541d71de501b3c3dee97365f Modified Files -- docs/en_US/release_notes_4_2.rst

pgAdmin 4 commit: Fixed keyboard navigation for dialog tabs. Fixes #386

Fixed keyboard navigation for dialog tabs. Fixes #3862 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f731ab730bb74be12d5bf5e8658de04992fcb4fe Author: Harshal Dhumal Modified Files -- docs/en_US/release_notes_4_2.rst

Re: [pgAdmin4] [RM3862] Fix Dialog tabset keyboard navigation

Thanks patch applied. On Tue, Jan 22, 2019 at 2:51 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > The patch looks good to me. > > On Mon, Jan 21, 2019 at 4:39 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Khushboo >> >> Can you please review it. >> >> On Wed, Ja

pgAdmin 4 commit: Fixed keyboard navigation for Select2 and Privilege c

Fixed keyboard navigation for Select2 and Privilege cell in Backgrid Fixes #3908 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ea87d6da8f8bcd76bff8737c3d311cb2254668cc Author: Harshal Dhumal Modified Files -- docs/en_US/release_

Re: [pgAdmin4][RM3908] backgrid navigation fix for Select2Cell and PrivilegeCell

Thanks patch applied On Tue, Jan 22, 2019 at 3:02 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Harshal, > > The Selec2Cell and PrivilegeCell are working properly but I think we > should also consider below: > > 1. The Backgrid and sub-node should have accessibility including e

Re: [pgAdmin4][Patch] - RM 3664 - Statistic panel hangs when 1000+ tables

Hi Khushboo, There is improvement than before but the UI still lags. I tested with 2000 tables and statistics on Tables node. I would also suggest to add further rows only if scrolling down. Rows adding can be avoided even if the scroll does not take to the last element. Currently, if I scroll sli

Re: [pgAdmin4][RM3849] Ask to save unsaved query changes stopped working

Any suggestions on preferences name/desc ? On Tue, Jan 22, 2019 at 3:01 PM Dave Page wrote: > Hi > > On Tue, Jan 22, 2019 at 6:27 AM Akshay Joshi > wrote: > > > > Hi Aditya > > > > Below are my review comments: > > > > You have added new config parameter "DISABLE_BEFOREUNLOAD_MESSAGE" to > make

Re: [pgAdmin4][RM3849] Ask to save unsaved query changes stopped working

On Tue, Jan 22, 2019 at 11:54 AM Aditya Toshniwal wrote: > > Any suggestions on preferences name/desc ? Name: "Confirm on close" Desc: "Confirm closure of the browser or browser tab is intended before proceeding." > On Tue, Jan 22, 2019 at 3:01 PM Dave Page wrote: >> >> Hi >> >> On Tue, Jan 22

Re: [pgAdmin4][Patch] - RM 3853 - Incorrect SQL generated for create script of domain type interval with precision. ERROR: syntax error at or near "["

Hi, Please find the attached updated patch. On Tue, Jan 22, 2019 at 4:17 PM Akshay Joshi wrote: > Hi Khushboo > > On Tue, Jan 22, 2019 at 3:51 PM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi Akshay, >> >> Please find the attached updated patch. >> >> On Mon, Jan 21, 2019 a

Re: [pgAdmin4][RM3849] Ask to save unsaved query changes stopped working

On Tue, Jan 22, 2019 at 5:27 PM Dave Page wrote: > On Tue, Jan 22, 2019 at 11:54 AM Aditya Toshniwal > wrote: > > > > Any suggestions on preferences name/desc ? > > Name: "Confirm on close" > Desc: "Confirm closure of the browser or browser tab is intended > before proceeding." > It also warns o

Re: [pgAdmin4][RM3849] Ask to save unsaved query changes stopped working

On Tue, Jan 22, 2019 at 12:01 PM Aditya Toshniwal wrote: > > > > On Tue, Jan 22, 2019 at 5:27 PM Dave Page wrote: >> >> On Tue, Jan 22, 2019 at 11:54 AM Aditya Toshniwal >> wrote: >> > >> > Any suggestions on preferences name/desc ? >> >> Name: "Confirm on close" >> Desc: "Confirm closure of the

Re: pgAgent v4.0.0 Released

Hello, I see that the pgagent_11-4.0.0-2.rhel6.x86_64.rpm package is included only in the rhel6 package downloads, and not in any of the rhel7 ones. Why is that and when might pgAgent be added to the RedHat 7 packages? I have a RedHat 7 server and would love to put pgAgent on it, but i have had n

pgAdmin 4 commit: Proper SQL should be generated when create domain of

Proper SQL should be generated when create domain of type interval with precision. Fixes #3853 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c6bae69b6f71ee68886aae5db895952af067fff1 Author: Khushboo Vashi Modified Files -- docs

Re: [pgAdmin4][Patch] - RM 3853 - Incorrect SQL generated for create script of domain type interval with precision. ERROR: syntax error at or near "["

Thanks patch applied On Tue, Jan 22, 2019 at 5:28 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached updated patch. > > On Tue, Jan 22, 2019 at 4:17 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Khushboo >> >> On Tue, Jan 22, 2019 at

Build failed in Jenkins: pgadmin4-master-python37 #119

See Changes: [akshay.joshi] Proper SQL should be generated when create domain of type interval with -- [...truncated 959.56 KB...] PgAgentPutStep

Build failed in Jenkins: pgadmin4-master-python35 #873

See Changes: [akshay.joshi] Proper SQL should be generated when create domain of type interval with -- [...truncated 959.66 KB...] MaintenanceCre

Build failed in Jenkins: pgadmin4-master-python27 #885

See Changes: [akshay.joshi] Proper SQL should be generated when create domain of type interval with -- [...truncated 965.39 KB...] TestUtilityChe

pgAdmin 4 commit: Fixed domain sql regression test for EPAS

Fixed domain sql regression test for EPAS Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=11ab1918eae1759d5f1c34cd1a7b216c6b45cf5e Modified Files -- .../servers/databases/schemas/domains/tests/test_domain_sql.py | 7 --- 1 f

Build failed in Jenkins: pgadmin4-master-python34 #879

See Changes: [akshay.joshi] Proper SQL should be generated when create domain of type interval with -- [...truncated 959.57 KB...] PgAgentPutSche

Re: [pgAdmin4][RM3849] Ask to save unsaved query changes stopped working

Hi Hackers, Attached is the revised patch. The warning occurrence is configurable from Preferences > Browser > Display. Kindly review. On Tue, Jan 22, 2019 at 5:38 PM Dave Page wrote: > On Tue, Jan 22, 2019 at 12:01 PM Aditya Toshniwal > wrote: > > > > > > > > On Tue, Jan 22, 2019 at 5:27 PM

Jenkins build is back to normal : pgadmin4-master-python34 #880

See

Jenkins build is back to normal : pgadmin4-master-python35 #874

See

Jenkins build is back to normal : pgadmin4-master-python37 #120

See

Jenkins build is back to normal : pgadmin4-master-python27 #886

See

pgAdmin 4 commit: Use 'UPDATE pg_settings' for setting bytea_output as

Use 'UPDATE pg_settings' for setting bytea_output as a convenience hack for those running on old, unsupported versions of PostgreSQL 'cos we're nice like that. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d92368f8e5a508715afdda3695eebd502973

pgAdmin 4 commit: Update chromedriver.

Update chromedriver. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e27c2c421e9ce84f9d26734232115963724ea63c Author: Murtuza Zabuawala Modified Files -- web/regression/requirements.txt | 2 +- 1 file changed, 1 insertion(+), 1 del

Re: [pgAdmin4] Upgrade chrome driver to latest version

Thanks, applied. On Mon, Jan 21, 2019 at 6:57 AM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to upgrade to latest chrome driver, > - pip uninstall chromedriver_installer > - pip install -r regression/requirements.txt > > > -- > Regards, > Murtuza Zabuawa

Building package Error (std::_hypot)

Hello. I love pgadmin4 and I am studying. I was not able to solve the following problems during packaging pgadmin4. Error1. When performing 'Running make ...', an error occurs on line 285 of pyconfig.h when building pgAdmin4.h. The sentence is "#define hypot _hypot". Error message is "std :: _ hypo

[pgAdmin4][patch] pgAdmin4 better exception handling

Hi Hackers, Attached patch will improve exception handling for pgAdmin4 on the server side. The app level exception handler will handle unhandled exception gracefully, logging it and sending the exception message as response. This will also help in getting the exception where users are facing quer

Re: [pgAdmin4][RM3849] Ask to save unsaved query changes stopped working

Hi Aditya Found one issue you have remove the function "*disable_tree_state_save*" from "*web/regression/python_test_utils/test_utils.py*" and move that code into " *set_preference*" function and it is called from " *web/regression/runtests.py*" which is conditional, so please correct that behavio

Re: [pgAdmin4][RM3849] Ask to save unsaved query changes stopped working

Hi Hackers, PFA revised patch as per review. On Wed, Jan 23, 2019 at 11:20 AM Akshay Joshi wrote: > Hi Aditya > > Found one issue you have remove the function "*disable_tree_state_save*" from > "*web/regression/python_test_utils/test_utils.py*" and move that code > into "*set_preference*" funct

pgAdmin 4 commit: Ensure that browser should warn before close or refre

Ensure that browser should warn before close or refresh. Fixes #3849 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fcfe0929d3935f94882d82c665a94b467a8f315f Author: Aditya Toshniwal Modified Files -- docs/en_US/release_notes_4_2.

Re: [pgAdmin4][RM3849] Ask to save unsaved query changes stopped working

Thanks patch applied. On Wed, Jan 23, 2019 at 11:32 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > PFA revised patch as per review. > > On Wed, Jan 23, 2019 at 11:20 AM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Aditya >> >> Found one issue y

[pgAdmin4][Patch] - RM 3850 - EXEC script generates incorrect syntax: ERROR: syntax error at or near

Hi, Please find the attached patch to fix the RM 3850 - EXEC script generates incorrect syntax: ERROR: syntax error at or near. Thanks, Khushboo RM_3850.patch Description: Binary data

pgAdmin 4 commit: Improve application level exception handling for unha

Improve application level exception handling for unhandled exceptions. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1f298590400cf5d2921a07e200086e16cc22f72c Author: Aditya Toshniwal Modified Files -- web/pgadmin/__init__.py

Re: [pgAdmin4][patch] pgAdmin4 better exception handling

Thanks patch applied. On Wed, Jan 23, 2019 at 11:01 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached patch will improve exception handling for pgAdmin4 on the server > side. The app level exception handler will handle unhandled exception > gracefully, log