pgAdmin 4 commit: Update CodeMirror to 5.43.0 to resolve issues with au

2019-02-21 Thread Dave Page
Update CodeMirror to 5.43.0 to resolve issues with auto-indent. Fixes #3583 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=bacb57086c73f887ec3001497d53a85932938807 Modified Files -- docs/en_US/release_notes_4_3.rst | 1 + libraries

[pgAdmin4][Patch]: Feature #2418 add rollback and commit action buttons on Query Tool

2019-02-21 Thread Akshay Joshi
Hi Hackers, Attached is the implementation of feature #2418 "add rollback and commit action buttons on Query Tool". I have added jasmine test cases, modified regression test. I have not added feature test as it is not stable and document is also not updated as we are going to update the new screen

pgAdmin 4 commit: Don't exclude SELECT statements from transaction mana

2019-02-21 Thread Dave Page
Don't exclude SELECT statements from transaction management in the Query Tool in case they call data-modifying functions. Fixes #3958 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5be0d17df58041988548b3bec1cecd1ee59bca40 Author: Akshay Joshi

Re: [pgAdmin4][Patch]: RM #3958 Query Tool commits after SELECT statements regardless of 'Auto commit' setting

2019-02-21 Thread Dave Page
Thanks, patch applied. On Tue, Feb 19, 2019 at 6:58 AM Akshay Joshi wrote: > Hi Hackers, > > Attached is the patch to fix RM "#3958 Query Tool commits after SELECT > statements regardless of 'Auto commit' setting." > > Please review it. > > -- > *Akshay Joshi* > > *Sr. Software Architect * > > >

pgAdmin 4 commit: Disable the editor and execute functions whilst queri

2019-02-21 Thread Dave Page
Disable the editor and execute functions whilst queries are executing. Fixes #4021 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=98283c121399c8dfe18b81b19be3d8862128050d Author: Khushboo Vashi Modified Files -- docs/en_US/relea

Re: [pgAdmin4][Pattch] - RM #3673 - "Download as .csv" F8 does NOT work when one of joined files is a TEMPORARY file

2019-02-21 Thread Dave Page
Thanks - I realised we also needed to disable the Save button and menu and Download button, so I added them and committed. On Wed, Feb 20, 2019 at 12:16 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Dave, > > On Wed, Feb 20, 2019 at 5:22 PM Dave Page wrote: > >> Thanks, patch

Re: [pgAdmin4][Patch]: Feature #2418 add rollback and commit action buttons on Query Tool

2019-02-21 Thread Dave Page
Hi On Thu, Feb 21, 2019 at 12:40 PM Akshay Joshi wrote: > Hi Hackers, > > Attached is the implementation of feature #2418 "add rollback and commit > action buttons on Query Tool". I have added jasmine test cases, modified > regression test. I have not added feature test as it is not stable and >

pgAdmin 4 commit: Fix an issue where importing servers fails if a group

2019-02-21 Thread Dave Page
Fix an issue where importing servers fails if a group already exists for a different user. Fixes #4022 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=73b144c45c991340f1b0c4ca70a6457be1fd5feb Modified Files -- docs/en_US/release_n