Re: [pgAdmin4][RM#2813] Do not prompt for database server password once user saves it

2020-04-10 Thread Akshay Joshi
Hi Murtuza The issue is still reproducible when you add a new server with Save Password is checked. Disconnect the server and connect again, it ask for the Password. Please fix the above and resend the patch. On Thu, Apr 9, 2020 at 7:01 PM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> w

pgAdmin 4 commit: Fixed gettext usage:

2020-04-10 Thread Akshay Joshi
Fixed gettext usage: - fixed gettext usage with .format() only for original text with %s - fixed typos - fixed translation yes/no buttons in the dialog. - improved translating sentences without "connecting" words (eg. see web/pgadmin/dashboard/static/js/dashboard.js, word 'cancel' nee

pgAdmin 4 commit: Ensure that OID should be shown in properties for Syn

2020-04-10 Thread Akshay Joshi
Ensure that OID should be shown in properties for Synonyms. Fixes #5270 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e238ecf1825af3a2d4ffe21a683df6d8b64627f9 Author: Khushboo Vashi Modified Files -- docs/en_US/release_notes_4_2

Re: [pgAdmin4][Patch] - RM 5270 - [EPAS] Synonym properties does not show OID.

2020-04-10 Thread Akshay Joshi
Thanks patch applied. On Fri, Apr 10, 2020 at 11:58 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached updated patch. > > Thanks, > Khushboo > > On Fri, Apr 10, 2020 at 10:41 AM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi Akshay,

Re: pgAdmin 4 - next gettext usage fixes

2020-04-10 Thread Akshay Joshi
Hi Libor Thanks, patch applied. Please make sure to run the PEP8 checks before sending the patch. I have fixed and committed the code. On Wed, Apr 8, 2020 at 9:30 PM Libor M. wrote: > Hello, > I fixed next gettext usage: > > - fixed gettext usage with .format() only for original text with %s >

Re: [pgAdmin][RM5227] Cannot add user

2020-04-10 Thread Akshay Joshi
Hi Aditya Can you please rebase and send the patch again. On Fri, Apr 10, 2020 at 10:33 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to fix following user management related issues: > 1) Unable to add a user when there are many users. Th

[pgAdmin][RM3523] Right clicking a browser object does not apply to the object on which right click was fired.

2020-04-10 Thread Aditya Toshniwal
Hi Hackers, Attached is the patch to fix a context menu issue where Ctrl+Click a browser object opens the context menu, but the menu operations does not apply on the item selected. The patch also fixes keyboard navigation on the context menu applied to browser tree. Please review. -- Thanks and

Re: [pgAdmin4][RM#2813] Do not prompt for database server password once user saves it

2020-04-10 Thread Murtuza Zabuawala
Hi Akshay, Thanks for reviewing, PFA updated patch, it was a minor logical conditional issue. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Apr 10, 2020 at 2:17 PM Akshay Joshi wrote: > Hi Murtuza > > The issue is still rep

Re: [pgAdmin][RM5227] Cannot add user

2020-04-10 Thread Aditya Toshniwal
Hi Hackers, Attached is the updated rebased patch. On Fri, Apr 10, 2020 at 3:13 PM Akshay Joshi wrote: > Hi Aditya > > Can you please rebase and send the patch again. > > On Fri, Apr 10, 2020 at 10:33 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attac

pgAdmin 4 commit: Fixed user management related issues:

2020-04-10 Thread Akshay Joshi
Fixed user management related issues: 1) Unable to add a user when there are many users. The dialog went blank. Fixed. 2) The error message did not have a close button. Fixed. 3) When clicked on the add button, then the cursor will focus on the email box of the new row for convenience. 4)

pgAdmin 4 commit: Fixed an issue where right-clicking a browser object

2020-04-10 Thread Akshay Joshi
Fixed an issue where right-clicking a browser object does not apply to the object on which right-click was fired. Fixes #3523 Fixes keyboard navigation on the context menu applied to browser tree. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff

pgAdmin 4 commit: Fixes following OSX native keyboard shortcuts in Quer

2020-04-10 Thread Akshay Joshi
Fixes following OSX native keyboard shortcuts in Query Tool: 1) option+arrow (L/R) should skip by "word" 2) option+arrow (up/down) should go up/down one line 3) shift+option+arrow (L/R) should select/highlight by "word" Branch -- master Details --- https://git.postgresql.org/gitweb?

pgAdmin 4 commit: Ensure that the password prompt should not be visible

2020-04-10 Thread Akshay Joshi
Ensure that the password prompt should not be visible if the database server is in trust authentication mode. Fixes #2813 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4de6b93ba80fd9326cd4dd8801cb21158e6c4f84 Author: Murtuza Zabuawala Modi

Re: [pgAdmin4][RM#2813] Do not prompt for database server password once user saves it

2020-04-10 Thread Akshay Joshi
Thanks, patch applied. On Fri, Apr 10, 2020 at 4:00 PM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Akshay, > > Thanks for reviewing, PFA updated patch, it was a minor logical > conditional issue. > > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprise

Re: [pgAdmin][RM3523] Right clicking a browser object does not apply to the object on which right click was fired.

2020-04-10 Thread Akshay Joshi
Thanks, patch applied. On Fri, Apr 10, 2020 at 3:30 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to fix a context menu issue where Ctrl+Click a > browser object opens the context menu, but the menu operations does not > apply on the item

Re: [pgAdmin][RM5227] Cannot add user

2020-04-10 Thread Akshay Joshi
Thanks, patch applied. On Fri, Apr 10, 2020 at 4:11 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the updated rebased patch. > > On Fri, Apr 10, 2020 at 3:13 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Aditya >> >> Can you plea

Re: [pgAdmin][RM3972] Standard OSX keyboard behaviour in Query Tool.

2020-04-10 Thread Akshay Joshi
Thanks, patch applied. On Fri, Apr 10, 2020 at 11:24 AM Nagesh Dhope wrote: > Hi Hackers, > Please find a patch, which fixes following OSX native keyboard shortcuts > in Query Tool. > >1. option+arrow (L/R) should skip by "word" >2. option+arrow (up/down) should go up/down one line >

[pgAdmin4][RM#4858] Allow user to reconnect to DB server when connection is drop

2020-04-10 Thread Murtuza Zabuawala
Hi, Upon downloading the csv file, we used the prompt for re-connecting to the database server when there is a database server connection issue. Currently the user tries to download CSV and there is a connection issue then it is showing a python exception error. Steps: 1) Open query tool 2) Execu

Re: Proposal: Drop support for Internet Explorer

2020-04-10 Thread Bill Evans
It is not doing people a favor to help them continue to use an unsupported browser that no longer receives security updates. Sent from my iPad On Apr 8, 2020, at 4:26 PM, Darren Duncan wrote: If its hard to know how many people are actually using Internet Explorer: You could make the next r

Re: Proposal: Drop support for Internet Explorer

2020-04-10 Thread Doug Reed
All, Just my two cents. I am the CTO of CirrusPoint Solutions. We have an Enterprise level Browser-based application that is used by very large corporations as a network management and reporting dashboard. These huge companies are almost always heavily Microsoft focused, and slow to upgrade. Ev