pgAdmin 4 commit: Updated Flask-BabelEx to the latest. Fixes #5997

2020-12-31 Thread Akshay Joshi
Updated Flask-BabelEx to the latest. Fixes #5997 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6fce58f2ad4de729a0005c75fb2702913cdd0ead Author: Nikhil Mohite Modified Files -- docs/en_US/release_notes_4_30.rst | 1 + requirements

pgAdmin 4 commit: Improve code coverage and API test cases for pgAgent.

2020-12-31 Thread Akshay Joshi
Improve code coverage and API test cases for pgAgent. Fixes #5338 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d1f5511566c2959f5dac230d1965474034884810 Author: Yogesh Mahajan Modified Files -- docs/en_US/release_notes_4_30.rst

pgAdmin 4 commit: Fixed RESQL test cases for schema

2020-12-31 Thread Akshay Joshi
Fixed RESQL test cases for schema Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=cd5243ac6d0422db4ec4592b16a51432f0e5212b Author: Nikhil Mohite Modified Files -- .../databases/schemas/templates/schemas/ppas/9.2_plus/sql/defacl.sq

Re: [pgAdmin][RM-5997]: Incorrect Flask-BabelEx version in requirements for pgAdmin 4.28.

2020-12-31 Thread Akshay Joshi
Thanks, patch applied. On Wed, Dec 30, 2020 at 4:15 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Team, > > Please find the attached patch for RM-5997 > : Incorrect Flask-BabelEx > version in requirements for pgAdmin 4.28. > Added minim

Re: [pgAdmin][RESQL]: Fix for schema RESQL test cases.

2020-12-31 Thread Akshay Joshi
Thanks, patch applied. On Thu, Dec 31, 2020 at 12:14 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Team, > > Please find the attached patch to fix the RESQL test cases for the schema. > > > -- > *Thanks & Regards,* > *Nikhil Mohite* > *Software Engineer.* > *EDB Postgres*

Re: Housekeeping #5338 - [Code Coverage] Improve API test cases for pgAgent

2020-12-31 Thread Akshay Joshi
Thanks, patch applied. On Wed, Dec 30, 2020 at 9:34 PM Yogesh Mahajan < yogesh.maha...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch for API tests for pgAgent (jobs, schedules, > steps). > > Thanks, > Yogesh Mahajan > EnterpriseDB > -- *Thanks & Regards* *Akshay Joshi* *pgA

Re: [pgAdmin][RM-6088]: Migrate pgadmin4 from Flask-BabelEx to Flask-Babel >= 2.0

2020-12-31 Thread Khushboo Vashi
On Wed, Dec 30, 2020 at 12:29 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Team, > > I found one issue related to Flask-Babel migration. > > Flask-Babel and Flask-BabelEx are causing the issue if we install them in > the same environment. > Flask-BabelEx gets installed as a depen

Re: [pgAdmin][RM5571] Expression in exclusion constraint is misinterpreted and quoted as column name by mistake

2020-12-31 Thread Aditya Toshniwal
Hi Hackers, The changes in CREATE TABLE sql were missed. Attached patch adds the changes. On Thu, Dec 24, 2020 at 3:02 PM Akshay Joshi wrote: > Thanks, patch applied. > > On Thu, Dec 24, 2020 at 1:46 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi, >> >> Attached patch

Re: [pgAdmin4][Patch] - RM 5457 - Kerberos Authentication - Phase 1

2020-12-31 Thread Aditya Toshniwal
Hi Khushboo, I've just done the code review. Apart from below, the patch looks good to me: 1) Move the auth source constants -ldap, kerberos out of app object. They don't belong there. You can create the constants somewhere else and import them. +app.PGADMIN_LDAP_AUTH_SOURCE = 'ldap' +app.PGADM