Re: [patch][pgAdmin] RM3893 pgadmin4 Reassign/Drop Owned

Hi Rahul Following are the review comments: - The context menu should be renamed to 'Reassign/Drop Owned...' instead of 'Reassign/Drop role'. - Remove " role" from the dialog header. It should be "Reassign/Drop Owned - " - We have only two operations "Reassign and Drop", so instead

pgAdmin 4 commit: Fixed an issue where detaching the query editor panel

Fixed an issue where detaching the query editor panel gives a blank white panel. Fixes #6398 Branch -- React_Porting Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0f34231cced4baf10f7f332c6cc5418819910806 Author: Pradip Parkale Modified Files --

pgAdmin 4 commit: Fixed an issue where the New Connection Drop Down has

Fixed an issue where the New Connection Drop Down has lost default maintenance database, auto-select, and tab-through functionality. Fixes #6505 Branch -- React_Porting Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e756421daf8608b815050454049626b72877a695 Au

pgAdmin 4 commit: Fixed feature tests failure issue due to binary path

Fixed feature tests failure issue due to binary path feature. Branch -- React_Porting Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=911ed654bc62e4d7dfab309a377bcfbfc55e7e45 Author: Yogesh Mahajan Modified Files -- .../pg_utilities_backup_restore

pgAdmin 4 commit: Fixed an issue in the search object when searching in

Fixed an issue in the search object when searching in 'all types' or 'subscription' if the user doesn't have access to the subscription. Fixes #6448 Branch -- React_Porting Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=13df6d319b6910e35068e29c318340362e5550a

pgAdmin 4 commit: Fixed replace keyboard shortcut issue in the query to

Fixed replace keyboard shortcut issue in the query tool on the normal keyboard layout. Fixes #6388 Branch -- React_Porting Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=284fa9cac6c55fa55c1220c84edab37b2dfc305c Author: Aditya Toshniwal Modified Files --

pgAdmin 4 commit: Do not block the query editor window when running a q

Do not block the query editor window when running a query. Fixes #3920 Branch -- React_Porting Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3e9bcee1b096c0c78a849acdbbc38765897a22f7 Author: Aditya Toshniwal Modified Files -- docs/en_US/release_n

pgAdmin 4 commit: Fix path on windows. Fixes #6558

Fix path on windows. Fixes #6558 Branch -- React_Porting Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=bf312a6082ea50953b0b4fa8cad0bb47d03b28e6 Author: Dave Page Modified Files -- docs/en_US/config_py.rst | 2 +- 1 file changed, 1 insertion(+), 1

pgAdmin 4 commit: Ensure that setting 'Open in new browser tab' should

Ensure that setting 'Open in new browser tab' should be visible, it should not be based on the value of 'ENABLE_PSQL'. Fixes #6541 Branch -- React_Porting Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0b1efd5647823c0023ea7996252869411989c0b5 Author: Nikhil M

pgAdmin 4 commit: Fixed an issue where Execute/Refresh button should no

Fixed an issue where Execute/Refresh button should not be disabled when we run the empty query. Fixes #6489 Branch -- React_Porting Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5e514984dec57c4e7b76637c466da8e454d60db9 Author: Nikhil Mohite Modified Files

pgAdmin 4 commit: Ensure that Data Output panel can be snapped back aft

Ensure that Data Output panel can be snapped back after it is detached. Fixes #4189 Branch -- React_Porting Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=000b356dfd215e0d639fa446bda91280951ecdfa Author: Nikhil Mohite Modified Files -- docs/en_U

pgAdmin 4 commit: Refactor the registry class logic and remove duplicat

Refactor the registry class logic and remove duplicate code for the same functionality. Branch -- React_Porting Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=100bc504c890b44db21c43733b60669ddef9db7b Author: Ashesh Vashi Modified Files -- web/pg

pgAdmin 4 commit: Revert "Fixed API test cases for PG/EPAS 9.6" per Khu

Revert "Fixed API test cases for PG/EPAS 9.6" per Khushboo. This reverts commit 37278f2cd32bb16dddbfe9926c143b53f8efa8d0. Branch -- React_Porting Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=986b2650b6e12ab7eafc81c740819ee32cb93656 Author: Dave Page Modif

pgAdmin 4 commit: Fixed Czech translation string for 'Login' keyword. F

Fixed Czech translation string for 'Login' keyword. Fixes #6555 Patch sent by: Waclaw Branch -- React_Porting Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5468d8c324dd2859f607d757dd63698532c05ca4 Modified Files -- docs/en_US/release_notes_5_5.r

pgAdmin 4 commit: Added missing gettexts and text space improvements.

Added missing gettexts and text space improvements. Branch -- React_Porting Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f61001e4412c59d67b1322162456ba37245dbabb Author: Libor M Modified Files -- .../servers/databases/subscriptions/static/js/su

Re: Refactor: Registry Classes

Hi, This patch introduced the server mode api test case failure, please find the attached patch to fix those as well as some of the old issues in the server mode. Patch by: Ashesh Vashi Thanks, Khushboo On Thu, Jun 24, 2021 at 11:31 AM Akshay Joshi wrote: > Thanks, the patch applied. > > On W

pgAdmin 4 commit: Added React framework for the properties dialog and p

Added React framework for the properties dialog and port Server Group, Server, and Database dialogs. Following changes done for the framework: - Framework for creating React based dynamic form view out of a pre-defined UI schema. Previously, it was based on Backform/Backbone. - The new framework

Re: [pgAdmin][RM6130] React based framework for properties dialog and port Server Group, Server and Database dialogs

Thanks, the patch applied in the "React_Porting" branch. On Mon, Jun 21, 2021 at 9:35 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Dave, > > On Thu, Jun 17, 2021 at 7:26 PM Dave Page wrote: > >> Hi >> >> On Thu, Jun 17, 2021 at 11:01 AM Aditya Toshniwal < >> aditya.toshni

Re: [pgAdmin][RM6398]: Detaching query editor panel gives a blank white panel.

Hi Akshay, Please find attached for debugger and ERD tool which was missing in my previous patch. On Wed, Jun 23, 2021 at 11:50 AM Akshay Joshi wrote: > Thanks, the patch applied. > > On Wed, Jun 16, 2021 at 11:29 PM Pradip Parkale < > pradip.park...@enterprisedb.com> wrote: > >> Hi Hackers, >>

Re: [pgAdmin][RM6398]: Detaching query editor panel gives a blank white panel.

Hi Pradip I have seen that we have duplicated code for resize_the_queryTool, resize_the_erdtool, resize_the_psql, and in debugger_ui.js file. I would suggest making a common function somewhere in the utils and call that function. In the future, if we need to change the code we will have to change

pgAdmin 4 commit: Fixed copy/paste issues for PSQL tool terminal. Fixes

Fixed copy/paste issues for PSQL tool terminal. Fixes #6547. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6645625e6b3f3efc2f3ae11be09afccc0292df4f Author: Nikhil Mohite Modified Files -- docs/en_US/release_notes_5_5.rst

pgAdmin 4 commit: Fixed server mode api test case failure.

Fixed server mode api test case failure. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=cfb68d73a0a4b65c03a1a5220bbd53640c2f67ee Author: Ashesh Vashi Modified Files -- web/pgadmin/browser/tests/test_change_password.py | 2

Re: [pgAdmin][RM-6547]: Issue with Copy/ Paste on PSQL tool terminal.

Thanks, the patch applied. On Thu, Jun 24, 2021 at 6:09 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Hackers, > > Please find the attached patch for RM-6547 > :Issue with Copy/ Paste on > PSQL tool terminal. > 1. Resolved paste issue o

Re: Refactor: Registry Classes

Thanks, the patch applied. On Thu, Jun 24, 2021 at 3:51 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > This patch introduced the server mode api test case failure, please find > the attached patch to fix those as well as some of the old issues in the > server mode. > Patch

Re: [pgAdmin][RM6398]: Detaching query editor panel gives a blank white panel.

Hi Akshay, Please find the updated patch. I have moved the function into the utility file now. On Thu, Jun 24, 2021 at 7:56 PM Akshay Joshi wrote: > Hi Pradip > > I have seen that we have duplicated code for resize_the_queryTool, > resize_the_erdtool, resize_the_psql, and in debugger_ui.js file.

pgAdmin 4 commit: Fixed an issue where Debugger and ERD tool panel give

Fixed an issue where Debugger and ERD tool panel give a blank white panel, missing from the last patch. refs #6398 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5581f0909a4f0da0ba3419ea6da9c29dfd893b06 Author: Pradip Parkale Modified File

pgAdmin 4 commit: Remove some configuration from the about dialog.

Remove some configuration from the about dialog. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=462b86df8d3a2d9a42f2e946f4478f629304d726 Author: Pradip Parkale Modified Files -- web/pgadmin/about/__init__.py| 2 +-

Re: [pgAdmin][RM6398]: Detaching query editor panel gives a blank white panel.

Thanks, the patch applied. On Thu, Jun 24, 2021 at 9:16 PM Pradip Parkale < pradip.park...@enterprisedb.com> wrote: > Hi Akshay, > Please find the updated patch. I have moved the function into the utility > file now. > > On Thu, Jun 24, 2021 at 7:56 PM Akshay Joshi < > akshay.jo...@enterprisedb.c