[pgAdmin][patch] Incorrect indentation in table python code

2021-07-29 Thread Aditya Toshniwal
Hi Hackers, Attached patch fixes the indentation of a python code which can be a potential bug. Please review. -- Thanks, Aditya Toshniwal pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* "Don't Complain about Heat, Plant a TREE" table.incorrect-indentation.p

Re: [pgAdmin][patch] Incorrect indentation in table python code

2021-07-29 Thread Aditya Toshniwal
Hi Hackers, Please ignore the previous patch. Attached is the updated one. The patch aims - Fix potential buggy code in table python code. On Thu, Jul 29, 2021 at 12:32 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached patch fixes the indentation of a pyt

[pgAdmin4] Questions about trigger properties's Fires in edit mode

2021-07-29 Thread zhangj...@fujitsu.com
Hi, all In trigger's Properties screen, the 'fires' is disabled. What is the reason why 'fires' is disabled? I think it should be the same as 'evnt_insert', When server_type is ppas and in edit mode, 'fires' is disabled. file: web/pgadmin/browser/server_groups/servers/databases/schemas/tables/tr

Re: [pgAdmin4] Questions about trigger properties's Fires in edit mode

2021-07-29 Thread Aditya Toshniwal
Hi, PostgreSQL allows an alter only for name - https://www.postgresql.org/docs/current/sql-altertrigger.html. Even if we enable it, we cannot generate the SQL for the change. On Thu, Jul 29, 2021 at 3:23 PM zhangj...@fujitsu.com wrote: > Hi, all > > In trigger's Properties screen, the 'fires' i

[pgAdmin][RM-6592]: [React] Port Materialized View node to react

2021-07-29 Thread Nikhil Mohite
Hi Hackers, Please find the attached patch for RM-6592 : [React] Port Materialized View node to react Also fixed issues in view node related to validation and code field is editable for views under catalogs node. -- *Thanks & Regards,* *Nikhil Mohite*