[pgadmin4][patch] fix history panel on ie11

2017-07-07 Thread Sarah McAlear
Hi Hackers! This patch fixes the layout issues on IE11. There is a known issue on react-split-pane that requires a previous version of bowser in order to render correctly on IE11. We had to downgrade the version of bowser to 1.6.1 until the relevant pull request to react-split-pane has been accept

[pgadmin-hackers][patch] Update the error alerts style in dialog

2017-07-07 Thread Joao De Almeida Pereira
Hi Hackers, We updated the style of the error alerts in the dialogs window to match the style guide. Below is a screenshot of how it looks: [image: Inline image 1] Thanks Shruti & Joao change-style-of-error-alerts-in-dialogs.patch Description: Binary data

pgAdmin 4 commit: Revert "Open query tool and debugger windows in new t

2017-07-07 Thread Dave Page
Revert "Open query tool and debugger windows in new tabs by default." This reverts commit 1a6fe946ce69736a4b9af8bcd79568f907fa383a. This is going to break the regression tests, so reverting it for now. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commi

pgAdmin 4 commit: Open query tool and debugger windows in new tabs by d

2017-07-07 Thread Dave Page
Open query tool and debugger windows in new tabs by default. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1a6fe946ce69736a4b9af8bcd79568f907fa383a Modified Files -- web/pgadmin/tools/debugger/__init__.py | 2 +- web/pgadmin/tool

pgAdmin 4 commit: Fix alert animation on IE11

2017-07-07 Thread Dave Page
Fix alert animation on IE11 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=08e874a0266e56f07ec61cbeed1173c249a2311f Author: Murtuza Zabuawala Modified Files -- web/pgadmin/static/scss/_alert.scss | 1 + web/pgadmin/s

Re: [RM2534][pgAdmin4] Fix issues related to table OF TYPE property.

2017-07-07 Thread Dave Page
Thanks, applied. On Fri, Jul 7, 2017 at 2:41 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > Please find attached patch to fix issue related to table OF TYPE property. > > -- > *Harshal Dhumal* > *Sr. Software Engineer* > > EnterpriseDB India: http://www.enterprisedb.com >

pgAdmin 4 commit: Fix handling of CREATE TABLE OF . Fixes #2534

2017-07-07 Thread Dave Page
Fix handling of CREATE TABLE OF . Fixes #2534 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d151bdb4cd9b6038864dc9596d279860628cb70f Author: Harshal Dhumal Modified Files -- .../databases/schemas/tables/static/js/table.js| 3

Re: [pgadmin-hackers][patch] delete icon width in security labels form

2017-07-07 Thread Dave Page
Hi On Thu, Jul 6, 2017 at 4:13 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Hackers, > > We found a discrepancy with the width of inserted columns in some backform > tables. It is at least present in Create Table -> Security [tab] -> > clicking [+] for new rows under

Jenkins build is back to normal : pgadmin4-master-python33 #222

2017-07-07 Thread pgAdmin 4 Jenkins
See

pgAdmin 4 commit: Improve spacing around delete icons in backform table

2017-07-07 Thread Dave Page
Improve spacing around delete icons in backform tables. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=815c4b4c452a03d46f70689dedad2a9be8261735 Author: Joao Pedro De Almeida Pereira Modified Files -- .../browser/server_groups/ser

Jenkins build is back to normal : pgadmin4-master-python26 #343

2017-07-07 Thread pgAdmin 4 Jenkins
See

Re: [pgAdmin4][Patch] To fix the issue in Function, Procedure & Trigger Function modules

2017-07-07 Thread Dave Page
Of course, yes you're correct. Thanks - patch applied. On Thu, Jul 6, 2017 at 3:59 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Sorry, I think my last statement was misleading. > > No, It's not broken, I meant the behaviour is taken from pgAdmin3, It is > disabled by defau

pgAdmin 4 commit: Fix the formatting of the ROWS option for functions e

2017-07-07 Thread Dave Page
Fix the formatting of the ROWS option for functions etc. Fixes #2537 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=acd3568f064be65ec82d2b2e20189b7cf3df2fef Author: Murtuza Zabuawala Modified Files -- .../schemas/functions/templa

pgAdmin 4 commit: Enable pretty html output of our karma test results.

2017-07-07 Thread Dave Page
Enable pretty html output of our karma test results. While running yarn test:karma, visit localhost:9876/debug.html to see test output. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8646e9e404401478342ed44e41ed9fa009fe0e63 Author: Sarah McAl

Re: [pgadmin-hackers][pgAdmin4][Patch] Make karma test results output to browser

2017-07-07 Thread Dave Page
Thanks, applied. On Thu, Jul 6, 2017 at 3:09 PM, Sarah McAlear wrote: > Hi Hackers! > > Attached is a minor patch that enables pretty html output of our karma > test results. While running yarn test:karma, visit > localhost:9876/debug.html to see test output. > > Thanks, > Matt and Sarah > --

Re: Fix clear history option [pgAdmin4][RM2535]

2017-07-07 Thread Dave Page
Thanks, applied. On Thu, Jul 6, 2017 at 2:50 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > Please find attached patch to fix clear history functionality in query > tool. > > -- > *Harshal Dhumal* > *Sr. Software Engineer* > > EnterpriseDB India: http://www.enterprisedb.co

pgAdmin 4 commit: Fix clear history.

2017-07-07 Thread Dave Page
Fix clear history. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fc782026005b85ecf6ff9cc9602422c936fba44e Author: Harshal Dhumal Modified Files -- web/pgadmin/static/js/history/history_collection.js | 6 +- web/pgad

[RM2534][pgAdmin4] Fix issues related to table OF TYPE property.

2017-07-07 Thread Harshal Dhumal
Hi, Please find attached patch to fix issue related to table OF TYPE property. -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/static/js/

RE: Windows testing required: Updated runtime

2017-07-07 Thread Mike Surcouf
Hi Dave that was a type yes I deleted pgAdmin under appdata From: Dave Page [mailto:dp...@pgadmin.org] Sent: 07 July 2017 12:40 To: Mike Surcouf Cc: pgadmin-hackers; pgAdmin Support Subject: Re: Windows testing required: Updated runtime If you've done that, then you really have removed everything

Re: Windows testing required: Updated runtime

2017-07-07 Thread Dave Page
If you've done that, then you really have removed everything except for a handful of registry entries. To completely start over you should: - Uninstall pgAdmin - Ensure the original installation directory is removed entirely. - Remove "%APPDATA%\pgAdmin" (not %APPDATA%\pgAdmin4) - Remove "HKEY_CUR

Jenkins build is back to normal : pgadmin4-master-python35 #222

2017-07-07 Thread pgAdmin 4 Jenkins
See

Jenkins build is back to normal : pgadmin4-master-python27 #227

2017-07-07 Thread pgAdmin 4 Jenkins
See

Jenkins build is back to normal : pgadmin4-master-python34 #212

2017-07-07 Thread pgAdmin 4 Jenkins
See

Jenkins build is back to normal : pgadmin4-master-python36 #219

2017-07-07 Thread pgAdmin 4 Jenkins
See

Build failed in Jenkins: pgadmin4-master-python33 #221

2017-07-07 Thread pgAdmin 4 Jenkins
See Changes: [akshay.joshi] Partitioned table does not present in grant wizard. Fixes #2543 -- [...truncated 132.82 KB...] Fetch synonym Node URL ... skipped 'Syn

Build failed in Jenkins: pgadmin4-master-python26 #342

2017-07-07 Thread pgAdmin 4 Jenkins
See Changes: [akshay.joshi] Partitioned table does not present in grant wizard. Fixes #2543 -- [...truncated 136.46 KB...] Fetch synonym Node URL ... skipped 'Syn

pgAdmin 4 commit: Partitioned table does not present in grant wizard. F

2017-07-07 Thread Akshay Joshi
Partitioned table does not present in grant wizard. Fixes #2543 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fae185ff661e4c29de377446736fb798dc5b352e Modified Files -- .../templates/grant_wizard/pg/10_plus/sql/table.sql | 20 ++

RE: Windows testing required: Updated runtime

2017-07-07 Thread Mike Surcouf
IN addition I uninstalled removed everything in %APPDATA%\pgadmin4 and programfiles and restarted reinstalled. Also trying with AV disabled. Unfortunately I still get the same results. From: Mike Surcouf [mailto:mi...@surcouf.co.uk] Sent: 07 July 2017 10:17 To: 'Dave Page' Cc: pgadmin-hackers; pg

RE: Windows testing required: Updated runtime

2017-07-07 Thread Mike Surcouf
HI Dave Machine is Windows 7 x64 Intel Core 6400 2.33GHz 6GB ram SSD I can no longer start pgAdmin the progress wheel just keeps running. and it never gets to dashboard. Not much info sorry. The Event log for exception on close is Log Name: Application Source:Application Error Da

RE: Windows testing required: Updated runtime

2017-07-07 Thread Mike Surcouf
Hi Dave 30 second start-up so still very slow for me. Consistently get an exception when closing( see attachment) Did webpack not make it? I still get 167 requests on start up. Thanks Mike From: Dave Page [mailto:dp...@pgadmin.org] Sent: 06 July 2017 15:59 To: pgadmin-hackers; pgAdmin Support

Re: Windows testing required: Updated runtime

2017-07-07 Thread Dave Page
All, Thank you to those that have tested this build. With a couple of exceptions, most folks seem to be reporting the improved performance we hoped for. There is more work to do to finish up this patch which is underway, and there is also additional optimisation work being done for future releases

Re: Windows testing required: Updated runtime

2017-07-07 Thread Dave Page
Hi On Fri, Jul 7, 2017 at 9:20 AM, Mike Surcouf wrote: > Hi Dave > > > > 30 second start-up so still very slow for me. > That's strange - I get < 12s even on my underpowered virtual machine. What spec machine are you running? Can you try with AV disabled? > > > Consistently get an exception

Build failed in Jenkins: pgadmin4-master-python34 #211

2017-07-07 Thread pgAdmin 4 Jenkins
See Changes: [akshay.joshi] Fixed issue by adding extra check for 'relkind' column -- [...truncated 480.29 KB...] TriggersUpdateTestCase (Put trig

Build failed in Jenkins: pgadmin4-master-python33 #220

2017-07-07 Thread pgAdmin 4 Jenkins
See Changes: [akshay.joshi] Fixed issue by adding extra check for 'relkind' column -- [...truncated 480.33 KB...] Create L

Build failed in Jenkins: pgadmin4-master-python36 #218

2017-07-07 Thread pgAdmin 4 Jenkins
See Changes: [akshay.joshi] Fixed issue by adding extra check for 'relkind' column -- [...truncated 480.39 KB...] Create L

Build failed in Jenkins: pgadmin4-master-python26 #341

2017-07-07 Thread pgAdmin 4 Jenkins
See Changes: [akshay.joshi] Fixed issue by adding extra check for 'relkind' column -- [...truncated 474.61 KB...] SynonymAddTestCase (Default Node

Build failed in Jenkins: pgadmin4-master-python35 #221

2017-07-07 Thread pgAdmin 4 Jenkins
See Changes: [akshay.joshi] Fixed issue by adding extra check for 'relkind' column -- [...truncated 480.48 KB...] DatabaseAddTestCase (Check Datab

Build failed in Jenkins: pgadmin4-master-python27 #226

2017-07-07 Thread pgAdmin 4 Jenkins
See Changes: [akshay.joshi] Fixed issue by adding extra check for 'relkind' column -- [...truncated 471.13 KB...] SynonymAddTestCase (Default Node

Build failed in Jenkins: pgadmin4-master-python35 #220

2017-07-07 Thread pgAdmin 4 Jenkins
See Changes: [akshay.joshi] Added support of Declarative Partitioning (Range, List) for PostgreSQL -- [...truncated 486.42 KB...] TableUpdateTest

pgAdmin 4 commit: Fixed issue by adding extra check for 'relkind' colum

2017-07-07 Thread Akshay Joshi
Fixed issue by adding extra check for 'relkind' column Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e793413d76a245dfcdb73e37abbf1df6f9676242 Modified Files -- .../browser/server_groups/servers/databases/schemas/tables/utils.py

Build failed in Jenkins: pgadmin4-master-python27 #225

2017-07-07 Thread pgAdmin 4 Jenkins
See Changes: [akshay.joshi] Added support of Declarative Partitioning (Range, List) for PostgreSQL -- [...truncated 477.15 KB...] TableUpdateTest