Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

I'd say we should go with Cmd+/ and Cmd+Shift+/ as that seems the most common by a small margin - however, I'm still not convinced that we don't need two keys for optimal behaviour of line commenting. To be clear, I'm not 100% convinced either. I am, however, convinced that it is the right first

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

On Fri, Jul 21, 2017 at 8:57 PM, Shirley Wang wrote: > Until we learn definitively from users that the current implementation of > commenting/uncommenting in other tools is not working, we should use what > is common practice. We can use that as a baseline and then if we learn

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

Until we learn definitively from users that the current implementation of commenting/uncommenting in other tools is not working, we should use what is common practice. We can use that as a baseline and then if we learn that there needs to be another shortcut, we can add additional functionality.

Re: [pgAdmin4][Patch] Font sizes to 13 px and not bolded

Oh whoa I didn't realize they became all wonky. It also looks like headers in the statistics table is still bold, so perhaps there's something missing in our patch. We'll take a look. On Thu, Jul 20, 2017 at 4:01 PM Dave Page wrote: > Hi > > On Thu, Jul 20, 2017 at 7:55 PM,

Jenkins build is back to normal : pgadmin4-master-python26 #381

See

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

On Fri, Jul 21, 2017 at 4:43 PM, Robert Eckhardt wrote: > I understand now. > > If any one line is different then the entire thing will be commented so in > your example: > > --CREATE TABLE foo ( > -- id serial, > -- data text > --); > > ---- Index required on data

Build failed in Jenkins: pgadmin4-master-python26 #380

See Changes: [Dave Page] Ensure babel-polyfill is loaded in older qWebKits. Fixes #2593 [Dave Page] Fix test assertion. -- [...truncated 339.62 KB...]

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

Thanks, patch applied and yarn.lock updated. On Fri, Jul 21, 2017 at 3:52 PM, Sarah McAlear wrote: > Hi! > > We looked at the patch and realized that the function to check if an > element is not clickable because it's out of view was using an incorrect > assertion. We

pgAdmin 4 commit: Fix test assertion.

Fix test assertion. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2ebb40819534d79376a577a149a8a5db124b Author: Sarah McAlear Modified Files -- web/pgadmin/feature_tests/query_tool_journey_test.py | 2 +-

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

On Fri, Jul 21, 2017 at 4:08 PM, Robert Eckhardt wrote: > I wouldn't say wrong, it just wasn't what I was expecting. > > I guess I'd like to hear what others are expecting. If I had my way we > would use > > Ctrl+/ single line comment and uncomment (prepend with --) >

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

I wouldn't say wrong, it just wasn't what I was expecting. I guess I'd like to hear what others are expecting. If I had my way we would use Ctrl+/ single line comment and uncomment (prepend with --) Ctrl+Shift+/ block comment and uncomment (bracket with /* and */) where Ctrl == command

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

Hi! We looked at the patch and realized that the function to check if an element is not clickable because it's out of view was using an incorrect assertion. We changed it and created a small patch. We also realized that on the current master the yarn.lock is causing changes when running the app.

Build failed in Jenkins: pgadmin4-master-python27-feature #9

See Changes: [Dave Page] Add controls and shortcuts for commenting/uncommenting code in the SQL [Dave Page] Fix typo in filename. [Dave Page] Webpacking cleanups [Dave Page] Fix regressions

pgAdmin 4 commit: Ensure arrow keys work correctly when the pane is foc

Ensure arrow keys work correctly when the pane is focused instead of the tab in the query tool history. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7182b5997627405449bdd0fed65aeb6de19c0a4f Author: Harshal Dhumal

Re: [pgadmin4][PATCH] Query History Arrow Navigation and Styling

On Fri, Jul 21, 2017 at 12:34 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > > > On Jul 21, 2017 4:23 PM, "Dave Page" wrote: > > > > On Fri, Jul 21, 2017 at 11:05 AM, Harshal Dhumal < > harshal.dhu...@enterprisedb.com> wrote: > >> Hi, >> >> On Fri, Jul 21, 2017

Build failed in Jenkins: pgadmin4-master-python34 #249

See Changes: [Dave Page] Add a field to the Server Dialogue allowing users to specify a subset of -- [...truncated 336.11 KB...]

Re: [pgAdmin4][Patch][RM_1918] : Implement the DB restriction field from pgAdmin III

Thanks, patch applied! A couple of tips for the future: - Please ensure screenshots are of a comparable size to the ones around them or that they replace. We sometimes see extra-large screenshots where they've been taken on hi-res screens, often in an VM. - Please be more generous with spaces,

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

I'm not sure what you mean by across platforms. Do you mean that those are the keyboard shortcuts in pgAdmin 3? Rob On Jul 21, 2017 4:42 AM, "Murtuza Zabuawala" < murtuza.zabuaw...@enterprisedb.com> wrote: Hi Robert, Just to make shortcut keys uniform across all the platforms. On Fri, Jul

Re: [pgadmin4][PATCH] Query History Arrow Navigation and Styling

On Fri, Jul 21, 2017 at 11:05 AM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > On Fri, Jul 21, 2017 at 2:24 PM, Dave Page wrote: > >> Hi >> >> On Fri, Jul 21, 2017 at 9:38 AM, Harshal Dhumal < >> harshal.dhu...@enterprisedb.com> wrote: >> >>> Hi, >>> >>>

Jenkins build is back to normal : pgadmin4-master-python27 #259

See

Re: [pgadmin4][PATCH] Query History Arrow Navigation and Styling

Hi On Fri, Jul 21, 2017 at 9:38 AM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > Currently if user clicks on empty white area below history entry then > arrow navigation does not work. > Attached patch fixes this issue. > This fixes that problem, but stops it working if I

Re: [pgAdmin4][Patch]: Stop Flask from initialising service twice in Debug mode

Thanks, applied. The reloader has always been a little temperamental for me, so I couldn't prove this doesn't break it. If someone finds it does, please yelp. On Fri, Jul 21, 2017 at 8:27 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi > > In this patch, i have added reference

pgAdmin 4 commit: Prevent the Werkzeug reloader from causing a "double

Prevent the Werkzeug reloader from causing a "double start" at init time. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a49a3103e298fcc4373856abe057dac09bc1df14 Author: Surinder Kumar Modified Files

pgAdmin 4 commit: Add an editorconfig file to help maintain coding stan

Add an editorconfig file to help maintain coding standards. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ede6765f6b2688719349f5d369123acd6c25dcd9 Author: Surinder Kumar Modified Files --

Re: [pgadmin4][PATCH] Query History Arrow Navigation and Styling

Hi, Currently if user clicks on empty white area below history entry then arrow navigation does not work. Attached patch fixes this issue. [image: Inline image 1] -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

Hi Dave, Please find updated patch. On Thu, Jul 20, 2017 at 10:35 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > > On Thu, Jul 20, 2017 at 10:29 PM, Dave Page wrote: > >> Hi >> >> On Thu, Jul 20, 2017 at 3:33 PM, Murtuza Zabuawala < >>

[pgAdmin4][Patch]: Using editorconfig to maintain consistent coding styles between different IDE's

Hi All, In pgAdmin4 codebase, the coding styles at many places is inconsistent, in some files standard coding conventions are followed and in some not. It is difficult to take care of 'tabs', 'spaces', 'trailing white-spaces', 'max_line_length' while development. So adding .editorconfig to

Re: [pgAdmin4][Patch]: Stop Flask from initialising service twice in Debug mode

Hi In this patch, i have added reference to the implementation. Please find updated patch and review. Thanks, Surinder On Fri, Jul 21, 2017 at 12:32 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi > > When pgAdmin4 runs in DEBUG mode, Flask initialise service twice, while in

[pgAdmin4][Patch]: Stop Flask from initialising service twice in Debug mode

Hi When pgAdmin4 runs in DEBUG mode, Flask initialise service twice, while in non-DEBUG mode, once. It is pain while development because `yarn run bundle` also runs twice. It is because the parameter `use_reloader` = True in Debug Mode. If `os.environ` variable `WERKZEUG_RUN_MAIN` is set to