[Patch][pgAdmin4]: RM_2617 - pgAgent module is not loading after webpacking

Hi, Added an entry for pgAgent JS module to imports-loader to fix the issue. Please find attached patch and let me know for review comments. Thanks, Surinder RM_2617.patch Description: Binary data

Re: [pgAdmin4][Patch]: RM_2596 - Query tool not working in Desktop Runtime on Mac OS X

Hi Ashesh, 1. Now we are using `envType` variable in definePlugin which sets environment variable NODE_ENV globally which is used by React to create development or production build. where: envType - determine build type is either `production` or `development`​ depending on the environment set

Build failed in Jenkins: pgadmin4-master-python36 #267

See Changes: [akshay.joshi] Improved alertify notification logic. Remove AlertifyWrapper class and -- [...truncated 336.17 KB...] TableAddTestCas

Re: [pgAdmin4][Patch]: Dashboard requests don't stop even after closing the panel

Hi Ashesh, On Mon, Jul 31, 2017 at 4:50 PM, Ashesh Vashi wrote: > > > On Fri, Jul 28, 2017 at 4:00 PM, Dave Page wrote: > >> Ashesh, can you deal with this please? Thanks. >> > Hi Khushboo, > > I've committed the code. > But - I am not able to reopen the dashboard panel once it is closed, even >

pgAdmin 4 commit: Improved alertify notification logic. Remove Alertify

Improved alertify notification logic. Remove AlertifyWrapper class and extend notification methods in alertify itself. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e506fa1dbea02f4801c1b916ff23e28f2a302911 Modified Files -- .../

pgAdmin 4 commit: 1) Added partition module in webpack config.

1) Added partition module in webpack config. 2) Fixed missing logic of partition from primary_key.js and unique_constraint.js as this two files are newly created for webpack. 3) Changed the node name from 'check_constraint' to 'check_constraints'. Also changed the same in test case url. Branch -

Re: pgAdmin 4 commit: Fix test assertion.

There has been local passing and failing on our CI. Rob On Jul 31, 2017 8:47 PM, "Harshal Dhumal" wrote: Well I'm able run all feature test cases on python 2.7 with latest pull. -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise Postgr

Re: pgAdmin 4 commit: Fix test assertion.

Well I'm able run all feature test cases on python 2.7 with latest pull. -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Jul 31, 2017 at 5:43 PM, Robert Eckhardt wrote: > It fails because the test was broke

Re: pgAdmin 4 commit: Fix test assertion.

It fails because the test was broken and has never been fixed. Rob On Jul 31, 2017 8:03 PM, "Murtuza Zabuawala" < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Robert, > > I have the latest pull and still this test is fails every time on my > machine, not sure if it is because of Python3.6. >

Re: pgAdmin 4 commit: Fix test assertion.

Hi Robert, I have the latest pull and still this test is fails every time on my machine, not sure if it is because of Python3.6. On Mon, Jul 31, 2017 at 5:27 PM, Robert Eckhardt wrote: > This was broken when the clear button and the edit button were changed to > drop downs. Happened a few week

Re: Discussion on improving alertify notifications logic

Hi, Looks good to me. Regards, Murtuza On Mon, Jul 31, 2017 at 2:59 PM, Ashesh Vashi wrote: > On Mon, Jul 31, 2017 at 2:54 PM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi All >> > >> On Fri, Jul 28, 2017 at 1:51 PM, Dave Page wrote: >> >>> >>> >>> On Thu, Jul 27, 2017 at 2:4

Re: pgAdmin 4 commit: Fix test assertion.

This was broken when the clear button and the edit button were changed to drop downs. Happened a few weeks ago. Rob On Jul 31, 2017 6:51 PM, "Murtuza Zabuawala" < murtuza.zabuaw...@enterprisedb.com> wrote: Hi All, When I run the feature tests, the gives test always fails ( 'query_tool_journey_

Re: [pgAdmin4][Patch]: Dashboard requests don't stop even after closing the panel

On Fri, Jul 28, 2017 at 4:00 PM, Dave Page wrote: > Ashesh, can you deal with this please? Thanks. > Hi Khushboo, I've committed the code. But - I am not able to reopen the dashboard panel once it is closed, even not from the docker context menu -> Add Panel > Dashboard. I have asked Murtuza to

pgAdmin 4 commit: Requests for statistics were not stopped even when Da

Requests for statistics were not stopped even when Dashboard panel is closed. It is a regression of webpack. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=bdefdf5d4ebf9495e2d877deff8d323e55816080 Modified Files -- web/pgadmin/bro

Re: pgAdmin 4 commit: Fix test assertion.

Hi All, When I run the feature tests, the gives test always fails ( 'query_tool_journey_test.py'), Python: 3.6 (64-bit) Platform: OS X (10.10.5) Am I the only one who gets this error? == ERROR: runTest (pgadmin.feature_tests.q

Re-open Dashboard

Hi, Unexpectedly I deleted dashboard tab from my account. So, I can't create a new server. Even I can't create from the object. There is no link for object drop-down. If it's not possible without the dashboard. Please delete my account permanently Thanks for your help -- Thanks & Regards, Rah

Re: [pgAdmin4][Patch]: RM_2596 - Query tool not working in Desktop Runtime on Mac OS X

On Fri, Jul 28, 2017 at 12:42 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi, > > I inspect the react code and in call stacks, found `process.env.NODE_ENV` > is undefined due to which 'SyntheticEvent.call' is not callable. > > So, to fix this, i add 'definePlugin' to plugins for

Re: Discussion on improving alertify notifications logic

On Mon, Jul 31, 2017 at 2:54 PM, Akshay Joshi wrote: > Hi All > > On Fri, Jul 28, 2017 at 1:51 PM, Dave Page wrote: > >> >> >> On Thu, Jul 27, 2017 at 2:41 PM, Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Hi All >>> >>> As in commit "Update alertify alerts to use the styling d

pgAgent commit: Added support two digits version for PostgreSQL/EDB Pos

Added support two digits version for PostgreSQL/EDB Postgres Advanced Server >= 10 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgagent.git;a=commitdiff;h=a7b82fb3d3bd3de3ce624d9e4b0da53cb9835c2d Modified Files -- CMakeLists.txt | 6 +- cmake/FindP

Re: Discussion on improving alertify notifications logic

Hi All On Fri, Jul 28, 2017 at 1:51 PM, Dave Page wrote: > > > On Thu, Jul 27, 2017 at 2:41 PM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi All >> >> As in commit "Update alertify alerts to use the styling defined in >> the style guide": >> >> https://git.postgresql.org/gitweb

[pgAdmin4][Patch]: Fix the Domain Create dialog issue

Hi, PFA minor patch to fix two issues, 1) Domain's Create/Properties dialog do not open due to JS error. - Global variable issue. 2) Security label control's label font size issue. - Backgrid adds backbone model id(which is 'label' in our case) in as a class in tag causing font size class colli