Re: [pgAdmin4][Patch]: Fix context menu fontawesome icons

2017-09-15 Thread Murtuza Zabuawala 
On Fri, Sep 15, 2017 at 7:16 PM, Dave Page  wrote:

>
>
> On Fri, Sep 15, 2017 at 2:19 PM, Murtuza Zabuawala <
> murtuza.zabuaw...@enterprisedb.com> wrote:
>
>> Hi Dave,
>>
>> On Fri, Sep 15, 2017 at 6:26 PM, Dave Page  wrote:
>>
>>> Hi
>>>
>>> On Fri, Sep 15, 2017 at 8:52 AM, Murtuza Zabuawala <
>>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>>
 Hi Ashesh,

 PFA minor patch to fix the font-awesome icon layout issue, attaching
 screenshot of an issue for your reference.

 Regression of your commit: Link
 

>>>
>>> I'm not sure this is the right way to fix this. We should re-add the
>>> left hand margin on the buttonbar menus and top-level menus. That's
>>> consistent with what the context menu looks like, but more importantly it's
>>> also consistent with (at least) macOS.
>>>
>> ​This is a workaround until we have proper icons for menu.
>>
>
> What do you mean? The icons were removed, and are not coming back.
>
​Oh, I was not aware of that.

>
>
>>
>> If we add the margin again then Menu doesn't look good with so much
>> whitespace.
>>
>
> Maybe, but it's a standard design that we see elsewhere too - and
> consistency is good for usability.
>
​That's true.​


>
>
>> If you like that way then I'm attaching the patch for the same which will
>> add margins again as they were before icons. ​
>>
>>
>
> Thanks, applied.
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Re: v2.0-rc1 not starting, runtime not building

2017-09-15 Thread Surinder Kumar 
Hi Willy,

>From the logs you sent, It seems there is some issue in Qt setup.

Here is the step by step instructions
 I had
documented to setup pgAdmin4 in desktop mode on Ubuntu.
You also need to setup virtual environment as well.

I hope it helps.

Thanks,
Surinder




On Fri, Sep 15, 2017 at 7:34 PM, Willy-Bas Loos  wrote:

> Any idea's about what's going wrong here?
>
> On Thu, Sep 14, 2017 at 12:39 PM, Willy-Bas Loos 
> wrote:
>
>>
>> On Thu, Sep 14, 2017 at 11:07 AM, Neel Patel > > wrote:
>>
>>> I don't know the installed packages on your system but what I can help
>>> only - Download Qt 5.5 installers from "https://download.qt.io/archiv
>>> e/qt/" and install it on custom path ( e.g. /opt/Qt5.5" and use "qmake"
>>> installed in that directory during compilation and let us know result.
>>>
>> OK, different errors now, but still the qt warning
>>
>> (pgadmin4) wbloos@wb:~/python-files/pgadmin4/runtime$
>> /opt/Qt5.5.1/5.5/gcc_64/bin/qmake "DEFINES +=PGADMIN4_USE_WEBKIT"
>> Project MESSAGE: Building for QT5+...
>> Project MESSAGE: Forcing use of QWebKit...
>> Project MESSAGE:
>> Project MESSAGE: ** WARNING
>> **
>> Project MESSAGE: * It is strongly advised that Qt 5.5.0 or later is used
>> to build the pgAdmin runtime.
>> Project MESSAGE: **
>> ***
>> Project MESSAGE:
>> Project MESSAGE: Building for Linux/Mac...
>> Project MESSAGE: Using /home/wbloos/.virtualenvs/pgad
>> min4/bin/python-config
>> Project MESSAGE: Python3 detected.
>> (pgadmin4) wbloos@wb:~/python-files/pgadmin4/runtime$ make > make.log
>> 2>&1
>>
>>
>
>
> --
> Willy-Bas Loos
>

Re: v2.0-rc1 not starting, runtime not building

2017-09-15 Thread Willy-Bas Loos 
Any idea's about what's going wrong here?

On Thu, Sep 14, 2017 at 12:39 PM, Willy-Bas Loos  wrote:

>
> On Thu, Sep 14, 2017 at 11:07 AM, Neel Patel 
> wrote:
>
>> I don't know the installed packages on your system but what I can help
>> only - Download Qt 5.5 installers from "https://download.qt.io/archiv
>> e/qt/" and install it on custom path ( e.g. /opt/Qt5.5" and use "qmake"
>> installed in that directory during compilation and let us know result.
>>
> OK, different errors now, but still the qt warning
>
> (pgadmin4) wbloos@wb:~/python-files/pgadmin4/runtime$
> /opt/Qt5.5.1/5.5/gcc_64/bin/qmake "DEFINES +=PGADMIN4_USE_WEBKIT"
> Project MESSAGE: Building for QT5+...
> Project MESSAGE: Forcing use of QWebKit...
> Project MESSAGE:
> Project MESSAGE: ** WARNING
> **
> Project MESSAGE: * It is strongly advised that Qt 5.5.0 or later is used
> to build the pgAdmin runtime.
> Project MESSAGE: **
> ***
> Project MESSAGE:
> Project MESSAGE: Building for Linux/Mac...
> Project MESSAGE: Using /home/wbloos/.virtualenvs/
> pgadmin4/bin/python-config
> Project MESSAGE: Python3 detected.
> (pgadmin4) wbloos@wb:~/python-files/pgadmin4/runtime$ make > make.log
> 2>&1
>
>


-- 
Willy-Bas Loos

Re: [pgAdmin4][Patch]: Fix context menu fontawesome icons

2017-09-15 Thread Dave Page 
On Fri, Sep 15, 2017 at 2:19 PM, Murtuza Zabuawala  wrote:

> Hi Dave,
>
> On Fri, Sep 15, 2017 at 6:26 PM, Dave Page  wrote:
>
>> Hi
>>
>> On Fri, Sep 15, 2017 at 8:52 AM, Murtuza Zabuawala <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>>> Hi Ashesh,
>>>
>>> PFA minor patch to fix the font-awesome icon layout issue, attaching
>>> screenshot of an issue for your reference.
>>>
>>> Regression of your commit: Link
>>> 
>>>
>>
>> I'm not sure this is the right way to fix this. We should re-add the left
>> hand margin on the buttonbar menus and top-level menus. That's consistent
>> with what the context menu looks like, but more importantly it's also
>> consistent with (at least) macOS.
>>
> ​This is a workaround until we have proper icons for menu.
>

What do you mean? The icons were removed, and are not coming back.


>
> If we add the margin again then Menu doesn't look good with so much
> whitespace.
>

Maybe, but it's a standard design that we see elsewhere too - and
consistency is good for usability.


> If you like that way then I'm attaching the patch for the same which will
> add margins again as they were before icons. ​
>
>

Thanks, applied.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgAdmin 4 commit: Fix menu left-hand margin.

2017-09-15 Thread Dave Page 
Fix menu left-hand margin.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8150f93c06084a34dd94170a23df85ed8b82c735
Author: Murtuza Zabuawala 

Modified Files
--
web/pgadmin/static/css/bootstrap.overrides.css | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)

Re: pgAdmin 4 commit: Bundle fonts with pgAdmin so we have a standard set f

2017-09-15 Thread Murtuza Zabuawala 
Hi Atul,

I think we still missed alertify header fonts :)
Check screenshot.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

[image: https://community.postgresrocks.net/]


On Fri, Sep 15, 2017 at 6:38 PM, Dave Page  wrote:

> Thanks, applied.
>
> On Fri, Sep 15, 2017 at 8:59 AM, Atul Sharma  > wrote:
>
>> Hi,
>>
>> PFA patch which replaces the "Roboto" font family with "Open Sans" for
>> alertify dialogs. Regarding Query tool context menu, It seems different
>> issue than the applied fonts.
>>
>> Regards,
>> Atul
>>
>> On Thu, Sep 14, 2017 at 7:49 PM, Murtuza Zabuawala <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>>> Attaching more screenshots.
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>> [image: https://community.postgresrocks.net/]
>>> 
>>>
>>> On Thu, Sep 14, 2017 at 7:08 PM, Murtuza Zabuawala <
>>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>>
 Hi Atul,

 Please also check fonts in various the alertify dialogs.

 --
 Regards,
 Murtuza Zabuawala
 EnterpriseDB: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company

 [image: https://community.postgresrocks.net/]
 

 On Thu, Sep 14, 2017 at 7:03 PM, Dave Page  wrote:

> Nope - it shouldn't look like that. Atul, Can you take a look at it
> please?
>
> On Thu, Sep 14, 2017 at 2:26 PM, Murtuza Zabuawala <
> murtuza.zabuaw...@enterprisedb.com> wrote:
>
>> Hi Dave,
>>
>> After latest pull fonts from context menu looks different, PFA
>> screenshot.
>> I tried on macOS: 10.10 (Web mode) on Google Chrome: Version
>> 60.0.3112.113 (Official Build) (64-bit)
>>
>> Is this expected behaviour?
>>
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> [image: https://community.postgresrocks.net/]
>> 
>>
>> On Wed, Sep 13, 2017 at 8:31 PM, Dave Page  wrote:
>>
>>> Bundle fonts with pgAdmin so we have a standard set for all
>>> platforms.
>>>
>>> Research by Shirley at Pivotal.
>>>
>>> Branch
>>> --
>>> master
>>>
>>> Details
>>> ---
>>> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdif
>>> f;h=788f7f3a69500c37008dbba459d3ea00b0b1bff8
>>> Author: Atul Sharma 
>>>
>>> Modified Files
>>> --
>>> libraries.txt  |   4 ++-
>>> web/pgadmin/browser/static/css/browser.css |  33
>>> ++---
>>> .../misc/bgprocess/static/css/bgprocess.css|   2 +-
>>> .../misc/file_manager/static/css/file_manager.css  |   2 +-
>>> web/pgadmin/static/css/aci_tree.overrides.css  |   4 +--
>>> web/pgadmin/static/css/bootstrap.overrides.css |   5 ++--
>>> web/pgadmin/static/css/codemirror.overrides.css|   4 +--
>>> web/pgadmin/static/css/pgadmin.css |  17 ++-
>>> web/pgadmin/static/css/pgadmin.style.css   |  10 +++
>>> web/pgadmin/static/css/webcabin.overrides.css  |   6 ++--
>>> web/pgadmin/static/fonts/OpenSans-Bold.ttf | Bin 0 ->
>>> 224452 bytes
>>> web/pgadmin/static/fonts/OpenSans-Italic.ttf   | Bin 0 ->
>>> 212760 bytes
>>> web/pgadmin/static/fonts/OpenSans-Regular.ttf  | Bin 0 ->
>>> 217276 bytes
>>> web/pgadmin/static/fonts/OpenSans-SemiBold.ttf | Bin 0 ->
>>> 221164 bytes
>>> web/pgadmin/static/fonts/SourceCodePro-Bold.ttf| Bin 0 ->
>>> 120504 bytes
>>> web/pgadmin/static/fonts/SourceCodePro-Regular.ttf | Bin 0 ->
>>> 120548 bytes
>>> web/pgadmin/static/scss/_alert.scss|   2 +-
>>> web/pgadmin/static/scss/_alertify.overrides.scss   |   2 +-
>>> web/pgadmin/static/scss/_typography.scss   |   2 +-
>>> web/pgadmin/static/scss/sqleditor/_history.scss|   8 ++---
>>> web/pgadmin/tools/debugger/static/css/debugger.css |   6 ++--
>>> .../tools/sqleditor/static/css/sqleditor.css   |   8 ++---
>>> 22 files changed, 73 insertions(+), 42 deletions(-)
>>>
>>>
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>


>>>
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Re: [pgAdmin4][Patch]: Fix context menu fontawesome icons

2017-09-15 Thread Murtuza Zabuawala 
Hi Dave,

On Fri, Sep 15, 2017 at 6:26 PM, Dave Page  wrote:

> Hi
>
> On Fri, Sep 15, 2017 at 8:52 AM, Murtuza Zabuawala  enterprisedb.com> wrote:
>
>> Hi Ashesh,
>>
>> PFA minor patch to fix the font-awesome icon layout issue, attaching
>> screenshot of an issue for your reference.
>>
>> Regression of your commit: Link
>> 
>>
>
> I'm not sure this is the right way to fix this. We should re-add the left
> hand margin on the buttonbar menus and top-level menus. That's consistent
> with what the context menu looks like, but more importantly it's also
> consistent with (at least) macOS.
>
​This is a workaround until we have proper icons for menu.

If we add the margin again then Menu doesn't look good with so much
whitespace.
If you like that way then I'm attaching the patch for the same which will
add margins again as they were before icons. ​


>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
diff --git a/web/pgadmin/static/css/bootstrap.overrides.css 
b/web/pgadmin/static/css/bootstrap.overrides.css
index 94fb449..82c2f4e 100755
--- a/web/pgadmin/static/css/bootstrap.overrides.css
+++ b/web/pgadmin/static/css/bootstrap.overrides.css
@@ -105,7 +105,7 @@ iframe {
 border-width: 5px 0 5px 5px;
 border-left-color: #cc;
 margin-top: 5px;
-margin-right: -2px;
+margin-right: -10px;
 }
 
 .dropdown-submenu:hover>a:after {
@@ -153,10 +153,6 @@ iframe {
 margin-bottom: 0;
 }
 
-.dropdown-menu > li > a {
-  padding: 3px 5px;
-}
-
 .dropdown-menu > li > a > i {
 margin-left: -17px;
 width: 13px;

pgAdmin 4 commit: Replace the "Roboto" font family with "Open Sans" for

2017-09-15 Thread Dave Page 
Replace the "Roboto" font family with "Open Sans" for alertify dialogs.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c3ea3b7bdfa684c84fb1a4e28fbfbb409b807470
Author: Atul Sharma 

Modified Files
--
web/pgadmin/static/css/pgadmin.style.css | 4 
1 file changed, 4 insertions(+)

Re: pgAdmin 4 commit: Bundle fonts with pgAdmin so we have a standard set f

2017-09-15 Thread Dave Page 
Thanks, applied.

On Fri, Sep 15, 2017 at 8:59 AM, Atul Sharma 
wrote:

> Hi,
>
> PFA patch which replaces the "Roboto" font family with "Open Sans" for
> alertify dialogs. Regarding Query tool context menu, It seems different
> issue than the applied fonts.
>
> Regards,
> Atul
>
> On Thu, Sep 14, 2017 at 7:49 PM, Murtuza Zabuawala  enterprisedb.com> wrote:
>
>> Attaching more screenshots.
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> [image: https://community.postgresrocks.net/]
>> 
>>
>> On Thu, Sep 14, 2017 at 7:08 PM, Murtuza Zabuawala <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>>> Hi Atul,
>>>
>>> Please also check fonts in various the alertify dialogs.
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>> [image: https://community.postgresrocks.net/]
>>> 
>>>
>>> On Thu, Sep 14, 2017 at 7:03 PM, Dave Page  wrote:
>>>
 Nope - it shouldn't look like that. Atul, Can you take a look at it
 please?

 On Thu, Sep 14, 2017 at 2:26 PM, Murtuza Zabuawala <
 murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi Dave,
>
> After latest pull fonts from context menu looks different, PFA
> screenshot.
> I tried on macOS: 10.10 (Web mode) on Google Chrome: Version
> 60.0.3112.113 (Official Build) (64-bit)
>
> Is this expected behaviour?
>
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> [image: https://community.postgresrocks.net/]
> 
>
> On Wed, Sep 13, 2017 at 8:31 PM, Dave Page  wrote:
>
>> Bundle fonts with pgAdmin so we have a standard set for all platforms.
>>
>> Research by Shirley at Pivotal.
>>
>> Branch
>> --
>> master
>>
>> Details
>> ---
>> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdif
>> f;h=788f7f3a69500c37008dbba459d3ea00b0b1bff8
>> Author: Atul Sharma 
>>
>> Modified Files
>> --
>> libraries.txt  |   4 ++-
>> web/pgadmin/browser/static/css/browser.css |  33
>> ++---
>> .../misc/bgprocess/static/css/bgprocess.css|   2 +-
>> .../misc/file_manager/static/css/file_manager.css  |   2 +-
>> web/pgadmin/static/css/aci_tree.overrides.css  |   4 +--
>> web/pgadmin/static/css/bootstrap.overrides.css |   5 ++--
>> web/pgadmin/static/css/codemirror.overrides.css|   4 +--
>> web/pgadmin/static/css/pgadmin.css |  17 ++-
>> web/pgadmin/static/css/pgadmin.style.css   |  10 +++
>> web/pgadmin/static/css/webcabin.overrides.css  |   6 ++--
>> web/pgadmin/static/fonts/OpenSans-Bold.ttf | Bin 0 -> 224452
>> bytes
>> web/pgadmin/static/fonts/OpenSans-Italic.ttf   | Bin 0 -> 212760
>> bytes
>> web/pgadmin/static/fonts/OpenSans-Regular.ttf  | Bin 0 -> 217276
>> bytes
>> web/pgadmin/static/fonts/OpenSans-SemiBold.ttf | Bin 0 -> 221164
>> bytes
>> web/pgadmin/static/fonts/SourceCodePro-Bold.ttf| Bin 0 -> 120504
>> bytes
>> web/pgadmin/static/fonts/SourceCodePro-Regular.ttf | Bin 0 -> 120548
>> bytes
>> web/pgadmin/static/scss/_alert.scss|   2 +-
>> web/pgadmin/static/scss/_alertify.overrides.scss   |   2 +-
>> web/pgadmin/static/scss/_typography.scss   |   2 +-
>> web/pgadmin/static/scss/sqleditor/_history.scss|   8 ++---
>> web/pgadmin/tools/debugger/static/css/debugger.css |   6 ++--
>> .../tools/sqleditor/static/css/sqleditor.css   |   8 ++---
>> 22 files changed, 73 insertions(+), 42 deletions(-)
>>
>>
>


 --
 Dave Page
 Blog: http://pgsnake.blogspot.com
 Twitter: @pgsnake

 EnterpriseDB UK: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company

>>>
>>>
>>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgAdmin4][Patch]: pgAdmin4 not displaying schema if it start with 'pg'

2017-09-15 Thread Dave Page 
Thanks, patch applied.

On Thu, Sep 14, 2017 at 3:15 PM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi,
>
> PFA patch to fix the issue where pgAdmin4 is not displaying the schema if
> it starts with 'pg', for example if schema name is 'pgabc' then it won't
> display it under browser tree.
> RM#2709
>
> Please review.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> [image: https://community.postgresrocks.net/]
> 
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgAdmin 4 commit: Fix filtering of system schemas so pg_* is hidden but

2017-09-15 Thread Dave Page 
Fix filtering of system schemas so pg_* is hidden but pg* is not. Fixes #2709

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9cfb2f3cbed3e1710ad19df4ab4ab320817fc6f9
Author: Murtuza Zabuawala 

Modified Files
--
.../templates/foreign_tables/sql/macros/db_catalogs.macro | 2 +-
.../tables/templates/partition/sql/10_plus/get_attach_tables.sql  | 4 ++--
.../schemas/tables/templates/partition/sql/10_plus/properties.sql | 2 +-
.../schemas/tables/templates/table/sql/10_plus/get_inherits.sql   | 4 ++--
.../schemas/tables/templates/table/sql/10_plus/properties.sql | 2 +-
.../schemas/tables/templates/table/sql/9.1_plus/properties.sql| 2 +-
.../schemas/tables/templates/table/sql/default/get_inherits.sql   | 4 ++--
.../tables/templates/table/sql/default/get_tables_for_constraints.sql | 4 ++--
.../schemas/tables/templates/table/sql/default/properties.sql | 4 ++--
.../schemas/tables/templates/table/sql/gpdb_5.0_plus/properties.sql   | 2 +-
.../schemas/tables/templates/table/sql/macros/db_catalogs.macro   | 4 ++--
.../tables/templates/trigger/sql/default/get_triggerfunctions.sql | 2 +-
.../databases/schemas/templates/schema/gpdb_5.0_plus/sql/nodes.sql| 2 +-
.../databases/schemas/templates/schema/pg/9.2_plus/sql/nodes.sql  | 2 +-
.../databases/schemas/templates/schema/pg/default/sql/nodes.sql   | 2 +-
.../databases/schemas/templates/schema/ppas/9.1_plus/sql/nodes.sql| 2 +-
.../databases/schemas/templates/schema/ppas/9.2_plus/sql/nodes.sql| 2 +-
.../templates/grant_wizard/pg/9.1_plus/sql/get_schemas.sql| 2 +-
.../templates/grant_wizard/ppas/9.1_plus/sql/get_schemas.sql  | 2 +-
19 files changed, 25 insertions(+), 25 deletions(-)

Re: Array representation and save array data from datagrid [RM2671][pgAdmin4]

2017-09-15 Thread Harshal Dhumal 
Hi Akshay,

It's not issue; Try without quotes. As char data type stores only one
character so it's storing only leading quote (') and
truncating remaining characters (a').
Only exception is when you want to store empty string (char) use two quotes
(either single or double)
they will translated before sending to server.

Apart from this I found that data types "char" and "char"[] (alias to
character and character[] respectively)
were not taken into consideration in sqleditor.js. I have attached updated
patch which fixes this issue.





-- 
*Harshal Dhumal*
*Sr. Software Engineer*

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Thu, Sep 14, 2017 at 5:31 PM, Akshay Joshi  wrote:

> Hi Harshal
>
> I have reviewed your patch it looks good to me. Only one issue I have
> found with char[], when I store {'a','b','c'} it gets stored and when I
> refreshed it shows {',','}. Please look into this issue.
>
> On Thu, Sep 14, 2017 at 3:54 PM, Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> It works, sorry for the noise.
>>
>> On Thu, Sep 14, 2017 at 3:48 PM, Akshay Joshi <
>> akshay.jo...@enterprisedb.com> wrote:
>>
>>> Harshal,
>>>
>>> Can you please rebase the patch, it's not applied with the latest code.
>>>
>>> On Tue, Sep 12, 2017 at 2:37 PM, Akshay Joshi <
>>> akshay.jo...@enterprisedb.com> wrote:
>>>


 On Tue, Sep 12, 2017 at 2:34 PM, Dave Page  wrote:

> Adding Akshay...
>

 Sure.

>
> On Tue, Sep 12, 2017 at 10:04 AM, Dave Page  wrote:
>
>> Akshay, can you review/commit this please?
>>
>> On Mon, Sep 11, 2017 at 3:40 PM, Harshal Dhumal <
>> harshal.dhu...@enterprisedb.com> wrote:
>>
>>> Hi,
>>>
>>> Please find attached patch to represent array data in datagrid with
>>> curly braces and
>>> also allow user to save array with values like  , >> string>, '*""*' and "*''*"
>>>
>>> --
>>> *Harshal Dhumal*
>>> *Sr. Software Engineer*
>>>
>>> EnterpriseDB India: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>



 --
 *Akshay Joshi*
 *Principal Software Engineer *



 *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

>>>
>>>
>>>
>>> --
>>> *Akshay Joshi*
>>> *Principal Software Engineer *
>>>
>>>
>>>
>>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>>>
>>
>>
>>
>> --
>> *Akshay Joshi*
>> *Principal Software Engineer *
>>
>>
>>
>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>>
>
>
>
> --
> *Akshay Joshi*
> *Principal Software Engineer *
>
>
>
> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>
diff --git a/web/pgadmin/feature_tests/test_data.json b/web/pgadmin/feature_tests/test_data.json
index a2457c2..ac00b0b 100644
--- a/web/pgadmin/feature_tests/test_data.json
+++ b/web/pgadmin/feature_tests/test_data.json
@@ -7,12 +7,19 @@
   "4": ["", "Hello World", "text"],
   "5": ["\"\"", "", "text", "Two double quotes"],
   "6": ["\\\"\\\"", "\"\"", "text", "double backslash followed by a double quote"],
-  "7": ["\"\"", "\\\"\\\"", "text", "double backslash followed by a double quote"],
+  "7": ["\"\"", "\"\"", "text", "double backslash followed by a double quote"],
   "8": ["", "[null]", "text"],
   "9": ["", "[51,52]", "json"],
   "10": ["[61,62]", "[61,62]", "json"],
   "11": ["", "true", "bool"],
-  "12": ["", "[null]", "bool"]
+  "12": ["", "[null]", "bool"],
+  "13": ["", "[null]", "text[]"],
+  "14": ["{}", "{}", "text[]"],
+  "15": ["{data,,'',\"\",\\'\\',\\\"\\\"}", "{data,[null],,,'',\"\"}", "text[]"],
+  "16": ["{}", "{}", "int[]"],
+  "17": ["{123,,456}", "{123,[null],456}", "int[]"],
+  "18": ["", "[null]", "boolean[]"],
+  "19": ["{false,,true}", "{false,[null],true}", "boolean[]"]
 }
   }
-}
\ No newline at end of file
+}
diff --git a/web/pgadmin/feature_tests/view_data_dml_queries.py b/web/pgadmin/feature_tests/view_data_dml_queries.py
index 0b2da0c..153d796 100644
--- a/web/pgadmin/feature_tests/view_data_dml_queries.py
+++ b/web/pgadmin/feature_tests/view_data_dml_queries.py
@@ -67,6 +67,13 @@ CREATE TABLE public.defaults
 json_null json,
 boolean_defaults boolean DEFAULT true,
 boolean_null boolean,
+text_arr text[],
+text_arr_empty text[],
+text_arr_null text[],
+int_arr integer[],
+int_arr_empty integer[],
+boolean_arr

Re: pgAdmin 4 commit: Bundle fonts with pgAdmin so we have a standard set f

2017-09-15 Thread Atul Sharma 
Hi,

PFA patch which replaces the "Roboto" font family with "Open Sans" for
alertify dialogs. Regarding Query tool context menu, It seems different
issue than the applied fonts.

Regards,
Atul

On Thu, Sep 14, 2017 at 7:49 PM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Attaching more screenshots.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> [image: https://community.postgresrocks.net/]
> 
>
> On Thu, Sep 14, 2017 at 7:08 PM, Murtuza Zabuawala  enterprisedb.com> wrote:
>
>> Hi Atul,
>>
>> Please also check fonts in various the alertify dialogs.
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> [image: https://community.postgresrocks.net/]
>> 
>>
>> On Thu, Sep 14, 2017 at 7:03 PM, Dave Page  wrote:
>>
>>> Nope - it shouldn't look like that. Atul, Can you take a look at it
>>> please?
>>>
>>> On Thu, Sep 14, 2017 at 2:26 PM, Murtuza Zabuawala <
>>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>>
 Hi Dave,

 After latest pull fonts from context menu looks different, PFA
 screenshot.
 I tried on macOS: 10.10 (Web mode) on Google Chrome: Version
 60.0.3112.113 (Official Build) (64-bit)

 Is this expected behaviour?


 --
 Regards,
 Murtuza Zabuawala
 EnterpriseDB: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company

 [image: https://community.postgresrocks.net/]
 

 On Wed, Sep 13, 2017 at 8:31 PM, Dave Page  wrote:

> Bundle fonts with pgAdmin so we have a standard set for all platforms.
>
> Research by Shirley at Pivotal.
>
> Branch
> --
> master
>
> Details
> ---
> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdif
> f;h=788f7f3a69500c37008dbba459d3ea00b0b1bff8
> Author: Atul Sharma 
>
> Modified Files
> --
> libraries.txt  |   4 ++-
> web/pgadmin/browser/static/css/browser.css |  33
> ++---
> .../misc/bgprocess/static/css/bgprocess.css|   2 +-
> .../misc/file_manager/static/css/file_manager.css  |   2 +-
> web/pgadmin/static/css/aci_tree.overrides.css  |   4 +--
> web/pgadmin/static/css/bootstrap.overrides.css |   5 ++--
> web/pgadmin/static/css/codemirror.overrides.css|   4 +--
> web/pgadmin/static/css/pgadmin.css |  17 ++-
> web/pgadmin/static/css/pgadmin.style.css   |  10 +++
> web/pgadmin/static/css/webcabin.overrides.css  |   6 ++--
> web/pgadmin/static/fonts/OpenSans-Bold.ttf | Bin 0 -> 224452
> bytes
> web/pgadmin/static/fonts/OpenSans-Italic.ttf   | Bin 0 -> 212760
> bytes
> web/pgadmin/static/fonts/OpenSans-Regular.ttf  | Bin 0 -> 217276
> bytes
> web/pgadmin/static/fonts/OpenSans-SemiBold.ttf | Bin 0 -> 221164
> bytes
> web/pgadmin/static/fonts/SourceCodePro-Bold.ttf| Bin 0 -> 120504
> bytes
> web/pgadmin/static/fonts/SourceCodePro-Regular.ttf | Bin 0 -> 120548
> bytes
> web/pgadmin/static/scss/_alert.scss|   2 +-
> web/pgadmin/static/scss/_alertify.overrides.scss   |   2 +-
> web/pgadmin/static/scss/_typography.scss   |   2 +-
> web/pgadmin/static/scss/sqleditor/_history.scss|   8 ++---
> web/pgadmin/tools/debugger/static/css/debugger.css |   6 ++--
> .../tools/sqleditor/static/css/sqleditor.css   |   8 ++---
> 22 files changed, 73 insertions(+), 42 deletions(-)
>
>

>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>


fonts_v1.patch
Description: Binary data

[pgAdmin4][Patch]: Fix context menu fontawesome icons

2017-09-15 Thread Murtuza Zabuawala 
Hi Ashesh,

PFA minor patch to fix the font-awesome icon layout issue, attaching
screenshot of an issue for your reference.

Regression of your commit: Link


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

[image: https://community.postgresrocks.net/]

diff --git a/web/pgadmin/static/css/bootstrap.overrides.css 
b/web/pgadmin/static/css/bootstrap.overrides.css
index 94fb449..742cd9f 100755
--- a/web/pgadmin/static/css/bootstrap.overrides.css
+++ b/web/pgadmin/static/css/bootstrap.overrides.css
@@ -157,7 +157,7 @@ iframe {
   padding: 3px 5px;
 }
 
-.dropdown-menu > li > a > i {
+.dropdown-menu > li > a > i.visibility-hidden {
 margin-left: -17px;
 width: 13px;
 }