Jenkins build is back to normal : pgadmin4-master-python36 #335

2017-09-20 Thread pgAdmin 4 Jenkins 
See

Jenkins build is back to normal : pgadmin4-master-python34 #326

2017-09-20 Thread pgAdmin 4 Jenkins 
See

Jenkins build is back to normal : pgadmin4-master-python33 #335

2017-09-20 Thread pgAdmin 4 Jenkins 
See

pgAdmin 4 commit: Use the correct lexer in the Apache/Windows docs.

2017-09-20 Thread Dave Page 
Use the correct lexer in the Apache/Windows docs.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=18dc938556e9f3f65b35c62d02c1b96019b5ed46

Modified Files
--
docs/en_US/server_deployment.rst | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)

Build failed in Jenkins: pgadmin4-master-python33 #334

2017-09-20 Thread pgAdmin 4 Jenkins 
See 


Changes:

[Dave Page] Clarify how virtual envs can be used in WSGI mode, and ensure we 
ship

--
[...truncated 379.42 KB...]
PhantomJS 2.1.1 (Linux 0.0.0): Executed 279 of 302 SUCCESS (0 secs / 
4.737 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 280 of 302 SUCCESS (0 secs / 
4.741 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 281 of 302 SUCCESS (0 secs / 
4.746 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 282 of 302 SUCCESS (0 secs / 
4.75 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 283 of 302 SUCCESS (0 secs / 
4.755 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 284 of 302 SUCCESS (0 secs / 
4.759 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 285 of 302 SUCCESS (0 secs / 
4.763 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 286 of 302 SUCCESS (0 secs / 
4.767 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 287 of 302 SUCCESS (0 secs / 
4.771 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 288 of 302 SUCCESS (0 secs / 
4.775 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 289 of 302 SUCCESS (0 secs / 
4.78 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 290 of 302 SUCCESS (0 secs / 
4.784 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 291 of 302 SUCCESS (0 secs / 
4.798 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 292 of 302 SUCCESS (0 secs / 
4.808 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 293 of 302 SUCCESS (0 secs / 
4.812 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 294 of 302 SUCCESS (0 secs / 
4.816 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 295 of 302 SUCCESS (0 secs / 
4.82 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 296 of 302 SUCCESS (0 secs / 
4.824 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 297 of 302 SUCCESS (0 secs / 
4.829 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 298 of 302 SUCCESS (0 secs / 
4.833 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 299 of 302 SUCCESS (0 secs / 
4.838 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 300 of 302 SUCCESS (0 secs / 
4.846 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 301 of 302 SUCCESS (0 secs / 
4.85 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 302 of 302 SUCCESS (0 secs / 
4.854 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 302 of 302 SUCCESS (4.933 secs 
/ 4.854 secs)
EXECUTING: Build docs

Collecting Sphinx==1.4.9
  Using cached Sphinx-1.4.9-py2.py3-none-any.whl
Requirement already satisfied: Jinja2>=2.3 in 
./pgadmin-venv/lib/python3.3/site-packages (from Sphinx==1.4.9)
Collecting alabaster<0.8,>=0.7 (from Sphinx==1.4.9)
  Using cached alabaster-0.7.10-py2.py3-none-any.whl
Collecting imagesize (from Sphinx==1.4.9)
  Using cached imagesize-0.7.1-py2.py3-none-any.whl
Requirement already satisfied: six>=1.5 in 
./pgadmin-venv/lib/python3.3/site-packages (from Sphinx==1.4.9)
Collecting Pygments>=2.0 (from Sphinx==1.4.9)
  Using cached Pygments-2.2.0-py2.py3-none-any.whl
Collecting snowballstemmer>=1.1 (from Sphinx==1.4.9)
  Using cached snowballstemmer-1.2.1-py2.py3-none-any.whl
Requirement already satisfied: babel!=2.0,>=1.3 in 
./pgadmin-venv/lib/python3.3/site-packages (from Sphinx==1.4.9)
Collecting docutils>=0.11 (from Sphinx==1.4.9)
  Using cached docutils-0.14-py3-none-any.whl
Requirement already satisfied: markupsafe in 
./pgadmin-venv/lib/python3.3/site-packages (from Jinja2>=2.3->Sphinx==1.4.9)
Requirement already satisfied: pytz>=0a in 
./pgadmin-venv/lib/python3.3/site-packages (from 
babel!=2.0,>=1.3->Sphinx==1.4.9)
Installing collected packages: alabaster, imagesize, Pygments, snowballstemmer, 
docutils, Sphinx
Successfully installed Pygments-2.2.0 Sphinx-1.4.9 alabaster-0.7.10 
docutils-0.14 imagesize-0.7.1 snowballstemmer-1.2.1
LC_ALL=en_US.UTF-8 LANG=en_US.UTF-8 make -C docs/en_US -f Makefile.sphinx html
make[1]: Entering directory 
`
Generating code-snippet.rst for some of the important classes...
sphinx-build -W -b html -d _build/doctrees   . _build/html
Running Sphinx v1.4.9
making output directory...
loading pickled environment... not yet created
building [mo]: targets for 0 po files that are out of date
building [html]: targets for 96 source files that are out of date
updating environment: 96 added, 0 changed, 0 removed
reading sources... [  1%] add_restore_point_dialog
reading sources... [  2%] backup_and_restore
reading sources... [  3%] backup_dialog
reading sources... [  4%] backup_globals_dialog
reading sources... [  5%] backup_server_dialog
reading sources... [  6%] browser
reading sources... [  7%] cast_dialog
reading sources... [  8%] change_password_dialog
reading sources... [  9%] check_dialog
reading sources... [ 10%] code_overview
reading sources... [ 11%] code_review
reading sources... [ 12%]

Build failed in Jenkins: pgadmin4-master-python34 #325

2017-09-20 Thread pgAdmin 4 Jenkins 
See 


Changes:

[Dave Page] Clarify how virtual envs can be used in WSGI mode, and ensure we 
ship

--
[...truncated 381.56 KB...]
Collecting requests>=2.0.0 (from Sphinx)
  Using cached requests-2.18.4-py2.py3-none-any.whl
Requirement already satisfied: setuptools in 
./pgadmin-venv/lib/python3.4/site-packages (from Sphinx)
Requirement already satisfied: babel!=2.0,>=1.3 in 
./pgadmin-venv/lib/python3.4/site-packages (from Sphinx)
Collecting sphinxcontrib-websupport (from Sphinx)
  Using cached sphinxcontrib_websupport-1.0.1-py2.py3-none-any.whl
Collecting typing; python_version < "3.5" (from Sphinx)
  Using cached typing-3.6.2-py3-none-any.whl
Collecting imagesize (from Sphinx)
  Using cached imagesize-0.7.1-py2.py3-none-any.whl
Collecting alabaster<0.8,>=0.7 (from Sphinx)
  Using cached alabaster-0.7.10-py2.py3-none-any.whl
Collecting snowballstemmer>=1.1 (from Sphinx)
  Using cached snowballstemmer-1.2.1-py2.py3-none-any.whl
Collecting Pygments>=2.0 (from Sphinx)
  Using cached Pygments-2.2.0-py2.py3-none-any.whl
Requirement already satisfied: Jinja2>=2.3 in 
./pgadmin-venv/lib/python3.4/site-packages (from Sphinx)
Requirement already satisfied: six>=1.5 in 
./pgadmin-venv/lib/python3.4/site-packages (from Sphinx)
Collecting docutils>=0.11 (from Sphinx)
  Using cached docutils-0.14-py3-none-any.whl
Collecting chardet<3.1.0,>=3.0.2 (from requests>=2.0.0->Sphinx)
  Using cached chardet-3.0.4-py2.py3-none-any.whl
Collecting idna<2.7,>=2.5 (from requests>=2.0.0->Sphinx)
  Using cached idna-2.6-py2.py3-none-any.whl
Collecting urllib3<1.23,>=1.21.1 (from requests>=2.0.0->Sphinx)
  Using cached urllib3-1.22-py2.py3-none-any.whl
Collecting certifi>=2017.4.17 (from requests>=2.0.0->Sphinx)
  Using cached certifi-2017.7.27.1-py2.py3-none-any.whl
Requirement already satisfied: pytz>=0a in 
./pgadmin-venv/lib/python3.4/site-packages (from babel!=2.0,>=1.3->Sphinx)
Requirement already satisfied: markupsafe in 
./pgadmin-venv/lib/python3.4/site-packages (from Jinja2>=2.3->Sphinx)
Installing collected packages: chardet, idna, urllib3, certifi, requests, 
sphinxcontrib-websupport, typing, imagesize, alabaster, snowballstemmer, 
Pygments, docutils, Sphinx
Successfully installed Pygments-2.2.0 Sphinx-1.6.3 alabaster-0.7.10 
certifi-2017.7.27.1 chardet-3.0.4 docutils-0.14 idna-2.6 imagesize-0.7.1 
requests-2.18.4 snowballstemmer-1.2.1 sphinxcontrib-websupport-1.0.1 
typing-3.6.2 urllib3-1.22
LC_ALL=en_US.UTF-8 LANG=en_US.UTF-8 make -C docs/en_US -f Makefile.sphinx html
make[1]: Entering directory 
`
Generating code-snippet.rst for some of the important classes...
sphinx-build -W -b html -d _build/doctrees   . _build/html
Running Sphinx v1.6.3
making output directory...
loading pickled environment... not yet created
building [mo]: targets for 0 po files that are out of date
building [html]: targets for 96 source files that are out of date
updating environment: 96 added, 0 changed, 0 removed
reading sources... [  1%] add_restore_point_dialog
reading sources... [  2%] backup_and_restore
reading sources... [  3%] backup_dialog
reading sources... [  4%] backup_globals_dialog
reading sources... [  5%] backup_server_dialog
reading sources... [  6%] browser
reading sources... [  7%] cast_dialog
reading sources... [  8%] change_password_dialog
reading sources... [  9%] check_dialog
reading sources... [ 10%] code_overview
reading sources... [ 11%] code_review
reading sources... [ 12%] code_snippets
reading sources... [ 13%] coding_standards
reading sources... [ 14%] collation_dialog
reading sources... [ 15%] column_dialog
reading sources... [ 16%] connect_error
reading sources... [ 17%] connect_to_server
reading sources... [ 18%] connecting
reading sources... [ 19%] contributions
reading sources... [ 20%] database_dialog
reading sources... [ 21%] debugger
reading sources... [ 22%] deployment
reading sources... [ 23%] desktop_deployment
reading sources... [ 25%] developer_tools
reading sources... [ 26%] domain_constraint_dialog
reading sources... [ 27%] domain_dialog
reading sources... [ 28%] event_trigger_dialog
reading sources... [ 29%] exclusion_constraint_dialog
reading sources... [ 30%] extension_dialog
reading sources... [ 31%] foreign_data_wrapper_dialog
reading sources... [ 32%] foreign_key_dialog
reading sources... [ 33%] foreign_server_dialog
reading sources... [ 34%] foreign_table_dialog
reading sources... [ 35%] fts_configuration_dialog
reading sources... [ 36%] fts_dictionary_dialog
reading sources... [ 37%] fts_parser_dialog
reading sources... [ 38%] fts_template_dialog
reading sources... [ 39%] function_dialog
reading sources... [ 40%] getting_started
reading sources... [ 41%] grant_wizard
reading sources... [ 42%] import_export_data
reading sources... [ 43%] index
reading sources... [ 44%] index_dialog
reading

pgAdmin 4 commit: Clarify how virtual envs can be used in WSGI mode, an

2017-09-20 Thread Dave Page 
Clarify how virtual envs can be used in WSGI mode, and ensure we ship the 
required bits on Windows.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=263e235862d5db6dd10c4f064625b2f7369f6eb2
Author: Surinder Kumar 

Modified Files
--
Make-MinGW.bat   |  1 -
Make.bat |  1 -
docs/en_US/server_deployment.rst | 13 -
3 files changed, 12 insertions(+), 3 deletions(-)

Re: [pgAdmin4][Patch]: To exclude SELECT queries from transaction in query tool

2017-09-20 Thread Dave Page 
Thanks, applied.

On Wed, Sep 20, 2017 at 9:34 AM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi,
>
> PFA minor patch to fix the issue where we were executing SELECT statements
> in transactions in query tool which probably is not required because SELECT
> statements are already protected from dirty reads.
> RM#2683
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Build failed in Jenkins: pgadmin4-master-python35 #332

2017-09-20 Thread pgAdmin 4 Jenkins 
See 


Changes:

[Dave Page] Fix validation message styling on thegrant wizard. Fixes #2673

[Dave Page] Fix font on alertify dialogues

[Dave Page] Fix an issue where we were executing SELECT statements in 
transactions

--
[...truncated 341.66 KB...]

172 tests passed
0 tests failed
3 tests skipped:
TableAddTestCase (Create List partitioned table with 2 
partitions,
Create Range partitioned table with 2 
partitions)
TableUpdateTestCase (Create partitions of existing range 
partitioned table,
Detach partition from existing range 
partitioned table,
Attach partition to existing list 
partitioned table,
Attach partition to existing range 
partitioned table,
Detach partition from existing list 
partitioned table,
Create partitions of existing list 
partitioned table)
TestSSLConnection (Test for SSL connection)

PostgreSQL 9.5:

160 tests passed
0 tests failed
15 tests skipped:
ResourceGroupsPutTestCase (Put resource groups)
TableAddTestCase (Create List partitioned table with 2 
partitions,
Create Range partitioned table with 2 
partitions)
SynonymAddTestCase (Default Node URL)
PackageAddTestCase (Fetch Package Node URL)
SynonymGetTestCase (Fetch synonym Node URL)
TestSSLConnection (Test for SSL connection)
ResourceGroupsGetTestCase (Get resource groups)
PackageDeleteTestCase (Fetch Package Node URL)
PackageGetTestCase (Fetch Package Node URL)
TableUpdateTestCase (Create partitions of existing range 
partitioned table,
Detach partition from existing range 
partitioned table,
Attach partition to existing list 
partitioned table,
Attach partition to existing range 
partitioned table,
Detach partition from existing list 
partitioned table,
Create partitions of existing list 
partitioned table)
PackagePutTestCase (Fetch Package Node URL)
ResourceGroupsAddTestCase (Add resource groups)
ResourceGroupsDeleteTestCase (Delete resource groups)
SynonymDeleteTestCase (Fetch synonym Node URL)
SynonymPutTestCase (Fetch synonym Node URL)

EDB Postgres AS 9.3:

168 tests passed
0 tests failed
7 tests skipped:
ResourceGroupsPutTestCase (Put resource groups)
ResourceGroupsGetTestCase (Get resource groups)
TableUpdateTestCase (Create partitions of existing range 
partitioned table,
Detach partition from existing range 
partitioned table,
Attach partition to existing list 
partitioned table,
Attach partition to existing range 
partitioned table,
Detach partition from existing list 
partitioned table,
Create partitions of existing list 
partitioned table)
TableAddTestCase (Create List partitioned table with 2 
partitions,
Create Range partitioned table with 2 
partitions)
ResourceGroupsAddTestCase (Add resource groups)
ResourceGroupsDeleteTestCase (Delete resource groups)
TestSSLConnection (Test for SSL connection)

PostgreSQL 9.3:

160 tests passed
0 tests failed
15 tests skipped:
ResourceGroupsPutTestCase (Put resource groups)
TableAddTestCase (Create List partitioned table with 2 
partitions,
Create Range partitioned table with 2 
partitions)
SynonymAddTestCase (Default Node URL)
PackageAddTestCase (Fetch Package Node URL)
SynonymGetTestCase (Fetch synonym Node URL)
TestSSLConnection (Test for SSL connection)
ResourceGroupsGetTestCase (Get resource groups)
PackageDeleteTestCase (Fetch Package Node URL)
PackageGetTestCase (Fetch Package Node URL)
TableUpdateTestCase (Create partitions of existing range 
partitioned table,
Detach partition from existing range

pgAdmin 4 commit: Fix an issue where we were executing SELECT statement

2017-09-20 Thread Dave Page 
Fix an issue where we were executing SELECT statements in transactions in query 
tool which probably is not required because SELECT statements are already 
protected from dirty reads. Fixes #2683

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=354679e69b0591821e44a6294e7e175d078215e2

Modified Files
--
web/pgadmin/tools/sqleditor/__init__.py | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)

Re: pgAdmin 4 commit: Bundle fonts with pgAdmin so we have a standard set f

2017-09-20 Thread Dave Page 
Thanks, applied.

On Tue, Sep 19, 2017 at 12:38 PM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi Dave,
>
> Please find patch to fix the font on alertify header.
> Please review.
>
> --
> Regards,
> Murtuza Zabuawala
>
> On Fri, Sep 15, 2017 at 7:10 PM, Murtuza Zabuawala  enterprisedb.com> wrote:
>
>> Hi Atul,
>>
>> I think we still missed alertify header fonts :)
>> Check screenshot.
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> [image: https://community.postgresrocks.net/]
>> 
>>
>> On Fri, Sep 15, 2017 at 6:38 PM, Dave Page  wrote:
>>
>>> Thanks, applied.
>>>
>>> On Fri, Sep 15, 2017 at 8:59 AM, Atul Sharma <
>>> atul.sha...@enterprisedb.com> wrote:
>>>
 Hi,

 PFA patch which replaces the "Roboto" font family with "Open Sans" for
 alertify dialogs. Regarding Query tool context menu, It seems different
 issue than the applied fonts.

 Regards,
 Atul

 On Thu, Sep 14, 2017 at 7:49 PM, Murtuza Zabuawala <
 murtuza.zabuaw...@enterprisedb.com> wrote:

> Attaching more screenshots.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> [image: https://community.postgresrocks.net/]
> 
>
> On Thu, Sep 14, 2017 at 7:08 PM, Murtuza Zabuawala <
> murtuza.zabuaw...@enterprisedb.com> wrote:
>
>> Hi Atul,
>>
>> Please also check fonts in various the alertify dialogs.
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> [image: https://community.postgresrocks.net/]
>> 
>>
>> On Thu, Sep 14, 2017 at 7:03 PM, Dave Page  wrote:
>>
>>> Nope - it shouldn't look like that. Atul, Can you take a look at it
>>> please?
>>>
>>> On Thu, Sep 14, 2017 at 2:26 PM, Murtuza Zabuawala <
>>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>>
 Hi Dave,

 After latest pull fonts from context menu looks different, PFA
 screenshot.
 I tried on macOS: 10.10 (Web mode) on Google Chrome: Version
 60.0.3112.113 (Official Build) (64-bit)

 Is this expected behaviour?


 --
 Regards,
 Murtuza Zabuawala
 EnterpriseDB: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company

 [image: https://community.postgresrocks.net/]
 

 On Wed, Sep 13, 2017 at 8:31 PM, Dave Page 
 wrote:

> Bundle fonts with pgAdmin so we have a standard set for all
> platforms.
>
> Research by Shirley at Pivotal.
>
> Branch
> --
> master
>
> Details
> ---
> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdif
> f;h=788f7f3a69500c37008dbba459d3ea00b0b1bff8
> Author: Atul Sharma 
>
> Modified Files
> --
> libraries.txt  |   4 ++-
> web/pgadmin/browser/static/css/browser.css |  33
> ++---
> .../misc/bgprocess/static/css/bgprocess.css|   2 +-
> .../misc/file_manager/static/css/file_manager.css  |   2 +-
> web/pgadmin/static/css/aci_tree.overrides.css  |   4 +--
> web/pgadmin/static/css/bootstrap.overrides.css |   5 ++--
> web/pgadmin/static/css/codemirror.overrides.css|   4 +--
> web/pgadmin/static/css/pgadmin.css |  17
> ++-
> web/pgadmin/static/css/pgadmin.style.css   |  10 +++
> web/pgadmin/static/css/webcabin.overrides.css  |   6 ++--
> web/pgadmin/static/fonts/OpenSans-Bold.ttf | Bin 0 ->
> 224452 bytes
> web/pgadmin/static/fonts/OpenSans-Italic.ttf   | Bin 0 ->
> 212760 bytes
> web/pgadmin/static/fonts/OpenSans-Regular.ttf  | Bin 0 ->
> 217276 bytes
> web/pgadmin/static/fonts/OpenSans-SemiBold.ttf | Bin 0 ->
> 221164 bytes
> web/pgadmin/static/fonts/SourceCodePro-Bold.ttf| Bin 0 ->
> 120504 bytes
> web/pgadmin/static/fonts/SourceCodePro-Regular.ttf | Bin 0 ->
> 120548 bytes
> web/pgadmin/static/scss/_alert.scss|   2 +-
> web/pgadmin/static/scss/_alertify.overrides.scss   |   2 +-
> web/pgadmin/static/scss/_typography.scss   |   2 +-
>

pgAdmin 4 commit: Fix font on alertify dialogues

2017-09-20 Thread Dave Page 
Fix font on alertify dialogues

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=64159d11ce6a437b13d115834bfaec3a25618232
Author: Murtuza Zabuawala 

Modified Files
--
web/pgadmin/static/css/pgadmin.style.css | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Re: [pgAdmin4][Patch] RM 2673 Error not displaying in proper format in User management and Grant Wizard

2017-09-20 Thread Dave Page 
Thanks, applied.

On Tue, Sep 19, 2017 at 11:20 AM, Akshay Joshi <
akshay.jo...@enterprisedb.com> wrote:

> Hi
>
> Attached is the patch file to fix RM 2673 "Error not displaying in proper
> format in User management and Grant Wizard". Patch contains fix for Grant
> Wizard, as fix for user management is already committed.
>
> --
> *Akshay Joshi*
> *Principal Software Engineer *
>
>
>
> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 976-788-8246
> <+91%2097678%2088246>*
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgAdmin 4 commit: Fix validation message styling on thegrant wizard. Fi

2017-09-20 Thread Dave Page 
Fix validation message styling on thegrant wizard. Fixes #2673

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=13665f68d8e5b51621c176ada17c4f910a305055
Author: Akshay Joshi 

Modified Files
--
web/pgadmin/browser/static/css/wizard.css|  2 +-
web/pgadmin/browser/static/js/wizard.js  | 12 ++--
web/pgadmin/tools/grant_wizard/static/js/grant_wizard.js |  6 --
3 files changed, 15 insertions(+), 5 deletions(-)

pgAdmin 4 commit: Improve display of error messages in the query tool.

2017-09-20 Thread Dave Page 
Improve display of error messages in the query tool. Fixes #2700

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2ddbddba33ea695cb479509a1928920525c29893
Author: Murtuza Zabuawala 

Modified Files
--
web/pgadmin/utils/driver/psycopg2/__init__.py  | 93 ++
.../javascript/history/query_history_spec.jsx  | 39 +
2 files changed, 99 insertions(+), 33 deletions(-)

[pgAdmin4][Patch]: To exclude SELECT queries from transaction in query tool

2017-09-20 Thread Murtuza Zabuawala 
Hi,

PFA minor patch to fix the issue where we were executing SELECT statements
in transactions in query tool which probably is not required because SELECT
statements are already protected from dirty reads.
RM#2683

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
diff --git a/web/pgadmin/tools/sqleditor/__init__.py 
b/web/pgadmin/tools/sqleditor/__init__.py
index 15ec8c4..ee7dc8c 100644
--- a/web/pgadmin/tools/sqleditor/__init__.py
+++ b/web/pgadmin/tools/sqleditor/__init__.py
@@ -1319,8 +1319,10 @@ def is_begin_required(query):
 return False
 if word_len == 5 and keyword.lower() == "start":
 return False
-if word_len == 6 and keyword.lower() == "commit":
-return False
+if word_len == 6:
+# SELECT is protected from dirty reads hence don't require transaction
+if keyword.lower() in ["select", "commit"]:
+return False
 if word_len == 3 and keyword.lower() == "end":
 return False
 if word_len == 8 and keyword.lower() == "rollback":