RM2898 Keyboard navigation in dialog tabs (nav tabs)

2018-02-19 Thread Harshal Dhumal
Hi, Please find attached patch to enable keyboard navigation in dialog. To allow navigation from one tab pane (bootstrap tab pane) to another one I have added two new shortcut preferences *Dialog tab previous *( shift+control+[ ) and *Dialog tab next* ( shift+control+] ) for backward and forward

RM3080 Fix for alignment issue in keyboard preferences

2018-02-19 Thread Harshal Dhumal
Hi, Please find attached patch to fix alignment issue in keyboard preferences. -- *Harshal Dhumal* *Sr. Software Engineer* EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/__init__.py b/web/pgadmin/browser/__init__.py index

Jenkins build is back to normal : pgadmin4-master-python35 #484

2018-02-19 Thread pgAdmin 4 Jenkins
See

Jenkins build is back to normal : pgadmin4-master-python27 #484

2018-02-19 Thread pgAdmin 4 Jenkins
See

Jenkins build is back to normal : pgadmin4-master-python34 #474

2018-02-19 Thread pgAdmin 4 Jenkins
See

Jenkins build is back to normal : pgadmin4-master-python33 #481

2018-02-19 Thread pgAdmin 4 Jenkins
See

Jenkins build is back to normal : pgadmin4-master-python26 #611

2018-02-19 Thread pgAdmin 4 Jenkins
See

Build failed in Jenkins: pgadmin4-master-python35 #483

2018-02-19 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Python 3 fix for the runtime. -- [...truncated 494.75 KB...] copying images... [ 26%] images/foreign_key_action.png copying images... [

pgAdmin 4 commit: Fix stupid thinko

2018-02-19 Thread Dave Page
Fix stupid thinko Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8a56eb9cd01265cd81b44fa06ea45b7240a3991a Modified Files -- runtime/Server.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

Build failed in Jenkins: pgadmin4-master-python27 #483

2018-02-19 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Python 3 fix for the runtime. -- [...truncated 495.73 KB...] copying images... [ 26%] images/table_foreign_key.png copying images... [

Build failed in Jenkins: pgadmin4-master-python33 #480

2018-02-19 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Python 3 fix for the runtime. -- [...truncated 493.63 KB...] copying images... [ 25%] images/trigger_function_definition.png copying

Build failed in Jenkins: pgadmin4-master-python36 #477

2018-02-19 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Python 3 fix for the runtime. -- [...truncated 494.46 KB...] copying images... [ 26%] images/foreign_data_wrapper_sql.png copying

Build failed in Jenkins: pgadmin4-master-python34 #473

2018-02-19 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Python 3 fix for the runtime. -- [...truncated 494.69 KB...] copying images... [ 26%] images/maintenance_complete.png copying images...

Build failed in Jenkins: pgadmin4-master-python26 #610

2018-02-19 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Python 3 fix for the runtime. -- [...truncated 501.08 KB...] copying images... [ 31%] images/check_sql.png copying images... [ 32%]

pgAdmin 4 commit: Python 3 fix for the runtime.

2018-02-19 Thread Dave Page
Python 3 fix for the runtime. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=df667bff5316cecbd78b15d6561fdc2043c3b2a6 Modified Files -- runtime/Server.cpp | 6 ++ 1 file changed, 6 insertions(+)

Re: [pgAdmin4][Patch]: RM #3066 - Create script doesn't add quotation marks to column names for the "add index" functions

2018-02-19 Thread Khushboo Vashi
On Mon, Feb 19, 2018 at 5:19 PM, Dave Page wrote: > Hi > > On Mon, Feb 19, 2018 at 7:56 AM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> Please find the attached patch to fix RM #3066 - Create script doesn't >> add quotation marks to column names

Re: [pgAdmin4][Patch]: RM 3081- Reverse engineered SQL for Sequences missing comment header and drop statement

2018-02-19 Thread Dave Page
Thanks, patch applied. On Mon, Feb 19, 2018 at 6:21 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to fix RM #3081 : Reverse engineered SQL > for Sequences missing comment header and drop statement > > Thanks, > Khushboo > -- Dave Page

pgAdmin 4 commit: Add missing reverse-engineered SQL header and drop st

2018-02-19 Thread Dave Page
Add missing reverse-engineered SQL header and drop statement for sequences. Fixes #3081 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c85e14dc2502c5eff9ee24824ed73cc0da2e1225 Author: Khushboo Vashi

pgAdmin 4 commit: Ensure we can properly update rows with upper-case pr

2018-02-19 Thread Dave Page
Ensure we can properly update rows with upper-case primary key columns. Fixes #3105 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=96165044ae7abbd7bef04d181a42487f8f96c42c Author: Murtuza Zabuawala

Jenkins build is back to normal : pgadmin4-master-python26 #608

2018-02-19 Thread pgAdmin 4 Jenkins
See

Re: [pgAdmin4][RM#2950] Add marker to dashboard queries

2018-02-19 Thread Dave Page
Thanks, patch applied. On Thu, Feb 15, 2018 at 4:23 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Murtuza, > Looks like I missread the Issue then. > In that case I think it might be the solution that we can implement. > Unless anyone in the list as a different idea.

pgAdmin 4 commit: Add a marker (/*pga4dash*/) to the dashboard queries

2018-02-19 Thread Dave Page
Add a marker (/*pga4dash*/) to the dashboard queries to allow them to be more easily filtered from server logs. Fixes #2950 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4dc9fb146ab47a8fdff8b7db3ecf773690e5625f Author: Murtuza Zabuawala

Re: [pgAdmin4][RM#3121] Fix PEP-8 issues

2018-02-19 Thread Dave Page
Thanks, patch applied. On Thu, Feb 15, 2018 at 4:15 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Thank you for reviewing Joao. > > > On Thu, Feb 15, 2018 at 8:37 PM, Joao De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Hello Murtuza, >> I just run this

pgAdmin 4 commit: Fix PEP8 issues in various modules. Fixes #3121

2018-02-19 Thread Dave Page
Fix PEP8 issues in various modules. Fixes #3121 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7301e30ff3a57b4380c2cf56f67c065f56eb229a Author: Murtuza Zabuawala Modified Files --

Re: [pgadmin4][patch] Hides the tablespace node in ACI tree for GreenPlum

2018-02-19 Thread Dave Page
Hi On Mon, Feb 12, 2018 at 6:30 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Hackers > > The attached patch implements the feature #3107 to hide the tablespaces on > GreenPlum databases. > Did you accidentally include some keyboard shortcut test code in this patch?

Re: [pgAdmin4][RM#2901] Make shortcuts configurable in Debugger

2018-02-19 Thread Dave Page
Thanks, applied. On Mon, Feb 12, 2018 at 7:27 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > PFA patch to update button tooltip. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > On Fri,

pgAdmin 4 commit: Show button shortcut keys in the debugger on tooltips

2018-02-19 Thread Dave Page
Show button shortcut keys in the debugger on tooltips. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=30868614ffd55a5b89c462473477bf68e181edf4 Author: Murtuza Zabuawala Modified Files --

pgAdmin 4 commit: Un-vendorise React, now that it contains bug fixes we

2018-02-19 Thread Dave Page
Un-vendorise React, now that it contains bug fixes we need. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0677ad254adc9f4adde5b45626c8491212647bad Author: Joao Pedro De Almeida Pereira Modified Files

Re: [pgadmin4][patch] #3099 GPDB: Creating table and creating column in table fails

2018-02-19 Thread Dave Page
Thanks, patch applied. On Fri, Feb 9, 2018 at 10:49 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Hackers, > > Attached is the patch that correct the creation of tables and columns. > > Also started using in a more widespread way the `compile_template_path` > function

pgAdmin 4 commit: Fix creation of tables and columns in GPDB. Fixes #30

2018-02-19 Thread Dave Page
Fix creation of tables and columns in GPDB. Fixes #3099 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=15862e903a75433df7e6746ecaa89248cbe97d95 Author: Joao Pedro De Almeida Pereira Modified Files

pgAdmin 4 commit: Fix Python 2.6 support.

2018-02-19 Thread Dave Page
Fix Python 2.6 support. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1a958a39514d1f839e382950105333ac2462c195 Author: Murtuza Zabuawala Modified Files -- pkg/pip/setup_pip.py | 6 --

Build failed in Jenkins: pgadmin4-master-python26 #607

2018-02-19 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Fix target name -- Started by an SCM change Started by an SCM change Started by an SCM change Started by an SCM change Started by an SCM

pgAdmin 4 commit: Fix target name

2018-02-19 Thread Dave Page
Fix target name Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d5aeb8a69166067187b622f4487d0be612a32576 Modified Files -- README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: Proposal for changes in official Docker image

2018-02-19 Thread Dave Page
Hi On Sun, Feb 18, 2018 at 5:41 PM, Максим Кольцов wrote: > Hi! > > I accidentially sent this email to pgsql-hackers yesterday, sorry! > > First of all, thanks for the great app :) > > I started using PgAdmin with docker image (dpage/pgadmin4) a few weeks > ago, however I

Re: Next release

2018-02-19 Thread Dave Page
On Thu, Feb 15, 2018 at 2:26 PM, Robert Eckhardt wrote: > Apologies if this has been discussed and I missed it. > > When is the 3.0 release planned? > I was planning it to be in a week or two, however I'm currently dealing with a family emergency so it's likely to be March