Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree

[Joao De Almeida Pereira]

Hello Murtuza/Dave,
Yes now the extracted functions are spread into different files. The intent
would be to make the files as small as possible, and also to group and name
them in a way that would be easy to understand what each file is doing
without the need of opening it.
As a example:
static/js/backup will contain all the backup related functionality
inside of this folder we can see the file:
menu_utils.js At this moment in time we decided to group all the functions
that are related to the menu, but we can split that also if we believe it
is easier to see.

static/js/datagrid folder contains all the datagrid related functionality
Inside of the folder we can see the files:
get_panel_title.js is responsible for retrieving the name of the panel
show_data.js is responsible for showing the datagrid
show_query_tool.js is responsible for showing the query tool

Does this structure make sense?
Can you give an example of a comment that you think is missing and that
could help?

As a personal note, unless the algorithm is very obscure or very
complicated, I believe that if the code needs comments it is a signal that
something needs to change in terms of naming, structure of the part in
question. This being said, I am open to add some comments that might help
people.

Thanks
Joao
​


On Fri, Apr 6, 2018 at 4:48 AM Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi Joao,
>
> Patch looks good and working as expected.
>
> I also agree with Dave, Can we please add some comments in each file which
> can help us to understand the flow, I'm saying because now the code is
> segregated in so many separate files it will be hard to keep track of the
> flow from one file to another when debugging.
>
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> On Thu, Apr 5, 2018 at 7:08 PM, Joao De Almeida Pereira <
> jdealmeidapere...@pivotal.io> wrote:
>
>> Hi Khushboo,
>> Attached you can find both patches rebased
>>
>> Thanks
>>
>>
>> On Thu, Apr 5, 2018 at 6:31 AM Khushboo Vashi <
>> khushboo.va...@enterprisedb.com> wrote:
>>
>>> Hi Joao,
>>>
>>> Can you please rebase the second patch?
>>>
>>> Thanks,
>>> Khushboo
>>>
>>>
>>> On Tue, Apr 3, 2018 at 12:15 AM, Joao De Almeida Pereira <
>>> jdealmeidapere...@pivotal.io> wrote:
>>>
 Hi Hackers,

 Attached you can find the patch that will start to decouple pgAdmin
 from ACITree library.
 This patch is intended to be merged after 3.0, because we do not want
 to cause any entropy or delay the release, but we want to start the
 discussion and show some code.

 This job that we started is a massive tech debt chore that will take
 some time to finalize and we would love the help of the community to do it.

 *Summary of the patch:*
 0001 patch:
  - Creates a new tree that will allow us to create a separation between
 the application and ACI Tree
  - Creates a Fake Tree (Test double, for reference on the available
 test doubles: https://martinfowler.com/bliki/TestDouble.html) that can
 be used to inplace to replace the ACITree and also encapsulate the new tree
 behavior on our tests
  - Adds tests for all the tree functionalities

 0002 patch:
  - Extracts, refactors, adds tests and remove dependency from ACI Tree
 on:
 - getTreeNodeHierarchy
 - on backup.js: menu_enabled, menu_enabled_server,
 start_backup_global_server, backup_objects
 - on datagrid.js: show_data_grid, get_panel_title, show_query_tool
 - Start using sprintf-js as Underscore.String is deprecating sprintf
 function

 This patch represents only 10 calls to ACITree.itemData out of 176 that
 are spread around our code


 *In Depth look on the process behind the patch:*

 We started writing this patch with the idea that we need to decouple
 pgAdmin4 from ACITree, because ACITree is no longer supported, the
 documentation is non existent and ACITree is no longer being actively
 developed.

 Our process:
 1. We "randomly" selected a function that is part of the ACITree. From
 this point we decided to replace that function with our own version. The
 function that we choose was "itemData".
 The function gives us all the "data" that a specific node of the tree
 find.
 Given in order to replace the tree we would need to have a function
 that would give us the same information. We had 2 options:
   a) Create a tree with a function called itemData
 Pros:
  - At first view this was the simpler solution
  - Would keep the status quo
 Cons:
  - Not a OOP approach
  - Not very flexible
   b) Create a tree that would return a node given an ID and then the
 node would be responsible for giving it's data.
 Pros:
  - OOP Approach
  - More flexible and we do not need to bring the tree around, just a
 node

pgAdmin 4 commit: Branch refs/heads/REL-2_X was created

[git]

Branch refs/heads/REL-2_X was created.

View: 
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=shortlog;h=refs/heads/REL-2_X

pgAdmin 4 commit: Update developer docs to note that ES6 should be used

[Dave Page]

Update developer docs to note that ES6 should be used and tests should be 
included.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a97e4c76e4aeac26fe9b37e0466b3d5a619bd04a

Modified Files
--
docs/en_US/code_review.rst  | 3 +++
docs/en_US/coding_standards.rst | 3 +++
2 files changed, 6 insertions(+)

pgAdmin 4 commit: Add a (configurable) limit to the number of pgAgent j

[Dave Page]

Add a (configurable) limit to the number of pgAgent job history rows displayed 
on the statistics tab. Fixes #3072

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8ec51412c34df5d27501d618e18f90883a023f14
Author: Murtuza Zabuawala 

Modified Files
--
.../images/preferences_browser_properties.png  | Bin 51937 -> 112725 bytes
docs/en_US/preferences.rst |   2 +
docs/en_US/release_notes_3_0.rst   |   1 +
web/pgadmin/browser/__init__.py| 272 +--
.../browser/register_browser_preferences.py| 293 +
.../server_groups/servers/pgagent/__init__.py  |   9 +-
.../servers/pgagent/steps/__init__.py  |   9 +-
.../pgagent/templates/pga_job/sql/pre3.4/stats.sql |   3 +-
.../templates/pga_jobstep/sql/pre3.4/stats.sql |   3 +-
.../servers/pgagent/tests/__init__.py  |  15 ++
.../servers/pgagent/tests/test_pgagent_add.py  |  89 +++
.../servers/pgagent/tests/test_pgagent_delete.py   |  49 
.../servers/pgagent/tests/test_pgagent_put.py  |  51 
.../servers/pgagent/tests/tests_pgagent_get.py |  45 
.../servers/pgagent/tests/tests_pgagent_stats.py   |  45 
.../server_groups/servers/pgagent/tests/utils.py   | 175 
16 files changed, 788 insertions(+), 273 deletions(-)

Re: [pgAdmin4][RM#3072] Make pgagent job history rows configurable

[Dave Page]

Thanks, applied.

On Fri, Apr 6, 2018 at 5:53 AM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi,
>
> Please find updated patch which fixes PEP8 issue, added help string for
> preference dialog option & updated screenshot.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> On Thu, Apr 5, 2018 at 7:56 PM, Dave Page  wrote:
>
>> Sorry Murtuza - I'm mixing patches up here. It's the sort/filter one I
>> need the image for please.
>>
>> Which means this patch needs re-creating as well please.
>>
>> On Thu, Apr 5, 2018 at 3:03 PM, Murtuza Zabuawala <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>>> Hi Dave,
>>>
>>> Please find attached PNG.
>>>
>>> On Thu, Apr 5, 2018 at 7:25 PM, Dave Page  wrote:
>>>
 Murtuza, please send me the screenshot as a PNG. I've been tweaking the
 code and will recreate the patch with my changes.

 On Thu, Apr 5, 2018 at 2:53 PM, Joao De Almeida Pereira <
 jdealmeidapere...@pivotal.io> wrote:

> Hi Murtuza,
> Generally the patch looks good passes all CI but the linter fails:
>
> /tmp/build/4a5630c2/pivotal-rm-3072/web /tmp/build/4a5630c2
>  
> 
> ./pgadmin/browser/register_browser_preferences.py:11: [E302] expected 2 
> blank lines, found 1
>  
> 
> 1   E302 expected 2 blank lines, found 1
>  
> 
> 1
>
>
> Did not test the functionality itself 
>
 ​@Joao,
>>> I have included the test for Stats call which will cover the newly added
>>> functionality.​
>>>
>>>
 Thanks
> Joao
>
> On Thu, Apr 5, 2018 at 8:09 AM Murtuza Zabuawala <
> murtuza.zabuaw...@enterprisedb.com> wrote:
>
>> Hi Dave,
>>
>> Please find update patch.
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>>
>> On Thu, Apr 5, 2018 at 4:52 PM, Murtuza Zabuawala <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>>> On Thu, Apr 5, 2018 at 4:43 PM, Dave Page  wrote:
>>>
 Hi

 On Thu, Apr 5, 2018 at 11:10 AM, Murtuza Zabuawala <
 murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi,
>
> PFA patch which allow user to configure how many rows they wish to
> display for any pgagent jobs on statistics panel.
>

 I think this is essentially good, however, I'm really not happy
 with the preference name and category. In general, I'd suggest that 
 before
 creating patches in the future we should confirm naming etc on the 
 mailing
 list, as I often end up changing wording and then requiring new 
 screenshots
 etc.

>>> ​Ok​
>>>
>>>

 In this case, I really don't like that we've added another
 category, and quite a specific one at that. I would suggest we move it 
 to
 Browser -> Properties and name it "Maximum job history rows" with a
 description of "The maximum number of history rows to show on the
 Statistics tab for pgAgent jobs."

>>> I'll change it and resend the patch.
>>>
>>>

 Thoughts?

 --
 Dave Page
 Blog: http://pgsnake.blogspot.com
 Twitter: @pgsnake

 EnterpriseDB UK: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company

>>>
>>>
>>


 --
 Dave Page
 Blog: http://pgsnake.blogspot.com
 Twitter: @pgsnake

 EnterpriseDB UK: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company

>>>
>>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree

[Murtuza Zabuawala]

Hi Joao,

Patch looks good and working as expected.

I also agree with Dave, Can we please add some comments in each file which
can help us to understand the flow, I'm saying because now the code is
segregated in so many separate files it will be hard to keep track of the
flow from one file to another when debugging.


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Thu, Apr 5, 2018 at 7:08 PM, Joao De Almeida Pereira <
jdealmeidapere...@pivotal.io> wrote:

> Hi Khushboo,
> Attached you can find both patches rebased
>
> Thanks
>
>
> On Thu, Apr 5, 2018 at 6:31 AM Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>> Hi Joao,
>>
>> Can you please rebase the second patch?
>>
>> Thanks,
>> Khushboo
>>
>>
>> On Tue, Apr 3, 2018 at 12:15 AM, Joao De Almeida Pereira <
>> jdealmeidapere...@pivotal.io> wrote:
>>
>>> Hi Hackers,
>>>
>>> Attached you can find the patch that will start to decouple pgAdmin from
>>> ACITree library.
>>> This patch is intended to be merged after 3.0, because we do not want to
>>> cause any entropy or delay the release, but we want to start the discussion
>>> and show some code.
>>>
>>> This job that we started is a massive tech debt chore that will take
>>> some time to finalize and we would love the help of the community to do it.
>>>
>>> *Summary of the patch:*
>>> 0001 patch:
>>>  - Creates a new tree that will allow us to create a separation between
>>> the application and ACI Tree
>>>  - Creates a Fake Tree (Test double, for reference on the available test
>>> doubles: https://martinfowler.com/bliki/TestDouble.html) that can be
>>> used to inplace to replace the ACITree and also encapsulate the new tree
>>> behavior on our tests
>>>  - Adds tests for all the tree functionalities
>>>
>>> 0002 patch:
>>>  - Extracts, refactors, adds tests and remove dependency from ACI Tree
>>> on:
>>> - getTreeNodeHierarchy
>>> - on backup.js: menu_enabled, menu_enabled_server,
>>> start_backup_global_server, backup_objects
>>> - on datagrid.js: show_data_grid, get_panel_title, show_query_tool
>>> - Start using sprintf-js as Underscore.String is deprecating sprintf
>>> function
>>>
>>> This patch represents only 10 calls to ACITree.itemData out of 176 that
>>> are spread around our code
>>>
>>>
>>> *In Depth look on the process behind the patch:*
>>>
>>> We started writing this patch with the idea that we need to decouple
>>> pgAdmin4 from ACITree, because ACITree is no longer supported, the
>>> documentation is non existent and ACITree is no longer being actively
>>> developed.
>>>
>>> Our process:
>>> 1. We "randomly" selected a function that is part of the ACITree. From
>>> this point we decided to replace that function with our own version. The
>>> function that we choose was "itemData".
>>> The function gives us all the "data" that a specific node of the tree
>>> find.
>>> Given in order to replace the tree we would need to have a function that
>>> would give us the same information. We had 2 options:
>>>   a) Create a tree with a function called itemData
>>> Pros:
>>>  - At first view this was the simpler solution
>>>  - Would keep the status quo
>>> Cons:
>>>  - Not a OOP approach
>>>  - Not very flexible
>>>   b) Create a tree that would return a node given an ID and then the
>>> node would be responsible for giving it's data.
>>> Pros:
>>>  - OOP Approach
>>>  - More flexible and we do not need to bring the tree around, just a node
>>> Cons:
>>>  - Break the current status quo
>>>
>>> Given these 2 options we decided to go for a more OOP approach creating
>>> a Tree and a TreeNode classes, that in the future will be renamed to
>>> ACITreeWrapper and TreeNode.
>>>
>>> 2. After we decided on the starting point we searched for occurrences of
>>> the function "itemData" and we found out that there were 303 occurrences of
>>> "itemData" in the code and roughly 176 calls to the function itself (some
>>> of the hits were variable names).
>>>
>>> 3. We selected the first file on the search and found the function that
>>> was responsible for calling the itemData function.
>>>
>>> 4. Extracted the function to a separate file
>>>
>>> 5. Wrap this function with tests
>>>
>>> 6. Refactor the function to ES6, give more declarative names to
>>> variables and break the functions into smaller chunks
>>>
>>> 7. When all the tests were passing we replaced ACITree with our Tree
>>>
>>> 8. We ensured that all tests were passing
>>>
>>> 9. Remove function from the original file and use the new function
>>>
>>> 10. Ensure everything still works
>>>
>>> 11. Find the next function and execute from step 4 until all the
>>> functions are replaced, refactored and tested.
>>>
>>> As you can see by the process this is a pretty huge undertake, because
>>> of the number of calls to the function. This is just the first step on the
>>> direction of completely isolating the ACITree so that we can solve the
>>> problem with a large number of elements on 

Re: [pgAdmin4][RM#3154] Update modules to latest version

[Dave Page]

On Fri, Apr 6, 2018 at 8:52 AM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi Dave,
>
> I checked and found that the issue was in wcDocker which was causing
> problem while opening query tool,
> I have logged an issue on github: https://github.com/
> WebCabin/wcDocker/issues/124
>
> Query tool, Debugger etc are working properly when open in new Browser Tab
> and not in Panel.
>
> I'm also able to fix the issue which I was facing while running Jasmine
> test by correctting the path for *jquery.event.drag* library from
> jquery.event.drag-2.2 to jquery.event.drag-2.3.0.
>
> Let's wait for author's reply on the issue.
>

Great, thanks.


>
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> On Wed, Apr 4, 2018 at 3:20 PM, Murtuza Zabuawala  enterprisedb.com> wrote:
>
>> On Wed, Apr 4, 2018 at 3:19 PM, Dave Page  wrote:
>>
>>>
>>>
>>> On Wed, Apr 4, 2018 at 8:24 AM, Murtuza Zabuawala <
>>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>>
 Hi Joao,

 Yes it bundles latest version but I doubt that is not using it, If we
 upgrade the jQuery to 3.3.1 then it's breaking the SlickGrid.
 I have tried that and I started getting jQuery related errors when
 trying to run query tool or when running jasmine tests.

>>>
>>> Can you spend some time trying to figure it out please? We need to get
>>> on to 3.x as older versions are no longer receiving updates which could
>>> pose a security risk.
>>>
>> ​Sure Dave.​
>>
>>
>>>
>>>

 --
 Regards,
 Murtuza Zabuawala
 EnterpriseDB: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company


 On Wed, Apr 4, 2018 at 1:39 AM, Joao De Almeida Pereira <
 jdealmeidapere...@pivotal.io> wrote:

> Hi Murtuza,
>
> The patches look good and they pass all tests in CI.
> One think that we realized was the SlickGrid as a npm package now:
> https://www.npmjs.com/package/slickgrid
> Also Slickgrid comes packaged with jquery 3.1 not sure if it is fully
> supported or not..
>
> Thanks
> Victoria & Joao
>
> On Tue, Apr 3, 2018 at 11:50 AM Murtuza Zabuawala <
> murtuza.zabuaw...@enterprisedb.com> wrote:
>
>> ​Hi Dave,
>>
>> Reverted back jQuery version to 1.x because of SlickGrid dependancy.
>> Please find updated patch.
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>>
>> On Tue, Apr 3, 2018 at 8:50 PM, Murtuza Zabuawala <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>>> Please hold on my previous patch.
>>>
>>> We can't use latest jQuery version as SlickGrid has dependancy on
>>> older version.
>>> I'll send updated patch again.
>>>
>>> On Tue, Apr 3, 2018 at 8:20 PM, Murtuza Zabuawala <
>>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>>
 Hi Dave,

 Please find updated patches, there are two patches attached one is
 for the story and another is for changes required as per new modules.


 On Tue, Apr 3, 2018 at 6:27 PM, Dave Page 
 wrote:

> Hi
>
> On Fri, Mar 30, 2018 at 8:01 AM, Murtuza Zabuawala <
> murtuza.zabuaw...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> PFA patch to update the modules to latest version.
>>
>>
> - Why isn't jQuery updated to 3.3.1?
>
 ​Done​


> ​
>
>

> - Shouldn't pkg/pip/setup_pip.py be updated with changes to
> psycopg2 and pycrypto etc?
>
 ​Done​


>
>
>
>> We are not able to update some of the modules to latest version
>> due to dependancy on other modules, For example
>> - Python: Flask-Security has dependancy on flask-babelex which
>> causes conflict with flask_babel
>>
>
> Hmm, flask-babelex might be a better option anyway; in particular,
> it avoids loading catalogs with every request which seems desirable 
> given
> the size of ours. On the other hand, it hasn't been updated so 
> recently.
>
 ​I have removed flask-babel and used flask_babelex instead.​


>
>
>> - JS: Can't update to Bootstrap4 because Bootstrap Switch &
>> Bootstrap Datetime picker has dependancy on Bootstrap3.
>>
>
> OK.
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Re: [pgAdmin4][RM#3154] Update modules to latest version

[Murtuza Zabuawala]

Hi Dave,

I checked and found that the issue was in wcDocker which was causing
problem while opening query tool,
I have logged an issue on github:
https://github.com/WebCabin/wcDocker/issues/124

Query tool, Debugger etc are working properly when open in new Browser Tab
and not in Panel.

I'm also able to fix the issue which I was facing while running Jasmine
test by correctting the path for *jquery.event.drag* library from
jquery.event.drag-2.2 to jquery.event.drag-2.3.0.

Let's wait for author's reply on the issue.


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Wed, Apr 4, 2018 at 3:20 PM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> On Wed, Apr 4, 2018 at 3:19 PM, Dave Page  wrote:
>
>>
>>
>> On Wed, Apr 4, 2018 at 8:24 AM, Murtuza Zabuawala <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>>> Hi Joao,
>>>
>>> Yes it bundles latest version but I doubt that is not using it, If we
>>> upgrade the jQuery to 3.3.1 then it's breaking the SlickGrid.
>>> I have tried that and I started getting jQuery related errors when
>>> trying to run query tool or when running jasmine tests.
>>>
>>
>> Can you spend some time trying to figure it out please? We need to get on
>> to 3.x as older versions are no longer receiving updates which could pose a
>> security risk.
>>
> ​Sure Dave.​
>
>
>>
>>
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>>
>>> On Wed, Apr 4, 2018 at 1:39 AM, Joao De Almeida Pereira <
>>> jdealmeidapere...@pivotal.io> wrote:
>>>
 Hi Murtuza,

 The patches look good and they pass all tests in CI.
 One think that we realized was the SlickGrid as a npm package now:
 https://www.npmjs.com/package/slickgrid
 Also Slickgrid comes packaged with jquery 3.1 not sure if it is fully
 supported or not..

 Thanks
 Victoria & Joao

 On Tue, Apr 3, 2018 at 11:50 AM Murtuza Zabuawala <
 murtuza.zabuaw...@enterprisedb.com> wrote:

> ​Hi Dave,
>
> Reverted back jQuery version to 1.x because of SlickGrid dependancy.
> Please find updated patch.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> On Tue, Apr 3, 2018 at 8:50 PM, Murtuza Zabuawala <
> murtuza.zabuaw...@enterprisedb.com> wrote:
>
>> Please hold on my previous patch.
>>
>> We can't use latest jQuery version as SlickGrid has dependancy on
>> older version.
>> I'll send updated patch again.
>>
>> On Tue, Apr 3, 2018 at 8:20 PM, Murtuza Zabuawala <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>>> Hi Dave,
>>>
>>> Please find updated patches, there are two patches attached one is
>>> for the story and another is for changes required as per new modules.
>>>
>>>
>>> On Tue, Apr 3, 2018 at 6:27 PM, Dave Page  wrote:
>>>
 Hi

 On Fri, Mar 30, 2018 at 8:01 AM, Murtuza Zabuawala <
 murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi,
>
> PFA patch to update the modules to latest version.
>
>
 - Why isn't jQuery updated to 3.3.1?

>>> ​Done​
>>>
>>>
 ​


>>>
 - Shouldn't pkg/pip/setup_pip.py be updated with changes to
 psycopg2 and pycrypto etc?

>>> ​Done​
>>>
>>>



> We are not able to update some of the modules to latest version
> due to dependancy on other modules, For example
> - Python: Flask-Security has dependancy on flask-babelex which
> causes conflict with flask_babel
>

 Hmm, flask-babelex might be a better option anyway; in particular,
 it avoids loading catalogs with every request which seems desirable 
 given
 the size of ours. On the other hand, it hasn't been updated so 
 recently.

>>> ​I have removed flask-babel and used flask_babelex instead.​
>>>
>>>


> - JS: Can't update to Bootstrap4 because Bootstrap Switch &
> Bootstrap Datetime picker has dependancy on Bootstrap3.
>

 OK.


 --
 Dave Page
 Blog: http://pgsnake.blogspot.com
 Twitter: @pgsnake

 EnterpriseDB UK: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company

>>>
>>>
>>
>
>>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>