Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree

Hello Ashesh, 1. In TreeNode, we're keepging the reference of DOMElement, do we really >> need it? > > As of right now, our Tree abstraction acts as an adapter to the aciTree >> library. The aciTree library needs the domElement for most of its functions >> (setInode, unload, etc). Thus this is the

Re: [pgAdmin4][Patch] Feature #3270 Add support for running regression tests against Firefox

Hi Dave On Thu, May 10, 2018 at 2:03 PM, Dave Page wrote: > Hi > > On Wed, May 9, 2018 at 2:55 PM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi >> >> On Wed, May 9, 2018 at 6:19 PM, Dave Page wrote: >> >>> Hi >>> >>> On Wed, May 9, 2018 at 8:10 AM, Akshay Joshi < >>> akshay.jo

Re: JS Test error on Windows

On Fri, May 11, 2018 at 10:53 AM, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Dave, > > The above error was not thrown when import 'jquery.event.drag' was added > to column_selector_spec.js (although it was giving some other error, but > above was cleared). > So the doubt was

Re: JS Test error on Windows

Hi Dave, The above error was not thrown when import 'jquery.event.drag' was added to column_selector_spec.js (although it was giving some other error, but above was cleared). So the doubt was on webpack as it was not importing jquery.event.drag even though it was added using imports-loader, the be

Re: JS Test error on Windows

On Fri, May 11, 2018 at 7:28 AM, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Dave/Hackers, > > PFA fix for the problem. The RegEx for webpack test is not working on > windows because the path separator is different for Windows( \ ) and > Unix( / ). And so, the imports loader

pgAdmin 4 commit: Fix webpack config regexps to be more Windows-friendl

Fix webpack config regexps to be more Windows-friendly. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a34b3f27d47ac2f5be830d5daee62e0bc61a7d31 Author: Aditya Toshniwal Modified Files -- web/webpack.test.config.js | 6 +++--- 1 fi

Re: [pgAdmin4][Patch]: RM #3277 Runtime startup error handling is broken on Windows.

Hi On Fri, May 11, 2018 at 7:23 AM, Akshay Joshi wrote: > Hi > > On Thu, May 10, 2018 at 7:38 PM, Dave Page wrote: > >> Hi >> >> On Thu, May 10, 2018 at 2:00 PM, Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Please find the attached patch to fix RM #3277 Run

pgAdmin 4 commit: Ensure server cleanup on exit only happens if the ser

Ensure server cleanup on exit only happens if the server actually started up. Fixes #3277 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=252a9b265b1ed97c1562d9f9f68feaed229ef19b Author: Akshay Joshi Modified Files -- docs/en_US/