pgAdmin 4 commit: Refactored the dashboard code, which was allowing eac

2018-07-24 Thread Ashesh Vashi
Refactored the dashboard code, which was allowing each node type to define its own dashboardURL. There was a typo, while calling the dashboard function of a Node type. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e12e00703fa2844689171864c78

Re: [pgAdmin4][RM3294] User need to reset the layout to see the changed preferences parameters

2018-07-24 Thread Dave Page
Thanks, applied. On Tue, Jul 24, 2018 at 2:11 PM, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > Attached is the updated patch. > > On Tue, Jul 24, 2018 at 4:32 PM, Dave Page wrote: > >> Hi >> >> On Tue, Jul 24, 2018 at 11:39 AM, Aditya Toshniwal < >> aditya.toshni...@ent

pgAdmin 4 commit: Realtime preference handling for the Dashboards and D

2018-07-24 Thread Dave Page
Realtime preference handling for the Dashboards and Debugger. Fixes #3294 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f7e43d5e506e65ef75f07fecd3913966cd85baf7 Author: Aditya Toshniwal Modified Files -- docs/en_US/release_notes

Re: [pgAdmin4][RM3294] User need to reset the layout to see the changed preferences parameters

2018-07-24 Thread Aditya Toshniwal
Hi, Attached is the updated patch. On Tue, Jul 24, 2018 at 4:32 PM, Dave Page wrote: > Hi > > On Tue, Jul 24, 2018 at 11:39 AM, Aditya Toshniwal enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the second part of the changes for making preferences >> realtime. The patch includes das

Re: [pgAdmin4][RM3294] User need to reset the layout to see the changed preferences parameters

2018-07-24 Thread Dave Page
Hi On Tue, Jul 24, 2018 at 11:39 AM, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the second part of the changes for making preferences > realtime. The patch includes dashboard and debugger modules. > All my dashboard graphs now seem to be straight l

Re: [pgAdmin4][RM3294] User need to reset the layout to see the changed preferences parameters

2018-07-24 Thread Aditya Toshniwal
Adding to previous mail, I have removed shadow from graph lines and increased resolution for better visibility and fixed few issues related to graphs. On Tue, Jul 24, 2018 at 4:09 PM, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the second part of th

Re: [pgAdmin4][RM3294] User need to reset the layout to see the changed preferences parameters

2018-07-24 Thread Aditya Toshniwal
Hi Hackers, Attached is the second part of the changes for making preferences realtime. The patch includes dashboard and debugger modules. I would also request to create RMs for javascript test cases for dashboard and debugger modules as currently there is no setup for the test cases of these two