pgAdmin 4 commit: View Data->Filtered Rows dialog should be displayed.

2018-08-02 Thread Akshay Joshi
View Data->Filtered Rows dialog should be displayed. Fixes #3527 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8f45e6fe684cd365537be9685d0b26c4789382b2 Modified Files -- docs/en_US/release_notes_3_2.rst | 3 ++- w

Re: Implement geospatial data viewer in pgAdmin4 for PostGIS

2018-08-02 Thread Xuri Gong
Thanks! Dave Page 于2018年8月2日周四 下午5:32写道: > Hi > > On Thu, Aug 2, 2018 at 10:30 AM, Xuri Gong wrote: > >> Hi Dave, >> >> I have sent the new patch in a new thread because I thought you have >> missed this email... So please just ignore this patch and review the new >> patch. I also added some te

Re: Implement geospatial data viewer in pgAdmin4 for PostGIS

2018-08-02 Thread Dave Page
Hi On Thu, Aug 2, 2018 at 10:30 AM, Xuri Gong wrote: > Hi Dave, > > I have sent the new patch in a new thread because I thought you have > missed this email... So please just ignore this patch and review the new > patch. I also added some test geo data in the new thread. You can add > postGIS ex

Re: Implement geospatial data viewer in pgAdmin4 for PostGIS

2018-08-02 Thread Xuri Gong
Hi Dave, I have sent the new patch in a new thread because I thought you have missed this email... So please just ignore this patch and review the new patch. I also added some test geo data in the new thread. You can add postGIS extension and then import the data. If you just want to have a quick

Re: Implement geospatial data viewer in pgAdmin4 for PostGIS

2018-08-02 Thread Dave Page
Hi Can you suggest any freely available data sets that can be used to test this with please? I don't have any geo databases. As a quick review-point, I don't see any documentation updates with the patch. Thanks. On Wed, Jul 25, 2018 at 9:13 AM, Xuri Gong wrote: > Hi Anthony and Dave, > > Than

Re: [pgAdmin4][Patch]: RM #3458 Error when using python 3.7

2018-08-02 Thread Akshay Joshi
Subject edited. On Thu, Aug 2, 2018 at 1:33 PM, Akshay Joshi wrote: > Hi Hackers, > > Attached is the patch to fix the RM #3458 Error when using python 3.7. > Please review it. > > Issues with Python 3.7: > >- "*async*" is a keyword in Python 3.7. psycopg2 has renamed "*async*" >to "*asy

[pgAdmin4][Patch]: RM #3458 Error when using python 3.7 Changed in version 3.7: Enable PEP 479 for all code by default: a StopIteration error raised in a generator is transformed into a RuntimeError.

2018-08-02 Thread Akshay Joshi
Hi Hackers, Attached is the patch to fix the RM #3458 Error when using python 3.7. Please review it. Issues with Python 3.7: - "*async*" is a keyword in Python 3.7. psycopg2 has renamed "*async*" to "*async_*", similarly I have renamed from "*async*" to "*async_*" for all the occurrence

Re: [pgAdmin4][RM2136] Include "?" on all routes that are loaded

2018-08-02 Thread Aditya Toshniwal
Hi Hackers, Attached is the updated patch and includes changes suggested by Khushboo. On Wed, Aug 1, 2018 at 12:22 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Aditya, > > - Some of the svg files (connect.svg, disconnect.svg in Query Tool) are > left. > The problem is with