Re: [GSoC] Query History Upgrade
Hi Yosry,
On Mon, Aug 12, 2019 at 2:00 PM Yosry Muhammad wrote:
> Hi Aditya,
>
> On Mon, Aug 12, 2019 at 9:04 AM Aditya Toshniwal <
> aditya.toshni...@enterprisedb.com> wrote:
>
>> Hi Yosry,
>>
>> Nice work there. It seems to be working fine except a few suggestions:
>> 1) Fix pep8 issues
>> 2) DOM Statements like below can be avoided and html can be added
>> directly to main template of $el instead of adding extra operations of
>> find, prepend and append. Plus, it makes it difficult to understand what
>> will the DOM look like.
>> this.$el.find('.query').prepend('> class="query-history-icon sql-icon-lg">');
>> $container.append($toggleEl).append(self.$el);
>> 3) Change the below to use class d-none with toggleClass('d-none') for
>> consistency across.
>> this.$el.find('.pgadmin-query-history-entry').each(function() {
>> $(this).toggle();
>> });
>>
>
> Please find an updated patch attached with the above issues fixed. The
> pep8 issue was in the test, I didn't re-check pep8 after writing the test -
> my bad.
>
>
>> 4) I may be wrong, but I'm seeing the flash icon for view/edit data
>> queries and view table icon for query tool queries. Looks like they are
>> swapped.
>> [image: Screenshot 2019-08-12 at 12.15.18.png]
>>
>>
>>
> They seem to be in the right place for me, would you mind rechecking?
>
Now there are showing fine.
However, the feature test case is failing for me. I tried 2 times:
=Running the test cases for 'PostgreSQL 11'=
runTest (pgadmin.feature_tests.query_tool_journey_test.QueryToolJourneyTest)
Tests the path through the query tool ... Copy rows... OK.
Copy columns... OK.
History tab... OK.
Updatable resultsets...FAIL
==
FAIL: runTest
(pgadmin.feature_tests.query_tool_journey_test.QueryToolJourneyTest)
Tests the path through the query tool
--
Traceback (most recent call last):
File
"/Users/adityatoshniwal/projects/pgadmin4/web/pgadmin/feature_tests/query_tool_journey_test.py",
line 79, in runTest
self._test_updatable_resultset()
File
"/Users/adityatoshniwal/projects/pgadmin4/web/pgadmin/feature_tests/query_tool_journey_test.py",
line 240, in _test_updatable_resultset
self._check_query_results_editable(query, False)
File
"/Users/adityatoshniwal/projects/pgadmin4/web/pgadmin/feature_tests/query_tool_journey_test.py",
line 378, in _check_query_results_editable
is_editable = self._check_cell_editable(1)
File
"/Users/adityatoshniwal/projects/pgadmin4/web/pgadmin/feature_tests/query_tool_journey_test.py",
line 395, in _check_cell_editable
self.assertFalse('editable' in cell_classes)
AssertionError: True is not false
--
Ran 1 test in 38.118s
FAILED (failures=1)
>
> Thanks !
>
> --
> *Yosry Muhammad Yosry*
>
> Computer Engineering student,
> The Faculty of Engineering,
> Cairo University (2021).
> Class representative of CMP 2021.
> https://www.linkedin.com/in/yosrym93/
>
--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"
pgAdmin 4 commit: Fix PEP8 issue
Fix PEP8 issue Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4403f326e9979b6ca7ca8cd4671b71785e1d41a3 Modified Files -- web/pgadmin/browser/server_groups/servers/databases/schemas/utils.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
pgAdmin 4 commit: Fix generation of reverse engineered SQL for Rules. F
Fix generation of reverse engineered SQL for Rules. Fixes #4586 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=35bbee3023d3559940f84fafb33cb13429eb3b15 Modified Files -- docs/en_US/images/rule_commands.png| Bin 0 -> 54824 bytes docs/en_US/images/rule_condition.png | Bin 0 -> 63522 bytes docs/en_US/images/rule_definition.png | Bin 29627 -> 39301 bytes docs/en_US/images/rule_general.png | Bin 24193 -> 42906 bytes docs/en_US/images/rule_sql.png | Bin 33615 -> 126430 bytes docs/en_US/release_notes_4_12.rst | 3 ++- docs/en_US/rule_dialog.rst | 24 +++-- .../schemas/tables/rules/static/js/rule.js | 10 + .../servers/databases/schemas/utils.py | 2 +- 9 files changed, 27 insertions(+), 12 deletions(-)
pgAdmin 4 commit: Fix issue in drag drop feature. It's regression of RM
Fix issue in drag drop feature. It's regression of RM #4552 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a51de7829229fe03719fabac824d110ea0a95f0a Author: Aditya Toshniwal Modified Files -- web/pgadmin/tools/sqleditor/static/js/sqleditor.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Re: [pgAdmin][RM4552] Dragging the selected text in SQL editor throws console errors
Thanks patch applied. On Mon, Aug 12, 2019 at 12:22 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > This seemed to have disabled the drag drop feature. Attached is a minor > fix to reenable it. > > On Fri, Aug 2, 2019 at 3:59 PM Dave Page wrote: > >> Thanks, patch applied. >> >> On Fri, Aug 2, 2019 at 6:25 AM Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Attached is the patch to fix the issue where dragging a selected text in >>> SQL editor throws console errors and does not move the text. >>> >>> As an improvement, the patch also fixes a potential issue where >>> importing jquery.event.drag will override drag events and will break drag >>> and drop feature. Currently jquery.event.drag is not imported. Changes are >>> made to use vanilla addEventListener instead of jquery on() to attach drag >>> related events to avoid conflict. >>> >>> Kindly review. >>> >>> -- >>> Thanks and Regards, >>> Aditya Toshniwal >>> Software Engineer | EnterpriseDB India | Pune >>> "Don't Complain about Heat, Plant a TREE" >>> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
Re: [GSoC] Query History Upgrade
Hi Yosry,
Nice work there. It seems to be working fine except a few suggestions:
1) Fix pep8 issues
2) DOM Statements like below can be avoided and html can be added directly
to main template of $el instead of adding extra operations of find, prepend
and append. Plus, it makes it difficult to understand what will the DOM
look like.
this.$el.find('.query').prepend('');
$container.append($toggleEl).append(self.$el);
3) Change the below to use class d-none with toggleClass('d-none') for
consistency across.
this.$el.find('.pgadmin-query-history-entry').each(function() {
$(this).toggle();
});
4) I may be wrong, but I'm seeing the flash icon for view/edit data queries
and view table icon for query tool queries. Looks like they are swapped.
[image: Screenshot 2019-08-12 at 12.15.18.png]
On Sun, Aug 11, 2019 at 11:58 AM Yosry Muhammad wrote:
> Hi Hackers,
>
> Please find attached a patch including new features for the Query History
> as follows:
>
> - Integration with updatable resultsets: Queries generated by pgAdmin
> during Save Data operations are now shown in the history panel, including
> transaction control queries.
> - Source indication: The source of each query in the history panel is
> indicated using an icon corresponding to the toolbar (Save Data, Execute,
> Explain, Commit, Rollback & View/Edit).
> - Allow showing/hiding queries generated internally by pgAdmin using a
> toggle button.
> - Some refactoring in save_data_changes.py
>
> The patch includes the code for the feature, added feature tests and
> documentation updates.
> Please review !
>
> Thanks. Regards.
>
> --
> *Yosry Muhammad Yosry*
>
> Computer Engineering student,
> The Faculty of Engineering,
> Cairo University (2021).
> Class representative of CMP 2021.
> https://www.linkedin.com/in/yosrym93/
>
--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"
Re: [pgAdmin][RM4552] Dragging the selected text in SQL editor throws console errors
Hi Hackers, This seemed to have disabled the drag drop feature. Attached is a minor fix to reenable it. On Fri, Aug 2, 2019 at 3:59 PM Dave Page wrote: > Thanks, patch applied. > > On Fri, Aug 2, 2019 at 6:25 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch to fix the issue where dragging a selected text in >> SQL editor throws console errors and does not move the text. >> >> As an improvement, the patch also fixes a potential issue where importing >> jquery.event.drag will override drag events and will break drag and drop >> feature. Currently jquery.event.drag is not imported. Changes are made to >> use vanilla addEventListener instead of jquery on() to attach drag related >> events to avoid conflict. >> >> Kindly review. >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> Software Engineer | EnterpriseDB India | Pune >> "Don't Complain about Heat, Plant a TREE" >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE" RM4552.part2.patch Description: Binary data
Re: [pgAdmin][RM4582] pgAgent - In create job step changing "kind" (SQL/Batch) throws console error
Thanks patch applied. On Mon, Aug 12, 2019 at 11:27 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to update the docs for pgAgent to clarify on > SQL/Batch kind. > Also a minor css fix in docs. > Kindly review. > > On Thu, Aug 8, 2019 at 6:44 PM Akshay Joshi > wrote: > >> Thanks patch applied. >> >> On Thu, Aug 8, 2019 at 4:40 PM Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Attached is the patch to fix console error in create step under pgAgent. >>> Code is changed to use bootstrapToggle instead of bootstrapSwitch. >>> >>> -- >>> Thanks and Regards, >>> Aditya Toshniwal >>> Software Engineer | EnterpriseDB India | Pune >>> "Don't Complain about Heat, Plant a TREE" >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >> *EnterpriseDB Software India Private Limited* >> *Mobile: +91 976-788-8246* >> > > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
pgAdmin 4 commit: Update the documentation for pgAgent to clarify Batch
Update the documentation for pgAgent to clarify Batch jobs won't run on remote servers. Fix minor css issue in docs. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a850e7bd5a0b4e074116dffaa8c3312056f557f6 Author: Aditya Toshniwal Modified Files -- docs/en_US/pgagent_jobs.rst| 3 +++ docs/en_US/theme/pgadmin4/static/style.css | 4 2 files changed, 7 insertions(+)
