Re: [pgAdmin][RM4764][Accessibility] Allow screen-reader to read relationship attributes in nested elements

2020-03-11 Thread Akshay Joshi
Thanks, patch applied. On Wed, Mar 11, 2020 at 2:43 PM Ganesh Jaybhay < ganesh.jayb...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch on top of initial patch for: > >- screen reader to read elements in radio modern control >- minor accessibility(aria-label) additions at

pgAdmin 4 commit: Fixed some accessibility issues:

2020-03-11 Thread Akshay Joshi
Fixed some accessibility issues: 1) Screen reader to read elements in radio modern control. 2) Aria-label additions at few missing places. 3) Radiocontrol to have different ids for each option. Branch -- master Details ---

pgAdmin 4 commit: Fixed chrome driver download utility issue for Ubuntu

2020-03-11 Thread Akshay Joshi
Fixed chrome driver download utility issue for Ubuntu. Fixes #4942 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7cc30e32168aefe2925631291b71ada457320619 Author: Murtuza Zabuawala Modified Files --

Re: [pgAdmin4][RM#4942] Fix chrome driver download utility for Ubuntu platform.

2020-03-11 Thread Akshay Joshi
Thanks, patch applied. On Wed, Mar 11, 2020 at 3:38 PM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to fix the issue with chrome driver download utility due to > which it was failing on Ubuntu 18.04 with following error. > > (venv3_pg)

[pgAdmin4][RM#4942] Fix chrome driver download utility for Ubuntu platform.

2020-03-11 Thread Murtuza Zabuawala
Hi, PFA patch to fix the issue with chrome driver download utility due to which it was failing on Ubuntu 18.04 with following error. (venv3_pg) murtuza@ubuntu:~/projects/pgadmin4/tools (master)$ python get_chromedriver.py /opt/google/chrome/chrome /tmp The specified Chrome executable output an

Re: [pgAdmin][RM4764][Accessibility] Allow screen-reader to read relationship attributes in nested elements

2020-03-11 Thread Ganesh Jaybhay
Hi Hackers, Attached is the patch on top of initial patch for: - screen reader to read elements in radio modern control - minor accessibility(aria-label) additions at few missing places - Radiocontrol to have different ids for each options Please review. Regards, Ganesh Jaybhay On