Translators: Release next week

2021-06-11 Thread Akshay Joshi
Hi Translators, We will have a release next week, so updates to translations before release would be helpful. The template and catalogs have been updated in git. *Note:* We will generally create the candidate build on Monday, so please send the translation file by Monday 5.00 PM IST would be

pgAdmin 4 commit: Disable browser password saving in the runtime. Fixes

2021-06-11 Thread Dave Page
Disable browser password saving in the runtime. Fixes #6473 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4a3a5174b2b0793cea0a2575c10814a784f5f0a1 Modified Files -- docs/en_US/release_notes_5_4.rst | 1 +

Re: [pgAdmin][RM6520]: pgAdmin4 v 5.3 text export error

2021-06-11 Thread Aditya Toshniwal
Hi Pradip, Just did a go through to your patch. The variable "data" which you've formed, will be computed for every row even though columns won't change. You should move it up and pass it to gen directly. This will save repeated computations. Secondly, it should not be named as data. It can be

pgAdmin 4 commit: Fixed an issue where a decimal number is appended for

2021-06-11 Thread Akshay Joshi
Fixed an issue where a decimal number is appended for character varying fields while downloading the data in CSV format. Fixes #6520 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e3190b86ab803b1deb3851df443f9e271a6058bb Author: Pradip

pgAdmin 4 commit: Update message catalogs.

2021-06-11 Thread Akshay Joshi
Update message catalogs. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b9b0a573e5fea0bbe39f7c5b3ad6bb2d9c6f0592 Modified Files -- web/pgadmin/messages.pot | 1833 ---

pgAdmin 4 commit: Fixed issues related to About dialog:

2021-06-11 Thread Akshay Joshi
Fixed issues related to About dialog: 1) On resizing, the server configuration text area should be resized. 2) Any password should not be visible in the configuration. 3) Configurations are not properly quoted. 4) Added the "Copy" button so that the user can copy the configuration directly. refs

[pgAdmin][RM6520]: pgAdmin4 v 5.3 text export error

2021-06-11 Thread Pradip Parkale
Hi Hackers, Please find the attached patch for #6520.Added check to typecast the numeric data while downloading the data in CSV format. -- Thanks & Regards, Pradip Parkale Software Engineer | EnterpriseDB Corporation RM6520.patch Description: Binary data

Re: [pgAdmin][RM-2341]: Add menu option for starting PSQL

2021-06-11 Thread Dave Page
Hi On Fri, Jun 11, 2021 at 1:45 PM Fahar Abbas wrote: > Hi Dave, > > On Fri, Jun 11, 2021 at 1:39 PM Dave Page wrote: > >> >> >> On Fri, Jun 11, 2021 at 9:35 AM Fahar Abbas >> wrote: >> >>> Sure Dave, I will create a new VM with the latest iso. >>> >> >> Not the latest. 1809 please. And if

Re: [pgAdmin][RM-2341]: Add menu option for starting PSQL

2021-06-11 Thread Fahar Abbas
Hi Dave, On Fri, Jun 11, 2021 at 1:39 PM Dave Page wrote: > > > On Fri, Jun 11, 2021 at 9:35 AM Fahar Abbas > wrote: > >> Sure Dave, I will create a new VM with the latest iso. >> > > Not the latest. 1809 please. And if that doesn't work, 1909. We need to > understand exactly what versions

pgAdmin 4 commit: 1) Fixed Selenoid test cases.

2021-06-11 Thread Akshay Joshi
1) Fixed Selenoid test cases. 2) Fixed RESQL test case failing on Jenkins. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0dbfbd8dfc3a7e2a4f89383ad3ac583fdf2e9c35 Modified Files -- .../schemas/tables/tests/pg/10_plus/test.json

Re: [pgAdmin][RM-2341]: Add menu option for starting PSQL

2021-06-11 Thread Fahar Abbas
Sure Dave, I will update you soon. On Fri, Jun 11, 2021 at 1:39 PM Dave Page wrote: > > > On Fri, Jun 11, 2021 at 9:35 AM Fahar Abbas > wrote: > >> Sure Dave, I will create a new VM with the latest iso. >> > > Not the latest. 1809 please. And if that doesn't work, 1909. We need to > understand

Re: [pgAdmin][RM-2341]: Add menu option for starting PSQL

2021-06-11 Thread Dave Page
On Fri, Jun 11, 2021 at 9:35 AM Fahar Abbas wrote: > Sure Dave, I will create a new VM with the latest iso. > Not the latest. 1809 please. And if that doesn't work, 1909. We need to understand exactly what versions work and which don't. > Nikhil is not able to reproduce the issue on Windows

Re: [pgAdmin][RM-2341]: Add menu option for starting PSQL

2021-06-11 Thread Dave Page
On Fri, Jun 11, 2021 at 9:25 AM Fahar Abbas wrote: > Windows 10 Enterprise 2016 LTSB. > Hmm, I assume that is version 1607. Can you test with 1809 please? And if that doesn't work, try 1909. > > On Fri, Jun 11, 2021 at 1:12 PM Dave Page wrote: > >> Hi >> >> On Fri, Jun 11, 2021 at 7:44 AM

Re: [pgAdmin][RM-2341]: Add menu option for starting PSQL

2021-06-11 Thread Fahar Abbas
Windows 10 Enterprise 2016 LTSB. On Fri, Jun 11, 2021 at 1:12 PM Dave Page wrote: > Hi > > On Fri, Jun 11, 2021 at 7:44 AM Fahar Abbas > wrote: > >> Hi, >> >> pgadmin4 is failing on following operating systems : >> Windows 2016 >> Windows 2012 >> Windows 07 >> Windows 2008R2 >> Windows 10 64

Re: [pgAdmin][RM-2341]: Add menu option for starting PSQL

2021-06-11 Thread Dave Page
Hi On Fri, Jun 11, 2021 at 7:44 AM Fahar Abbas wrote: > Hi, > > pgadmin4 is failing on following operating systems : > Windows 2016 > Windows 2012 > Windows 07 > Windows 2008R2 > Windows 10 64 > What version of Windows 10? I *think* conpty was introduced in 1809. > > pgadmin4 is working fine

Re: [pgAdmin][RM-2341]: Add menu option for starting PSQL

2021-06-11 Thread Fahar Abbas
Hi, pgadmin4 is failing on following operating systems : Windows 2016 Windows 2012 Windows 07 Windows 2008R2 Windows 10 64 pgadmin4 is working fine in following operating system: Windows 2019 On Thu, Jun 10, 2021 at 7:51 PM Dave Page wrote: > > > On Thu, Jun 10, 2021 at 2:22 PM Nikhil Mohite