Re: [pgAdmin4][Patch]: RM 3284 - F5 key not working consistently

2018-05-01 Thread Akshay Joshi
Thanks patch applied. On Wed, May 2, 2018 at 11:16 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Akshay, > > Please find the attached patch which fixes the linter issues. > > Thanks, > Khushboo > > On Wed, May 2, 2018 at 11:10

Re: [pgAdmin4][Patch]: Fixed RMs #1220 & #1221

2018-05-02 Thread Akshay Joshi
re > jobs are failing. > To fix these, we will display the error message regarding inappropriate > database name. > > Thanks, > Khushboo > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

Re: [pgAdmin4][Patch] Feature #1447 SSH Tunnel

2018-05-02 Thread Akshay Joshi
H Tunnel) on hold. We can create a separate task for this as we have for utility(Backup, Maintenance, Restore) modules. @Dave your thoughts on this? > > Sincerely, > > Victoria & Joao > > > On Wed, May 2, 2018 at 5:58 AM, Akshay Joshi < > akshay.jo...@enterpri

Re: [pgAdmin4][Patch] Feature #1447 SSH Tunnel

2018-05-03 Thread Akshay Joshi
Hi On Thu, May 3, 2018 at 2:20 PM, Dave Page wrote: > > > On Thu, May 3, 2018 at 6:58 AM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi >> >> On Wed, May 2, 2018 at 9:05 PM, Victoria Henry wrote: >> >>> Hi Akshay, >>

Re: [pgAdmin4][Patch] Feature #3270 Add support for running regression tests against Firefox

2018-05-07 Thread Akshay Joshi
r. Only two test cases are failing on my machine and I am not able to fix those. Please someone look into it and help me out. > Anthony > ​ > > > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* RM_3270_v5.patch Description: Binary data

Re: [pgAdmin4][Patch]: Fixed RMs #1220 & #1221

2018-05-07 Thread Akshay Joshi
10:19 AM, Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> >>> >>> On Wed, May 2, 2018 at 5:56 PM, Akshay Joshi < >>> akshay.jo...@enterprisedb.com> wrote: >>> >>>> Hi Khushboo >>>>

pgAdmin 4 commit: Backup, Maintenance and Restore should not be started

2018-05-07 Thread Akshay Joshi
Backup, Maintenance and Restore should not be started if database name contains "=" symbol. Fixes #1220 #1221 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=567f7642348e15d8adb57d683c64e8d8090b77fe Author: Khushboo Vashi Modified Files

pgAdmin 4 commit: Fixed layout of the alertify error message in the que

2018-05-07 Thread Akshay Joshi
Fixed layout of the alertify error message in the query tool. Fixes #3310 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3ac3e73daf8121207fe60eefe6db1aba9c1abcc3 Author: Khushboo Vashi Modified Files -- web/pgadmin/static/scss/_a

Re: [pgAdmin4][Patch]: Fix layout of the error message in the query tool

2018-05-07 Thread Akshay Joshi
Thanks patch applied. On Mon, May 7, 2018 at 12:53 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to fix the layout of the error message in > the query tool. (Ref RM #3310). > > Thanks, > Khushboo > --

Re: [pgAdmin4][Patch]: Fixed RMs #1220 & #1221

2018-05-08 Thread Akshay Joshi
On Tue, 8 May 2018, 13:35 Dave Page, wrote: > Could you update the 3.1 release notes to reflect that please? > Sure > > On Mon, May 7, 2018 at 10:40 AM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Thanks patch applied. >> >> On Mo

pgAdmin 4 commit: Updated release note for 3.1

2018-05-08 Thread Akshay Joshi
Updated release note for 3.1 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=39ea7c2916e699adc9de3e023ed63d64ab331936 Modified Files -- docs/en_US/release_notes_3_1.rst | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-)

Re: [pgAdmin4][Patch] Feature #3270 Add support for running regression tests against Firefox

2018-05-09 Thread Akshay Joshi
ch > run Chrome. Please look at this revised patch that accommodates for both > Chrome and Firefox with the wait_for_element_to_reload function. > >> -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* RM_3270_v9.patch Description: Binary data

pgAdmin 4 commit: Fixed query tool keyboard issue where arrow keys were

2018-05-09 Thread Akshay Joshi
Fixed query tool keyboard issue where arrow keys were not behaving as expected for execute options dropdown. Fixes #3298 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5b86a67a412b9d170ce3ce886adb5aa4f63388b1 Author: Aditya Toshniwal Modifi

Re: [pgAdmin4][RM#3298] Query tool shortcut issue

2018-05-09 Thread Akshay Joshi
Regards, >> Aditya Toshniwal >> Software Engineer | EnterpriseDB Software Solutions | Pune >> "Don't Complain about Heat, Plant a tree" >> > > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

[pgAdmin4][Patch]: RM #3277 Runtime startup error handling is broken on Windows.

2018-05-10 Thread Akshay Joshi
) *at line no 251 of pgAdmin4.cpp, which cause the application crash. I have removed that line and tested RM #3177 and RM# 3277, both are working fine. Please review and test it. -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* RM_3277.patc

Re: [pgAdmin4][Patch]: RM #3277 Runtime startup error handling is broken on Windows.

2018-05-10 Thread Akshay Joshi
Hi On Thu, May 10, 2018 at 7:38 PM, Dave Page wrote: > Hi > > On Thu, May 10, 2018 at 2:00 PM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Please find the attached patch to fix RM #3277 Runtime startup error >> handl

Re: [pgAdmin4][Patch] Feature #3270 Add support for running regression tests against Firefox

2018-05-11 Thread Akshay Joshi
Hi Dave On Thu, May 10, 2018 at 2:03 PM, Dave Page wrote: > Hi > > On Wed, May 9, 2018 at 2:55 PM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi >> >> On Wed, May 9, 2018 at 6:19 PM, Dave Page wrote: >> >>> H

Re: [pgAdmin4][Patch] Feature #3270 Add support for running regression tests against Firefox

2018-05-14 Thread Akshay Joshi
Hi Dave On which database server you are running this test cases, I have tested it on PG 9.6 On Mon, May 14, 2018 at 5:45 PM, Dave Page wrote: > > Hi > > On Mon, May 14, 2018 at 7:29 AM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Anthony >

Re: [pgAdmin4][Patch] Feature #3270 Add support for running regression tests against Firefox

2018-05-14 Thread Akshay Joshi
Hi Dave On Mon, May 14, 2018 at 6:33 PM, Dave Page wrote: > > > On Mon, May 14, 2018 at 2:03 PM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Dave >> >> On which database server you are running this test cases, I have tested >> it

[pgAdmin4][Patch] Feature #3204 Notify/Listen not working in version 2.1

2018-05-15 Thread Akshay Joshi
Hi Hackers, Attached is the patch to capture the notification from psycopg2 and displayed it in "Messages" tab of query tool. Added feature test to cover this scenario. Refer Notification.png file to how it looks in "Messages" tab. Please review it. -- *Akshay Joshi* *Sr

Re: [pgAdmin4][Patch] Feature #3204 Notify/Listen not working in version 2.1

2018-05-15 Thread Akshay Joshi
n(message, screen, stacktrace) > > <https://gpdb-dev.bosh.pivotalci.info/teams/pgadmin/pipelines/pgadmin-patch/jobs/run-tests/builds/77#L5ae79092:132> > TimeoutException: Message: Timed out waiting for element to exist > > > All the failures are related to query_tool_notif

Re: [pgAdmin4][Patch] Feature #3204 Notify/Listen not working in version 2.1

2018-05-16 Thread Akshay Joshi
Hi Hackers, On Tue, May 15, 2018 at 9:52 PM, Akshay Joshi wrote: > Hi Joao > > On Tue, 15 May 2018, 19:36 Joao De Almeida Pereira, < > jdealmeidapere...@pivotal.io> wrote: > >> Hi Akshay, >> >> This patch is flaky; it doesn&

pgAdmin 4 commit: Fixed issue where 'Identity file' control of SSH Tunn

2018-05-17 Thread Akshay Joshi
Fixed issue where 'Identity file' control of SSH Tunnel tab is enabled when database is connected and 'Use SSH tunneling' flag is set to No. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=719938a14c1b6bdae96aff82a2f6a02901a7ca8d Modified Fil

pgAdmin 4 commit: Correct the logic to set the SUPPORT_SSH_TUNNEL flag

2018-05-17 Thread Akshay Joshi
Correct the logic to set the SUPPORT_SSH_TUNNEL flag, if the flag is set the False in local config file, then we should not override it. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fb0c322ccf80ab9a3ff322af13e1f59e9baa8a82 Modified Files

pgAdmin 4 commit: Fixed pep8 issue for last commit.

2018-05-17 Thread Akshay Joshi
Fixed pep8 issue for last commit. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=28126a0a0dd242620df137a88f8b05e78c2c230c Modified Files -- web/config.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)

Re: [pgAdmin4][Patch] Feature #3204 Notify/Listen not working in version 2.1

2018-05-18 Thread Akshay Joshi
panel. > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

Re: [pgAdmin4][Patch] Feature #3204 Notify/Listen not working in version 2.1

2018-05-21 Thread Akshay Joshi
Hi Dave On Fri, May 18, 2018 at 4:56 PM, Dave Page wrote: > > > On Fri, May 18, 2018 at 12:11 PM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Dave >> >> On Fri, May 18, 2018 at 3:58 PM, Dave Page wrote: >> >>> Hi &

Re: [pgAdmin4][Patch] Feature #3204 Notify/Listen not working in version 2.1

2018-05-21 Thread Akshay Joshi
ct pg_notify('foo', 'Hello')' query (with payload). - Go to the query tool window from where 'LISTEN' was executed and run any other query. On Mon, May 21, 2018 at 1:36 PM, Akshay Joshi wrote: > Hi Dave > > On Fri, May 18, 2018 at 4:56

Re: [pgAdmin4][Patch] Feature #3204 Notify/Listen not working in version 2.1

2018-05-22 Thread Akshay Joshi
Hi All Please ignore the previous patch. Attached is the latest one. On Tue, May 22, 2018 at 11:37 AM, Akshay Joshi < akshay.jo...@enterprisedb.com> wrote: > Hi Hackers, > > As per suggestion by Dave, I have modified the logic and now notifications > are popped up in ale

Re: [pgAdmin4][Patch] Feature #3204 Notify/Listen not working in version 2.1

2018-05-22 Thread Akshay Joshi
Hi Dave On Tue, May 22, 2018 at 2:02 PM, Dave Page wrote: > > > On Tue, May 22, 2018 at 9:13 AM, Dave Page wrote: > >> Hi >> >> On Tue, May 22, 2018 at 7:07 AM, Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Hi Hacker

Re: [pgAdmin4][Patch] Feature #3204 Notify/Listen not working in version 2.1

2018-05-26 Thread Akshay Joshi
ifications' in Query Tool where all the notify messages will be recorded with the timestamp and payload. Please review the latest patch. On Tue, May 22, 2018 at 2:43 PM, Dave Page wrote: > > > On Tue, May 22, 2018 at 10:01 AM, Akshay Joshi < > akshay.jo...@enterprisedb.com&g

Re: [pgAdmin4][Patch] Feature #3204 Notify/Listen not working in version 2.1

2018-05-27 Thread Akshay Joshi
nPlum database and don't know why it is failing. On Sat, May 26, 2018 at 5:47 PM, Akshay Joshi wrote: > Hi Hackers, > > As per suggestion by Dave and discussion with in the team, I have modified > the logic again. Following are the modifications: > >- Instead of waiting

[pgAdmin4][Patch] RM 3353 and 3357

2018-05-28 Thread Akshay Joshi
Hi Hackers, Attached is the patch to fix following RMs: - #3353 Correct messages should be displayed while rename the maintenance database. - #3357 User can not drop database on ssh tunnel connection Please review it. -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20

[pgAdmin4][Patch] RM #3355 User can not perform operation of backup,Backup all, Backup global and Maintenance DB with ssh tunneling

2018-05-29 Thread Akshay Joshi
Hi Hackers, Attached is the patch to fix RM #3355 User can not perform operation of backup, Backup all, Backup global and Maintenance DB with ssh tunneling. Please review it. -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* RM_3355_v1.patch

Re: [pgAdmin4][Patch] RM #3355 User can not perform operation of backup,Backup all, Backup global and Maintenance DB with ssh tunneling

2018-05-29 Thread Akshay Joshi
and the local bind port returned by SSH Tunnel module. Khushboo has send the patch where she wrote test cases for Utility module (not committed yet) and anyways we can't replicate the SSH Tunnelling scenario using test cases. > > Thanks > Anthony && Joao &

Re: [pgAdmin4][Patch] Feature #3204 Notify/Listen not working in version 2.1

2018-05-29 Thread Akshay Joshi
quot; which is more meaningful then the previous one. Attached is the modified patch. Please review it. > Thanks > Anthony && Joao > ​ > > On Mon, May 28, 2018 at 1:34 AM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Hakers, >> >>

[pgAdmin4][Patch] RM #3277 Runtime startup error handling is broken on Windows

2018-05-31 Thread Akshay Joshi
top of the function then why to open that again using *fdopen() **in the first call. * Tested the patch with Python 3.5 and 3.6, please review it. -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* RM_3277.patch Description: Binary data

pgAdmin 4 commit: Fixed ordering of changes in release note and added o

2018-05-31 Thread Akshay Joshi
Fixed ordering of changes in release note and added one missing entry. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=55232b0944b11b954b9611acf7add801736725a7 Modified Files -- docs/en_US/release_notes_3_1.rst | 9 + 1 file

[pgAdmin4][patch] Moved 'Notifications' tab before 'Query History' in Query Tool

2018-06-05 Thread Akshay Joshi
Hi Hackers, Attached is the minor patch to move 'Notifications' tab before "Query History" in Query Tool. -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* Move_Notifications_Tab.patch Description: Binary data

[pgadmin4][Patch]: Support for create multiple test classes in one test file

2018-06-12 Thread Akshay Joshi
implementation it will run the test cases for *TestZ* class. -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* multiple_class_support.patch Description: Binary data

[pgadmin4][Patch]: RM #3374 Code autocomplete is broken in pgadmin4 V 3.0

2018-06-13 Thread Akshay Joshi
Hi Hackers, Attached is the patch to fix RM #3374 Code auto complete is broken in pgadmin4 V 3.0. I'll create a new RM to merge latest *pgcli <https://github.com/dbcli/pgcli>* code used for SQL Auto complete in pgAdmin4. -- *Akshay Joshi* *Sr. Software Architect * *Phone:

[pgadmin4][Patch]: Feature #2686 Property to switch lower/upper case auto completion

2018-06-14 Thread Akshay Joshi
the second request in the RM to change the selected text to upper/lower case. For that I have added new keyboard shortcut "Toggle case of selected text" in preferences dialog. Default key is "Ctrl + Shift + u". Please review it. -- *Akshay Joshi* *Sr. Software Architect * *Phon

Re: [pgadmin4][Patch]: Feature #2686 Property to switch lower/upper case auto completion

2018-06-14 Thread Akshay Joshi
On Thu, Jun 14, 2018 at 1:14 PM, Dave Page wrote: > Hi > > On Thu, Jun 14, 2018 at 8:41 AM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch for the Feature #2686 Property to switch >> lower

[pgadmin4][Patch]: RM #3356 pgAdmin 4 does not include schema name in generated package SQL

2018-06-14 Thread Akshay Joshi
Hi Hackers, Attached is the patch for RM #3356 pgAdmin 4 does not include schema name in generated package SQL. Please review it. -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* RM_3356.patch Description: Binary data

[pgadmin4][Patch]: Remove extra space from create script for Procedures.

2018-06-14 Thread Akshay Joshi
Hi Hackers, Attached is the patch to remove extra space from create script for Procedures. Please review it. -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* Remove_Extra_Space_Procedure.patch Description: Binary data

[pgadmin4][Patch]: Feature #3388 Allow to set the connection timeout on the server properties dialog

2018-06-18 Thread Akshay Joshi
Hi Hackers, Attached is the patch for Feature #3388 Allow to set the connection timeout on the server properties dialog. Please review it. -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* RM_3388.patch Description: Binary data

[pgadmin4][Patch]: RM #3361 Create database dialog does not show template0 and template1 database in Template dropdown

2018-06-18 Thread Akshay Joshi
Hi Hackers, Attached is the patch for RM #3361 Create database dialog does not show template0 and template1 database in Template drop down. -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* RM_3361.patch Description: Binary data

[pgadmin4][Patch]: Feature #3273 Add ability to sort in the Select File window when opening a saved query

2018-06-20 Thread Akshay Joshi
nd tried couple of different ways of WebDriveWait, but didn't get success. Please review it. -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* RM_3273.patch Description: Binary data

Re: [pgadmin4][Patch]: Feature #3273 Add ability to sort in the Select File window when opening a saved query

2018-06-20 Thread Akshay Joshi
On Thu, Jun 21, 2018 at 6:20 AM, Dave Page wrote: > Hi > > On Wed, Jun 20, 2018 at 3:13 PM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch for Feature #3273 Add ability to sort in the Select >> Fi

[pgadmin4][Patch]: Fixed minor issue in auto discover server when entry is blank in the config file

2018-06-21 Thread Akshay Joshi
fix that. Please review it. -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* Auto_discover_exception.patch Description: Binary data

[pgadmin4][Patch]: RM #3423 Drop option is not available for the procedure

2018-06-21 Thread Akshay Joshi
Hi Hackers, Attached is the patch to fix RM #3423 Drop option is not available for the procedure. Please review it. -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* RM_3423.patch Description: Binary data

pgAdmin 4 commit: Fixed issue of detection of EPAS server 11 and above.

2018-06-21 Thread Akshay Joshi
Fixed issue of detection of EPAS server 11 and above. Version string is changed in EPAS 11 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=480fe6b9fccffe34f1e28ba0f1ffb4b557d6d8fa Modified Files -- web/pgadmin/browser/server_group

Re: [pgadmin4][Patch]: Feature #3273 Add ability to sort in the Select File window when opening a saved query

2018-06-21 Thread Akshay Joshi
On Thu, Jun 21, 2018 at 11:57 PM, Dave Page wrote: > Hi > > On Thu, Jun 21, 2018 at 6:27 AM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> >> >> On Thu, Jun 21, 2018 at 6:20 AM, Dave Page wrote: >> >>> Hi >>> &g

[pgadmin4][Patch]: PG/EPAS 11 fixes for functions, procedures and trigger functions

2018-06-22 Thread Akshay Joshi
, procedures and trigger function for EPAS 11. - Fixed issue to expand table for EPAS 9.6 and below due to change in backend support logic. I have run the regression test on PG/EPAS: 9.6, 10, 11. -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246

Re: [pgadmin4][Patch]: Feature #3273 Add ability to sort in the Select File window when opening a saved query

2018-06-25 Thread Akshay Joshi
On Mon, Jun 25, 2018 at 4:43 PM, Dave Page wrote: > Hi > > On Fri, Jun 22, 2018 at 6:39 AM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> >> >> On Thu, Jun 21, 2018 at 11:57 PM, Dave Page wrote: >> >>> Hi >>> &g

[pgadmin4][Patch]: Fixed RM 3442, 3443, 3444 Drop options not available.

2018-06-25 Thread Akshay Joshi
Hi Hackers, Attached is the patch to RM 3442, 3443 and 3444 related to Drop options not available for Collations, Packages, Synonyms, Rules, Check Constraint and Domain Constraints. This are regressions. Please review it. -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058

pgAdmin 4 commit: Updated extension upgrade message. Fixes #3445

2018-06-25 Thread Akshay Joshi
Updated extension upgrade message. Fixes #3445 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=08e4cdf2ac5c843e383e7cf1603c144d181517ce Modified Files -- web/pgadmin/tools/debugger/__init__.py | 2 +- 1 file changed, 1 insertion(+),

[pgAdmin4][Patch]: RM #3397 Add support for JIT stats in EXPLAIN output in PG11

2018-06-29 Thread Akshay Joshi
Hi Hackers, Attached is the patch to fix the RM #3397 Add support for JIT stats in EXPLAIN output in PG11. Please review it. -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* RM_3397.patch Description: Binary data

Re: [pgAdmin4][Patch]: RM #3397 Add support for JIT stats in EXPLAIN output in PG11

2018-06-29 Thread Akshay Joshi
Hi Dave On Fri, Jun 29, 2018 at 6:56 PM, Dave Page wrote: > Hi > > On Fri, Jun 29, 2018 at 9:55 AM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch to fix the RM #3397 Add support for JIT stats in >

Re: [pgAdmin4][Patch]: RM #3397 Add support for JIT stats in EXPLAIN output in PG11

2018-06-30 Thread Akshay Joshi
Hi Dave On Fri, Jun 29, 2018 at 7:45 PM, Dave Page wrote: > > > On Fri, Jun 29, 2018 at 3:12 PM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Dave >> >> On Fri, Jun 29, 2018 at 6:56 PM, Dave Page wrote: >> >>> Hi

Re: [pgAdmin4][Patch]: RM #3397 Add support for JIT stats in EXPLAIN output in PG11

2018-07-03 Thread Akshay Joshi
Hi Dave, On Mon, Jul 2, 2018 at 4:10 PM, Dave Page wrote: > Hi > > On Sat, Jun 30, 2018 at 9:15 AM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Dave >> >> On Fri, Jun 29, 2018 at 7:45 PM, Dave Page wrote: >> >>>

Re: [pgAdmin4][Patch]: RM #3397 Add support for JIT stats in EXPLAIN output in PG11

2018-07-03 Thread Akshay Joshi
Hi Dave, Please ignore the previous patch, I have made some more changes related to background colour on enabled/disabled state. Attached is the modified patch. Please review it. On Tue, Jul 3, 2018 at 12:35 PM, Akshay Joshi wrote: > Hi Dave, > > On Mon, Jul 2, 2018 at 4:10 PM,

Re: [pgAdmin4][Patch]: RM #3397 Add support for JIT stats in EXPLAIN output in PG11

2018-07-05 Thread Akshay Joshi
18 at 6:40 PM, Akshay Joshi wrote: > Hi Dave, > > Please ignore the previous patch, I have made some more changes related to > background colour on enabled/disabled state. > Attached is the modified patch. Please review it. > > On Tue, Jul 3, 2018 at 12:35 PM, Akshay Joshi &l

Re: [pgAdmin4][Patch]: RM #3397 Add support for JIT stats in EXPLAIN output in PG11

2018-07-05 Thread Akshay Joshi
led attribute and add ' *pointer-events: none*' for the statistics button. Attached is the patch please review it. > > On Thu, Jul 5, 2018 at 11:21 AM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Dave >> >> As per discussion attach

Re: Regarding RM #3316 Pgadmin4 No Tray Crash

2018-07-10 Thread Akshay Joshi
On Tue, 10 Jul 2018, 18:32 Dave Page, wrote: > Hi > > On Tue, Jul 10, 2018 at 11:20 AM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> I have implemented the fix for RM #3316 "Pgadmin4 No Tray Crash". I have &

Re: Regarding RM #3316 Pgadmin4 No Tray Crash

2018-07-11 Thread Akshay Joshi
Hi Dave On Wed, Jul 11, 2018 at 1:31 PM, Dave Page wrote: > > > On Wed, Jul 11, 2018 at 8:03 AM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi >> >> On Tue, Jul 10, 2018 at 9:16 PM, Dave Page wrote: >> >>> >>> &g

Re: Regarding RM #3316 Pgadmin4 No Tray Crash

2018-07-12 Thread Akshay Joshi
On Thu, Jul 12, 2018 at 9:38 PM, Dave Page wrote: > > > On Thu, Jul 12, 2018 at 4:40 PM, Dave Page wrote: > >> >> >> On Thu, Jul 12, 2018 at 11:17 AM, Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> >>> >>&g

Re: Regarding RM #3316 Pgadmin4 No Tray Crash

2018-07-12 Thread Akshay Joshi
Attached is the refactored patch. On Fri, Jul 13, 2018 at 11:19 AM, Akshay Joshi < akshay.jo...@enterprisedb.com> wrote: > > > On Thu, Jul 12, 2018 at 9:38 PM, Dave Page wrote: > >> >> >> On Thu, Jul 12, 2018 at 4:40 PM, Dave Page wrote: >> >>&g

[pgAdmin4][Patch]: RM #3446 plpgsql keyword should displayed in SQL pane for EPAS-11

2018-07-13 Thread Akshay Joshi
spl' language for EPAS). Fixed the issue where it is visible in properties panel if we create procedure using language 'plpgsql' or 'sql'. Attached patch contains the fix for all the above issues. Please review it. -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* RM_3446.patch Description: Binary data

[pgAdmin4][Patch]: RM #3448 copy command failure issue in pgAdmin

2018-07-16 Thread Akshay Joshi
Hi Hackers, Attached is the patch to fix RM #3448 copy command failure issue in pgAdmin. Please review it. -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* RM_3448.patch Description: Binary data

Re: [pgAdmin4][Patch] - RM #3309 - Backup does not work with --format=d

2018-07-17 Thread Akshay Joshi
;>>>> >>>>> >>>>> That's somewhat more readable. Can we add tests? >>>>> >>>> Will look into it. >>>> >>> >>> Added. >> >>> Thanks. >>> >>> >>>> >>>>> -- >>>>> Dave Page >>>>> Blog: http://pgsnake.blogspot.com >>>>> Twitter: @pgsnake >>>>> >>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>> The Enterprise PostgreSQL Company >>>>> >>>> >>> >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* RM_3309_Windows.patch Description: Binary data

Re: Regarding RM #3316 Pgadmin4 No Tray Crash

2018-07-17 Thread Akshay Joshi
> Thanks, patch applied. > > On Fri, Jul 13, 2018 at 7:10 AM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Attached is the refactored patch. >> >> On Fri, Jul 13, 2018 at 11:19 AM, Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote

Re: Regarding RM #3316 Pgadmin4 No Tray Crash

2018-07-17 Thread Akshay Joshi
On Tue, Jul 17, 2018 at 6:37 PM, Dave Page wrote: > > > On Tue, Jul 17, 2018 at 2:06 PM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Dave, >> >> I have changed the background colour on mouse hover for "pgAdmin4" menu. >>

pgAdmin 4 commit: Added keyboard shortcut for 'pgAdmin4' menu.

2018-07-17 Thread Akshay Joshi
Added keyboard shortcut for 'pgAdmin4' menu. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7f7feee8c1afb28ceb0a8d39273f2da4eb276a6a Modified Files -- runtime/FloatingWindow.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[pgAdmin4][Patch]: RM #3468 Cannot create server using SSH Tunnel tab when no passphrase identify file

2018-07-18 Thread Akshay Joshi
Hi Hackers, Attached is the patch to fix RM #3468 Cannot create server using SSH Tunnel tab when no passphrase identify file. Please review it. -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* RM_3468.patch Description: Binary data

[pgAdmin4][Patch]: RM #3471 SSH Tunnel doesn't use the port setting

2018-07-18 Thread Akshay Joshi
Hi Hackers, Attached is the patch to fix RM #3471 SSH Tunnel doesn't use the port setting. Please review it. -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* RM_3471.patch Description: Binary data

[pgAdmin4][Patch]: RM #2214 PostgreSQL 10.0 compatibility (SCRAM authentication support)

2018-07-23 Thread Akshay Joshi
latest code of psycopg2, compile it with libpq version 10 and implement the logic in pgAdmin4. Attached is the patch to fix that issue. Please review it. -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* RM_2214.patch Description: Binary data

Re: [pgAdmin4][Patch]: RM #2214 PostgreSQL 10.0 compatibility (SCRAM authentication support)

2018-07-23 Thread Akshay Joshi
On Mon, Jul 23, 2018 at 6:36 PM, Dave Page wrote: > Hi Akshay > > On Mon, Jul 23, 2018 at 2:03 PM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> A new password encryption method "*scram-sha-256*" has been introduce

Re: [pgAdmin4][Patch]: #3412 - Add support for PRIMARY KEY, FOREIGN KEY, indexes, and triggers on partitioned tables for PG 11

2018-07-25 Thread Akshay Joshi
tached patch for RM #3412. > > - Add support for PRIMARY KEY, FOREIGN KEY, indexes, and triggers on > partitioned tables for PG 11 > > - Add support for partitioning by HASH key. > > > Thanks, > Khushboo > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

pgAdmin 4 commit: Add support for reset saved password. Fixes #3074

2018-07-27 Thread Akshay Joshi
Add support for reset saved password. Fixes #3074 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0138dee989e5792f36f62eefcd37b7a6225779b3 Modified Files -- docs/en_US/images/file_menu.png| Bin 37186 -> 71639 by

pgAdmin 4 commit: Add support for primary key, foreign key, unique key,

2018-07-27 Thread Akshay Joshi
Add support for primary key, foreign key, unique key, indexes and triggers on partitioned tables for PG/EPAS 11. Fixes #3412 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0cb25bde63e6602f0f78c09a3954bf907008c099 Author: Khushboo Vashi Modi

Re: [pgAdmin4][Patch]: #3412 - Add support for PRIMARY KEY, FOREIGN KEY, indexes, and triggers on partitioned tables for PG 11

2018-07-27 Thread Akshay Joshi
; >> On Fri, Jul 27, 2018 at 2:27 PM, Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> Hi, >>> >>> Please find the attached updated patch with the fixes. I have also >>> considered the suggestions given by Aditya on diffe

[pgAdmin4][Patch]: RM #3458 Error when using python 3.7 Changed in version 3.7: Enable PEP 479 for all code by default: a StopIteration error raised in a generator is transformed into a RuntimeError.

2018-08-02 Thread Akshay Joshi
Python 2.7, Python 3.5 and Python3.7. Run regression test on PG/EPAS 11, PG/EPAS 9.6. Run feature test on PG 11. -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* RM_3458.patch Description: Binary data

Re: [pgAdmin4][Patch]: RM #3458 Error when using python 3.7

2018-08-02 Thread Akshay Joshi
Subject edited. On Thu, Aug 2, 2018 at 1:33 PM, Akshay Joshi wrote: > Hi Hackers, > > Attached is the patch to fix the RM #3458 Error when using python 3.7. > Please review it. > > Issues with Python 3.7: > >- "*async*" is a keyword in Python 3.7. psyc

pgAdmin 4 commit: View Data->Filtered Rows dialog should be displayed.

2018-08-02 Thread Akshay Joshi
View Data->Filtered Rows dialog should be displayed. Fixes #3527 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8f45e6fe684cd365537be9685d0b26c4789382b2 Modified Files -- docs/en_US/release_notes_3_2.rst | 3 ++- w

pgAdmin 4 commit: 1. Change the string from 'Reset server password" to

2018-08-03 Thread Akshay Joshi
1. Change the string from 'Reset server password" to "Clear Saved Password" and move this sub menu from File to Object menu. 2. Move the "Change Password..." menu from 'File' to 'Object' menu. RM #3074 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commit

pgAdmin 4 commit: COST statement should not be automatically duplicated

2018-08-05 Thread Akshay Joshi
COST statement should not be automatically duplicated after creating trigger function. Fixes #3526 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a17aa212f012f93e6acec644c53fa9f0dd774bdd Modified Files -- docs/en_US/release_notes

Re: [pgAdmin4][RM2136] Include "?" on all routes that are loaded

2018-08-06 Thread Akshay Joshi
t;> Test cases included. >>> >>> Kindly review. >>> >>> -- >>> Thanks and Regards, >>> Aditya Toshniwal >>> Software Engineer | EnterpriseDB Software Solutions | Pune >>> "Don't Complain about Heat, Plant a tree" >>> >> >> > > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB Software Solutions | Pune > "Don't Complain about Heat, Plant a tree" > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

pgAdmin 4 commit: Added version number for URL's to ensure that files a

2018-08-06 Thread Akshay Joshi
Added version number for URL's to ensure that files are only cached on a per-version basis. Fixes #2136. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=cb8a288f85a8d970c0e607c3d7998ec93de7370b Author: Aditya Toshniwal Modified Files ---

pgAdmin 4 commit: pgAdmin4 should work with python 3.7, Fixes #3458

2018-08-06 Thread Akshay Joshi
pgAdmin4 should work with python 3.7, Fixes #3458 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=52fc0846cdd16dd3c780c5d4277d3f71055506e8 Modified Files -- docs/en_US/release_notes_3_2.rst| 1 + web/pgadmin/too

Re: [pgAdmin4][Patch]: RM #3511 Passwords not stored for ssh tunnel connections

2018-08-06 Thread Akshay Joshi
urpose of the file instead of empty > message string. > - Please remove unwanted imports from the migration file. > - The success message should be 'The saved password cleared successfully.' > or 'Cleared the saved password successfully.' > > Thanks, > K

pgAdmin 4 commit: Add support to save and clear SSH Tunnel password. Fi

2018-08-06 Thread Akshay Joshi
Add support to save and clear SSH Tunnel password. Fixes #3511 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c8c5f83dfe198d6119780bb0ad2d1e29a8d02a22 Modified Files -- docs/en_US/clear_saved_passwords.rst | 6 ++ d

pgAdmin 4 commit: Update version and message catalog for release.

2018-08-06 Thread Akshay Joshi
Update version and message catalog for release. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7479467a5491528b125e17d1a8c7f81925ed2258 Modified Files -- docs/en_US/release_notes_3_2.rst |2 +- runtime/Info.pl

pgAdmin4 v3.2 candidate builds

2018-08-06 Thread Akshay Joshi
Hi All, pgAdmin4 v3.2 candidate builds and source can be found at https://developer.pgadmin.org/builds/2018-08-06%27/. Fahar, can you please verify it for release on Thursday. -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

[pgAdmin4][Patch]: RM #3407 Fix layout of keyboard shortcut preferences panels

2018-08-07 Thread Akshay Joshi
Hi Hackers, Attached is the patch to fix RM #3407 "Fix layout of keyboard shortcut preferences panels". Please review it. -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* RM_3407.patch Description: Binary data

[pgAdmin4][Patch]: RM #3528 Query Tool doesn't handle 'Too many connection' error properly

2018-08-08 Thread Akshay Joshi
Hi Hackers, Attached is the patch to fix RM #3528 "Query Tool doesn't handle 'Too many connection' error properly". Please review it. -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* RM_3528.patch Description: Binary data

pgAdmin 4 v3.2 released

2018-08-09 Thread Akshay Joshi
and DEB packages are expected to be available on the postgresql.org repositories within the next few days. -- Akshay Joshi pgAdmin Project

pgAdmin 4 commit: Tag REL-3_2 has been created.

2018-08-09 Thread Akshay Joshi
Tag REL-3_2 has been created. View: https://git.postgresql.org/gitweb?p=pgadmin4.git;a=tag;h=refs/tags/REL-3_2 Log Message --- Tag v3.2

[pgAdmin4][Patch]: RM #3461 Properties/SQL panel contents does not updates when user perform Refresh operation on the node

2018-08-13 Thread Akshay Joshi
Hi Hackers, Attached is the patch to fix RM #3461 "Properties/SQL panel contents does not updates when user perform Refresh operation on the node". Please review it. -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* RM_3461.patch D

[pgAdmin4][Patch]: Fixed issue where "Backup Globals" not working correctly

2018-08-16 Thread Akshay Joshi
Hi Hackers, Attached is the patch to fix issue where "Backup Globals" not working correctly. pg_dumpall utility runs without "--globals-only" flag even if user click on "Backup Globals" menu . Also correct the regression test case for it. -- *Akshay Joshi* *Sr.

<    1   2   3   4   5   6   7   8   9   10   >