Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

Hi Dave, PFA patch to display additional information from pg_stat_activity table using subnode control. RM#2597 Please review. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, Jul 25, 2017 at 10:56 AM, Shirley Wang <

Re: pgAdmin 4 commit: Fix test assertion.

to > drop downs. Happened a few weeks ago. > > Rob > > On Jul 31, 2017 6:51 PM, "Murtuza Zabuawala" <murtuza.zabuawala@ > enterprisedb.com> wrote: > > Hi All, > > When I run the feature tests, the gives test always fails ( > 'query_tool_journey_tes

Re: [pgAdmin4][Patch]: Dashboard requests don't stop even after closing the panel

Hi Ashesh, On Mon, Jul 31, 2017 at 4:50 PM, Ashesh Vashi wrote: > > > On Fri, Jul 28, 2017 at 4:00 PM, Dave Page wrote: > >> Ashesh, can you deal with this please? Thanks. >> > Hi Khushboo, > > I've committed the code. > But - I am not able to

[pgAdmin4][PATCH] To fix pgAgent job step issues

Hi, Please find attached patch to fix below given issues from pgAgent Jobs Steps module. 1) 'Connection Type' cell was not honouring to 'Kind' option in Subnode control. 2) Kind option was not saved properly 3) User was not be able to update Kind option in edit mode. RM#2633 -- Regards, Murtuza

Re: Can someone tell me what this code does ?

Hi, On Wed, Aug 9, 2017 at 8:19 PM, Dave Cramer <davecra...@gmail.com> wrote: > So what is the policy of the project? Ideally the cruft should be removed. > > Would a patch doing so be committed? > ​Yes, I guess.​ Dave Cramer > > On 9 August 2017 at 00:28, Murtuza Zabu

[pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

Hi, PFA patch which will add functionality to allow user to comment/uncomment code in query editor. RM#2456 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/docs/en_US/keyboard_shortcuts.rst b/docs/en_US

Re: Testing out font changes in query editor tool

Hi Shirley, It's easy on the eyes :) ~M On Thu, Jul 13, 2017 at 10:00 PM, Shirley Wang wrote: > Hello! > > We're trying out a new font in the query editor tool. Attached is a patch > that changes the font. > > We'd like to know how this change affects your experience working

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

Hi Dave, On Mon, Jul 17, 2017 at 2:33 PM, Dave Page <dp...@pgadmin.org> wrote: > Hi > > On Wed, Jul 12, 2017 at 1:16 PM, Murtuza Zabuawala <murtuza.zabuawala@ > enterprisedb.com> wrote: > >> Hi, >> >> PFA patch which will add functionality to all

Re: [pgAdmin4][Patch] To fix the issue in privileges control

Hi, Please find updated patch. On Tue, Jul 11, 2017 at 4:52 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Please disregard previous patch, I'll send updated patch as I found one > issue. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB:

Re: pgAdmin 4 commit: Fix IE11 alert layout again.

lert message and layout becomes kind of square shape. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Jul 10, 2017 at 6:19 PM, Dave Page <dp...@pgadmin.org> wrote: > Fix IE11 alert layout again. > > Branch > -

[pgAdmin4][Patch] Not to display PID comma separated in statistics panel

Hi, PFA minor patch to fix the issue where PID column was displaying comma separated in statistics panel. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/misc/statistics/static/js/statistics.js b/web/pgadmin/misc

Re: [pgAdmin4]: Webpacking of static JS/CSS

Great job Surinder, Load time ~2 sec on browser :) [image: Inline image 1] -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, Jul 18, 2017 at 9:01 PM, Dave Page <dp...@pgadmin.org> wrote: > Thanks, applied. > >

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

On Thu, Jul 20, 2017 at 10:29 PM, Dave Page <dp...@pgadmin.org> wrote: > Hi > > On Thu, Jul 20, 2017 at 3:33 PM, Murtuza Zabuawala <murtuza.zabuawala@ > enterprisedb.com> wrote: > >> Hi Dave, >> >> Please find patch attached, There were two issues,

Re: Unified server/desktop config

Hi Dave, Partial patch for feature test got included in you patch :) On Thu, Jul 20, 2017 at 9:33 PM, Dave Page wrote: > All, > > Attached is a patch that aims to allow us to have a standardised config > that will work out of the box for both web and desktop modes. It does

Re: Unified server/desktop config

Oops sorry my bad, I did not removed it. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Jul 20, 2017 at 10:22 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > Partial patch for f

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

Just a FYI, You need to run yarn bundle for this to be working as Surinder has moved all the CodeMirror code into bundle package. On Wed, Jul 19, 2017 at 2:20 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA updated patch, > 1) Added Keyboard sh

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

Hi Dave, Please find updated patch. On Thu, Jul 20, 2017 at 10:35 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > > On Thu, Jul 20, 2017 at 10:29 PM, Dave Page <dp...@pgadmin.org> wrote: > >> Hi >> >> On Thu, Jul 20, 2017 at 3:33 PM

[pgAdmin4][Patch]: Handle WSGI Alias while generating URL for endpoints.js

the endpoints and their respective url's. Please review. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/__init__.py b/web/pgadmin/__init__.py index 49c4fdd..0ca1c58 100644 --- a/web/pgadmin/__init__.py +++ b/web/pgadmin

Re: Build failed in Jenkins: pgadmin4-master-python26 #386

Looking into it. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Jul 26, 2017 at 5:28 PM, pgAdmin 4 Jenkins <jenk...@pgadmin.org> wrote: > See <https://jenkins.pgadmin.org/job/pgadmin4-master-python26/ > 386/displa

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

Hi Dave, Please find updated patch for new shortcut keys, I have tested it on all three major platforms (macOS, Linux & Windows with Chrome, FF & IE11 Browsers). -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Jul 21, 2

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

ok of those buttons though, so if anyone > has a better idea how they should be styled, please yelp (CCing Chethana > for his input as well)... > > > > On Wed, Jul 19, 2017 at 9:56 AM, Murtuza Zabuawala <murtuza.zabuawala@ > enterprisedb.com> wrote: > >> Just

Re: [pgAdmin4][Patch]: Allow user to Comment/Uncomment code in query editor

Sure, Will take a look. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Jul 19, 2017 at 8:00 PM, Dave Page <dp...@pgadmin.org> wrote: > Except I managed to break a couple of tests :-(. Can you take a look > please? I

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

tab? > I think around 2-3 days would be needed. > > On Mon, Jul 24, 2017 at 11:45 AM, Murtuza Zabuawala <murtuza.zabuawala@ > enterprisedb.com> wrote: > >> Hi Dave, >> >> Please find updated patch. >> >> On Tue, Jul 18, 2017 at 8:05 PM, Murtuza Zab

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

Sure. RM created: https://redmine.postgresql.org/issues/2597. On Mon, Jul 24, 2017 at 6:04 PM, Dave Page <dp...@pgadmin.org> wrote: > > > On Mon, Jul 24, 2017 at 1:12 PM, Murtuza Zabuawala <murtuza.zabuawala@ > enterprisedb.com> wrote: > >> Hi Dave, >> &

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

Hi Dave, Please find updated patch. On Tue, Jul 18, 2017 at 8:05 PM, Murtuza Zabuawala <murtuza.zabuawala@ enterprisedb.com> wrote: > Hi Shirley, > > On Tue, Jul 18, 2017 at 1:21 AM, Shirley Wang <sw...@pivotal.io> wrote: > >> Hi! >> >> I can't seem

[pgAdmin4][Patch] To fix the issues in Debugger module

we find the solution for this issue. Misc changes are for PEP-8. Please review. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/tools/debugger/__init__.py b/web/pgadmin/tools/debugger/__init__.py index 8cebffc

Re: [pgAdmin4][Patch]: Refactor of the History Tab

Hi, On Fri, Jun 30, 2017 at 10:30 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > ​Hi, > > Review comments: > > 1) I see the font used for class .query-history .entry​ is monospace, > shouldn't it be Helvetica as per style guide ? the font for Messages > text > is also monospace.

[pgAdmin4][Patch] To fix the duplicate entry in History panel

Hi, PFA minor patch to fix the issue where duplicate entry is made of successful executed query one with status message and one without status message. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/tools

[pgAdmin4][Patch] To fix the issue in Debugger & Procedure module for EPAS server

Hi, PFA patch to fix the issue where 'Debug' option was not displaying on Package -> Function if the user if non-super user. RM#1948 Another minor issue where there was a whitespace on SQL panel while displaying reversed engineering sql for Procedure. RM#2146 -- Regards, Murtuza Zabuaw

[pgAdmin4][Patch] To fix the issue in Function, Procedure & Trigger Function modules

Hi, PFA patch to fix the issue in Function, Procedure & Trigger Function modules where user was not able to update object if user changes the code definition. RM#2537 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a

Re: [pgAdmin4][Patch] To fix the issue in Function, Procedure & Trigger Function modules

Hi Dave, This behaviour is from beginning I think and it is inherited from pgAdmin3. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Jul 6, 2017 at 5:58 PM, Dave Page <dp...@pgadmin.org> wrote: > Hi > > On Thu, Ju

Re: [pgAdmin4][Patch] To add preferences for brace matching and auto brace closing

Sure Dave, I'll do the needful. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, Jun 27, 2017 at 7:29 PM, Dave Page <dp...@pgadmin.org> wrote: > Thanks - patch applied with some minor tweaks to enable both options by

[pgAdmin4][Patch]: Allow user to delete Tab via Shift-Tab in query editor

Hi, PFA minor patch which will add functionality to allow user to delete Tab(s) using Shift-Tab keys. RM#1988 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/templates/browser/js/browser.js b/web/pgadmin

Re: [pgAdmin4][PATCH] To fix the add New Server through Quick links on Dashboard

Hi, PFA updated patch for the same. Thanks Surinder for pointing that out, I assumed that we had a typo in that file. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company [image: https://community.postgresrocks.net/] <ht

Re: [pgAdmin4][Patch][RM_2567] : Default privileges don't show on Properties tab for database.

Hi Atul, Better solution to solve this issue is to use self.conn instead of creating new conn using did, we already checking for "datallowconn" flag in check_precondition decorator. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Compa

Re: [pgAdmin4][Patch][RM_2567] : Default privileges don't show on Properties tab for database.

Hi Atul, The given patch breaks RM#1801 <https://redmine.postgresql.org/issues/1801>. After applying the patch, Now I'm not able to see the properties of a database of which "datallowconn" is set to False. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.co

Re: Can someone tell me what this code does ?

Hi, This piece of code allow us to dynamically import all the available driver modules from '../utils/driver/' directory into our application. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company [image: https://community.postgresrocks.net

[pgAdmin4][PATCH] To fix the add New Server through Quick links on Dashboard

Hi, PFA minor patch to fix the issue where add new server functionality through Quick link on Dashboard is broken. RM#2634 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company [image: https://community.postgresrocks.net/] <ht

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

because it will break the subnode control consistency, If user sees that grid expands on clicking the row they will expect the same behaviour in other grids as well. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company [image: https

[pgAdmin4][Patch]: To fix Collation tests

mmunity regarding "POSIX" collation issue on Windows. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/collations/tests/test_collation_add.py b/web/pgadmin/brows

Re: Error using pgadmin4 HEAD

sitory, Another way is to download and use the source which is already bundled from here <https://www.pgadmin.org/download/pgadmin-4-source-code/> -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Sat, Jul 29, 2017 at 2:27 AM,

Re: [pgAdmin4][Patch][RM_2567] : Default privileges don't show on Properties tab for database.

Patch looks good to me. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company [image: https://community.postgresrocks.net/] <https://community.postgresrocks.net/> On Tue, Aug 8, 2017 at 3:25 PM, Atul Sharma <atul.sha...@enterprisedb.c

Re: [pgAdmin4][PATCH] Refactor and change of implementation of keyboard_shortcuts function dependencies

Hi Wenlin, Patch looks good to me. I'm also attaching minor patch to update document for new keyboard shortcuts. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company [image: https://community.postgresrocks.net/] <ht

Re: pgAdmin4 - Tree view icons for final reveiw

Hi Chethana, On Wed, Aug 23, 2017 at 12:51 PM, Chethana Kumar < chethana.ku...@enterprisedb.com> wrote: > Hi Murtuza, > > Please see my reply inline along with the updated .svg file for tree view > icons. > > > On Tue, Aug 22, 2017 at 11:17 AM, Murtuza Z

[pgAdmin4][PATCH] Fix trigger's reversed engineered SQL for View

Hi, PFA minor patch to fix the issue where view is not fully qualified in Trigger definition. RM#2560 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company [image: https://community.postgresrocks.net/] <https://community.postgresrocks.

[pgAdmin4][PATCH] Fix clicking on the "pgAdmin 4" header logo shows a empty dialog

Hi, PFA minor patch to fix the issue, where user will get empty dialog in desktop mode if user clicks on pgadmin4 header logo. pgAdmin4 is already a SPA so in my opinion we don't require route to to home page. RM#2479 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com

[pgAdmin4][PATCH] To fix the issue in column module

Hi, PFA patch to fix the issue where in column node we were not displaying column's default value properly, for example if the default value is zero. RM#1860 I have also fixed similar issue in foreign table module. Please review. -- Regards, Murtuza Zabuawala EnterpriseDB: http

[pgAdmin4][Patch] To fix the issue in Column module

Hi, PFA patch to fix the issue in Column module where clearing the length of a character(or any other type as well) generates empty SQL. RM#2155 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser

Re: [pgadmin-hackers][patch] History Detail Pane

On Fri, Jun 23, 2017 at 11:24 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi > > Review comments: > > ​1. ​ > Can we set "message"(in message detail) style property scroll to > ​'​ > auto > ​'​ > instead of > ​'​ > scroll > ​'​ > ? > > ​2. ​ > CSS property flex is supported for

Re: [pgAdmin4][Patch] To fix the issue in Debugger module

Hi Dave, Please find updated patch. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Jun 23, 2017 at 2:38 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Yes, I'm looking into it, I will send upda

Re: [pgAdmin4][Patch]: Fix context menu fontawesome icons

Hi Dave, On Fri, Sep 15, 2017 at 6:26 PM, Dave Page <dp...@pgadmin.org> wrote: > Hi > > On Fri, Sep 15, 2017 at 8:52 AM, Murtuza Zabuawala <murtuza.zabuawala@ > enterprisedb.com> wrote: > >> Hi Ashesh, >> >> PFA minor patch to fix the font-aweso

Re: [pgAdmin4][Patch]: Fix context menu fontawesome icons

On Fri, Sep 15, 2017 at 7:16 PM, Dave Page <dp...@pgadmin.org> wrote: > > > On Fri, Sep 15, 2017 at 2:19 PM, Murtuza Zabuawala < > murtuza.zabuaw...@enterprisedb.com> wrote: > >> Hi Dave, >> >> On Fri, Sep 15, 2017 at 6:26 PM, Dave Page <dp...@pgad

Re: pgAdmin 4 commit: Bundle fonts with pgAdmin so we have a standard set f

Hi Atul, I think we still missed alertify header fonts :) Check screenshot. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company [image: https://community.postgresrocks.net/] <https://community.postgresrocks.net/> On Fri, Sep 15, 201

Re: pgAdmin 4 commit: Bundle fonts with pgAdmin so we have a standard set f

Oops Sorry, after clearing the cache 2nd time, it is working fine now. On Thu, Sep 14, 2017 at 6:56 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > After latest pull fonts from context menu looks different, PFA screenshot. > I tried on macO

[pgAdmin4][Patch]: pgAdmin4 not displaying schema if it start with 'pg'

Hi, PFA patch to fix the issue where pgAdmin4 is not displaying the schema if it starts with 'pg', for example if schema name is 'pgabc' then it won't display it under browser tree. RM#2709 Please review. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise

[pgAdmin4][Patch]: Fix context menu fontawesome icons

s;h=b6d50eb274ee1b7e05bf4b195407ca8ae9b03097;hp=f4d21b338691c69d055cfa9820f8fd1037afbd90;hb=3bbd1a8a48aac6a1f2b72dbe951f58fc32ed3bda;hpb=8b1aeadaf0347fb27bc7756cdf03aad32d03f3da> -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company [image: https://community.postgresroc

[pgAdmin4][Patch]: Fix the logic to extract the error in Query tool

Hi, PFA minor patch to fix the issue where logic to extract the error using RegEX from error message was incorrect in Query tool(History tab). RM#2700 Another minor issue which I observed on login page is that close button on alert is little misaligned(screenshot attached). -- Regards, Murtuza

[pgAdmin4][Patch]: Fix the Enabale/Disbale trigger functionality

Hi, PFA minor patch which fixes, 1) To fix the Enable/Disable trigger functionality. RM#2707 2) Corrected the typo in gettext string causing malformed string in TableSpace module. RM#2708 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgAdmin4][Patch]: Fix the logic to extract the error in Query tool

Hi Dave, Please disregard my previous patch and instead attaching updated patch. In my previous patch I used `let` keyword instead of `var` for defining variable, for consistency & backward compatibility I have used `var` in my latest patch. -- Regards, Murtuza Zabuawala EnterpriseDB:

Re: [pgAdmin4][Patch]: Fix the logic to extract the error in Query tool

Hi Dave, Sorry my bad, I didn't check the backend code, I assumed that it is coming from psycopg2 and so I was focusing it to remove from client side :( PFA updated patch. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Sep 18

Re: [pgAdmin4][Patch]: Fix the logic to extract the error in Query tool

Hi Dave, PFA patch. On Mon, Sep 18, 2017 at 4:34 PM, Dave Page <dp...@pgadmin.org> wrote: > Hi > > On Mon, Sep 18, 2017 at 10:54 AM, Murtuza Zabuawala <murtuza.zabuawala@ > enterprisedb.com> wrote: > >> Hi, >> >> PFA minor patch to fix the issue wh

Re: [pgAdmin4][Patch]: Fix the logic to extract the error in Query tool

, Murtuza On Mon, Sep 18, 2017 at 8:20 PM, Dave Page <dp...@pgadmin.org> wrote: > Hi > > On Mon, Sep 18, 2017 at 3:08 PM, Murtuza Zabuawala < > murtuza.zabuaw...@enterprisedb.com> wrote: > >> Hi Dave, >> >> Sorry my bad, I didn't check the backend code, I assu

Re: pgAdmin 4 commit: Bundle fonts with pgAdmin so we have a standard set f

Hi Dave, Please find patch to fix the font on alertify header. Please review. -- Regards, Murtuza Zabuawala On Fri, Sep 15, 2017 at 7:10 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Atul, > > I think we still missed alertify header fonts :) >

[pgAdmin4][Patch]: To exclude SELECT queries from transaction in query tool

Hi, PFA minor patch to fix the issue where we were executing SELECT statements in transactions in query tool which probably is not required because SELECT statements are already protected from dirty reads. RM#2683 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com

Re: pgAdmin 4 v2.0 Released!

e and nobody had an answer. > > On 6 Oct 2017 8:31 a.m., "Murtuza Zabuawala" <murtuza.zabuawala@ > enterprisedb.com> wrote: > >> Have you reported the issue & could you provide us a ticket number for >> the same, so that we can verify. >>

[pgAdmin4][Patch]: Use https:// to open postgres online help documents

Hi, PFA minor patch to use the https:// instead of http:// to open online help documents. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/help/__init__.py b/web/pgadmin/help/__init__.py index 0840698..c079a7c

[pgAdmin4][Patch]: Fix 'Connect to Server' dialog layout

Hi, PFA minor patch to fix the 'Connect to Server' dialog layout issue. RM#2684 This issue is regression of commit: Link <https://git.postgresql.org/gitweb/?p=pgadmin4.git;a=commit;h=47cf874460dd0fcd0f39af1772e4ba3913020ee1> -- Regards, Murtuza Zabuawala EnterpriseDB

Re: Build failed in Jenkins: pgadmin4-master-python26 #436

I'm able to run tests & pgAdmin4 on my machine using Python2.6. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company [image: https://community.postgresrocks.net/] <https://community.postgresrocks.net/> On Mon, Sep 11, 2017 at 2:0

Re: Build failed in Jenkins: pgadmin4-master-python26 #436

wrote: > Hi > > On Mon, Sep 11, 2017 at 10:27 AM, Murtuza Zabuawala <murtuza.zabuawala@ > enterprisedb.com> wrote: > >> This is what I have in my system, which is working fine >> >> (venv26) murtuza@ubuntu-vm:[~/projects/pgadmin4/web/regression]$ python &g

Re: Build failed in Jenkins: pgadmin4-master-python26 #436

nkins? >> >> On Mon, Sep 11, 2017 at 9:54 AM, Murtuza Zabuawala < >> murtuza.zabuaw...@enterprisedb.com> wrote: >> >>> I'm able to run tests & pgAdmin4 on my machine using Python2.6. >>> >>> -- >>> Regards, >>> Murtuza Zab

Re: Build failed in Jenkins: pgadmin4-master-python26 #436

.6. > > Plus... the wheel package is only used for creating the wheel, which is > done on 2.7 anyway. > > On Mon, Sep 11, 2017 at 10:43 AM, Murtuza Zabuawala <murtuza.zabuawala@ > enterprisedb.com> wrote: > >> That will work but If we stick with older versions then we won

Re: Build failed in Jenkins: pgadmin4-master-python26 #433

isn't any different from using windows XP."* Python2.6 is officially dead from last 4 years, I am not able to justify any valid reason for my PR :( -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company [image: https://community.postgre

[pgAdmin4][Patch]: Fix CREATE Script issue in Index module

Hi, PFA minor patch to fix the issue where sql from CREATE Script/SQL Panel doesn't escape column names in Table reversed engineered sql (if table has index) & Index reversed engineered sql. RM#2619 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise Postgr

Re: Build failed in Jenkins: pgadmin4-master-python26 #433

Please disregard my previous patch and find updated patch in which we will use hard coded version only Python2.6 and not other versions.​ ​Please review. ​ On Sat, Sep 9, 2017 at 10:13 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > ​Hi Dave, > > From on g

Re: Build failed in Jenkins: pgadmin4-master-python26 #433

txt. This workaround is working fine at a moment(also with Python2.6) but not sure if it will break anything else in its dependent modules for other Python versions in future.​ PFA patch. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company [image: ht

Re: [pgadmin-hackers] Autoformatting

Hello, Just curious to know if we are still working on this feature? -- Regards, Murtuza On Mon, May 29, 2017 at 5:21 AM, Dave Page wrote: > On Sun, May 28, 2017 at 11:54 AM, Robert Eckhardt > wrote: > > > > > > On Tue, May 9, 2017 at 4:26 AM, Dave

[pgAdmin4][Patch]: Code refactoring - Dashboard module

Hi, PFA patch to refactor dashboard client side code for cancel & terminate session button. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/dashboard/static/js/dashboard.js b/web/pgadmin/dashboard/stati

[pgAdmin4][Patch]: To fix validation issue in connection string for pgAgent Job Step

Hi, PFA minor patch to fix the issue where it was throwing error for valid connection string if user passed host value as ip address. RM#2655 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/server_groups

[pgAdmin4][Patch]: Update codemirror to latest version

Hi, PFA patch to update CodeMirror to latest version(5.28.0 <https://codemirror.net/doc/releases.html>) which will fixes below listed issues, *Fixes:* RM#1697 RM#2168 RM#2447 RM#2562 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL C

Re: pgAdmin4 - Tree view icons for final reveiw

m each other despite both are triggers. I know this is out of context but in my own opinion these icons have resemblance with Flat design where as rest of our application is in 2d design, for example buttons, dialogs etc. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com Th

Re: [pgAdmin4][Patch]: Allow user to provide custom SSL certificates and provide .pgpass file

Hi Dave, On Fri, Aug 25, 2017 at 2:14 PM, Dave Page <dp...@pgadmin.org> wrote: > Hi > > On Thu, Aug 24, 2017 at 9:02 AM, Murtuza Zabuawala <murtuza.zabuawala@ > enterprisedb.com> wrote: > >> Hi, >> >> PFA patch to allow user to provide custom pat

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

issed this issue, as "backend_type" column only exists in PG10+. Thanks to Surinder for reporting the issue. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company [image: https://community.postgresrocks.net/] <https://community.postgr

[pgAdmin4][Patch]: Allow user to provide custom SSL certificates and provide .pgpass file

/static/ssl-tcp.html *.pgpass file reference:* https://www.postgresql.org/docs/10/static/libpq-pgpass.html -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company [image: https://community.postgresrocks.net/] <https://community.postgresrocks.

Re: Next release

+1 to 2.0 -- Thanks, Murtuza On Thu, Aug 24, 2017 at 3:06 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi Dave, > > On Thu, Aug 24, 2017 at 2:28 PM, Dave Page wrote: > >> Anyone object to doing a release on 14th September, wrapping the code on >> Monday

[pgAdmin4][Patch]: Fix internal server error on Trigger module

Hi, PFA minor patch to fix the issue where it was throwing internal server error on SQL panel when trigger is of update event type. I have updated sample code to re-produce the issue on RM. RM#2668 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise

Re: Array representation and save array data from datagrid [RM2671][pgAdmin4]

Hi Harshal, Could you please look at the latest issue reported by user on https://redmine.postgresql.org/issues/2258#change-8312 It looks like regression of RM#2671 changes. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Sep 18

Re: [pgAdmin4][Patch]: Allow user to choose background colour for server

On Wed, Nov 15, 2017 at 1:20 PM, Ashesh Vashi <ashesh.va...@enterprisedb.com > wrote: > Hi Murtuza, > > On Wed, Nov 15, 2017 at 12:58 PM, Murtuza Zabuawala <murtuza.zabuawala@ > enterprisedb.com> wrote: > >> Hi, >> >> PFA new patch. >> >

Re: [pgAdmin4][Patch]: Allow user to choose background colour for server

Hi, Please hold on this patch, As discussed with Ashesh I need to make some changes, I'll send new patch. On Wed, Nov 15, 2017 at 10:07 AM, Murtuza Zabuawala <murtuza.zabuawala@ enterprisedb.com> wrote: > Hi, > > PFA patch which will allow user to choose background colour for t

[pgAdmin4][Patch]: Add basic JSON formatting - Query tool

Hi, PFA minor patch which will add basic formatting in our custom SlickGrid JSON editor. RM#2748 I have updated RM with sample sql for testing. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/static/js/slickgrid

[pgAdmin4][Patch]: To display leading whitespace properly in columns - Query tool

Hi, PFA minor patch to fix the issue where user were not able to see leading whitespace in their columns. RM#2880 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/tools/sqleditor/static/css/sqleditor.css b/web

[pgAdmin4][Patch]: Do not use actual path when displaying dummy SSL certificates files

Hi, PFA patch to fix the issue where we were exposing the actual storage directory path when user did not provided their own SSL certificates in Server mode. RM#2866 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin

Re: [pgAdmin4][Patch]: Switching between Tabs resets table viewport to first row in gird - Query tool

Hi Dave, PFA updated patch. On Wed, Nov 22, 2017 at 10:26 PM, Dave Page <dp...@pgadmin.org> wrote: > Hi > > On Wed, Nov 22, 2017 at 3:18 PM, Murtuza Zabuawala <murtuza.zabuawala@ > enterprisedb.com> wrote: > >> Hi, >> >> PFA patch to fix the issue

[pgAdmin4][Patch]: Switching between Tabs resets table viewport to first row in gird - Query tool

w 4) Click on 'Explain' Tab 5) Go back to 'Data output' Tab -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/tools/sqleditor/static/js/sqleditor.js b/web/pgadmin/tools/sqleditor/static/js/sqleditor.js index 9a0c3de..df9e

[pgAdmin4][Patch]: Remove fixed width from sql-hint popup - Query tool

Hi, PFA minor patch to fix the issue where long database object names were truncated and not visible due to fixed pop-up size. RM#2726 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/tools/sqleditor/static/css

[pgAdmin4][Patch]: To decode database errors properly

Hi, PFA patch to fix the issue where if the database server is installed on the windows system then in most cases the parameter 'lc_messages' has environment dependent encoding. RM#2806 RM#2821 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL

[pgAdmin4][Patch]: Remove default 'Altertify JS' header from debugger related error alerts

Hi, PFA patch to remove default 'Altertify JS' header from debugger related error notifications. RM#2098 Also fixed similar issue in other modules. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/tools/debugger

Re: [pgAdmin4][Patch]: Adding connection status in Query tool

ed and connection to server gets closed after that. > > Thanks! > > On Tue, Dec 19, 2017 at 11:42 AM, Murtuza Zabuawala < > murtuza.zabuaw...@enterprisedb.com> wrote: > >> Hi, >> >> PFA patch to add the connection status >> <http://initd.org/

Re: [pgAdmin4][Patch]: Add basic Tab navigation - Debugger

On Thu, Dec 14, 2017 at 2:17 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Thu, Dec 14, 2017 at 2:07 PM, Murtuza Zabuawala <murtuza.zabuawala@ > enterprisedb.com> wrote: > >> Yes, we can commit this code, It will add basic button navigation

[pgAdmin4][Patch]: Do not render security URL in templates if running in Desktop mode

it not working as expected and causing runtime to render login screen. Thanks to Neel for helping me in testing the patch with latest runtime code. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/__init__.py b/web

Re: [pgAdmin4][Patch]: Adding connection status in Query tool

On Wed, Dec 20, 2017 at 12:17 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > > > -- > *Harshal Dhumal* > *Sr. Software Engineer* > > EnterpriseDB India: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Tue, Dec 19

  1   2   3   4   >