[pgAdmin][7046] Accessibility fixes

2021-12-01 Thread Ganesh Jaybhay
of the textbox *Solution Added*: ESC key is used to come out of the textbox for the access key and move to the next field - Focus is not visible for the links on the dashboard Please review. Regards, Ganesh Jaybhay RM7046.patch Description: Binary data

Re: [pgAdmin][5919] Fix security related issues

2020-10-19 Thread Ganesh Jaybhay
Thank you Dave for the suggestion. Please find the attached updated patch to make HSTS by default disabled and conditional based on flag. Regards, Ganesh Jaybhay On Mon, Oct 19, 2020 at 5:38 PM Dave Page wrote: > Hi > > On Mon, Oct 19, 2020 at 1:01 PM Ganesh Jaybhay < &

[pgAdmin][5919] Fix security related issues

2020-10-19 Thread Ganesh Jaybhay
if I have missed anything. Regards, Ganesh Jaybhay RM5919.patch Description: Binary data

[pgAdmin][RM5830] View: parenthesis re-arrangement with AND/OR

2020-09-14 Thread Ganesh Jaybhay
Hi Hackers, Please find the attached patch to add the parenthesis similar to dba_views for the created views. Please review. Regards, Ganesh Jaybhay RM5830.patch Description: Binary data

[pgAdmin] Accessibility fixes for main panels

2020-09-01 Thread Ganesh Jaybhay
Hi Hackers, Please find the attached patch to fix the accessibility errors found with WAVE tool on - Dashboard - Dependencies / Dependents panel with no object selected in tree view. Regards, Ganesh Jaybhay accessibility_fix_main_panels.patch Description: Binary data

[pgAdmin][5469] SSL mode dropdown hover in create server dialog is not consistent with other select2

2020-05-03 Thread Ganesh Jaybhay
Hi Hackers, Please find the attached minor patch to fix the issue with select2 hover consistency for SSL mode field(SSL tab) in create server dialog. Please review. Regards, Ganesh Jaybhay diff --git a/web/pgadmin/browser/server_groups/servers/static/js/server.js b/web/pgadmin/browser

[pgAdmin][4709] Invalid FTS configuration token dictionaries

2020-04-14 Thread Ganesh Jaybhay
Hi Hackers, Attached is the patch to add schema qualified dictionary names in FTS configuration to overcome the confusion of duplicate dictionary names. Also modified the resql test cases accordingly. Please review. Regards, Ganesh Jaybhay diff --git a/web/pgadmin/browser/server_groups/servers

[pgAdmin][RM5007] Index should be visible using unique constraints

2020-04-13 Thread Ganesh Jaybhay
Please review. Regards, Ganesh Jaybhay diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/constraints/index_constraint/static/js/primary_key.js b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/constraints/index_constraint/static/js/primary_key.js

Re: Fix in switch cell tab navigation

2020-03-25 Thread Ganesh Jaybhay
Hi Khushboo, I have removed the condition added for subgrid-cell. Please find the attached updated patch Regards, Ganesh Jaybhay On Wed, Mar 25, 2020 at 5:39 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Ganesh, > > You have put a check on *subgrid-cell* cl

Fix in switch cell tab navigation

2020-03-25 Thread Ganesh Jaybhay
. Please review. Regards, Ganesh Jaybhay diff --git a/web/pgadmin/static/js/backgrid.pgadmin.js b/web/pgadmin/static/js/backgrid.pgadmin.js index 230d7ce56..61127ddb1 100644 --- a/web/pgadmin/static/js/backgrid.pgadmin.js +++ b/web/pgadmin/static/js/backgrid.pgadmin.js @@ -206,7 +206,7 @@ define

Re: [pgAdmin][RM4764][Accessibility] Allow screen-reader to read relationship attributes in nested elements

2020-03-11 Thread Ganesh Jaybhay
Hi Hackers, Attached is the patch on top of initial patch for: - screen reader to read elements in radio modern control - minor accessibility(aria-label) additions at few missing places - Radiocontrol to have different ids for each options Please review. Regards, Ganesh Jaybhay

Re: [pgAdmin4][RM#5107] Add tab navigation for buttons in file manager dialogue

2020-01-21 Thread Ganesh Jaybhay
Changed the subject On Tue, Jan 21, 2020 at 6:26 PM Ganesh Jaybhay < ganesh.jayb...@enterprisedb.com> wrote: > Hi Hackers, > > Please find the attached minor fix for tab navigation on footer and > confirmation dialog buttons from file manager dialogue > Kindly review.

[pgAdmin4][RM#5107] Add tab navigation for tabs under explain panel in query tool

2020-01-21 Thread Ganesh Jaybhay
Hi Hackers, Please find the attached minor fix for tab navigation on footer and confirmation dialog buttons from file manager dialogue Kindly review. Regards, Ganesh Jaybhay RM5107.patch Description: Binary data

[pgAdmin4][RM#5047] Add tab navigation for tabs under explain panel in query tool

2019-12-31 Thread Ganesh Jaybhay
Hi Hackers, Please find the attached minor fix for tab navigation of graphical, analysis and statistics tabs under explain panel in query tool. Kindly review. Regards, Ganesh Jaybhay RM5047.patch Description: Binary data

[pgAdmin][RM4895] Possible issue in reset function for nested objects

2019-11-04 Thread Ganesh Jaybhay
Hi Hackers, Please find the attached patch to fix the possible issue in reset function for nested objects. Regards, Ganesh Jaybhay RM4895.patch Description: Binary data

[pgAdmin][RM4845] Potential error in properties dialog for Code tab

2019-10-17 Thread Ganesh Jaybhay
Hi Hackers, Please find the attached minor patch to fix the potential error if 'tabPanelCodeClass' is not passed while creating dialog. Kindly review. Regards, Ganesh Jaybhay RM4845.patch Description: Binary data

[pgAdmin4][patch] MSQL test cases for FTS configurations

2019-09-03 Thread Ganesh Jaybhay
Hi Hackers, Please find the attached patch for msql test cases of FTS configurations. Kindly review. Regards, Ganesh Jaybhay msql_fts_configuration.patch Description: Binary data

[pgAdmin][Patch] Highlight adjacent switch cell on focus in backgrid(IE11)

2019-07-25 Thread Ganesh Jaybhay
Hi Hackers, Attached is the minor fix to highlight adjacent switch cell on focus in IE11. Currently nn create table columns tab, on navigating from Not Null? to Primary key? column, switch cell for primary key doesn't get highlighted. Kindly review. Regards, Ganesh Jaybhay

[pgAdmin][RM4490] Checkbox doesn't highlight on focus in IE11

2019-07-23 Thread Ganesh Jaybhay
Hi Hackers, Attached is the minor css fix to highlight checkbox on focus in IE11. Kindly review. Regards, Ganesh Jaybhay RM4490.patch Description: Binary data

Re: [pgAdmin4][patch] Keyboard accessibility for sub-node control

2019-07-11 Thread Ganesh Jaybhay
Hi Dave, Please find the attached patch for jasmine tests fix. Patch also includes fixes for edit/delete cell focus on IE by Murtuza. Regards, Ganesh Jaybhay On Thu, Jul 11, 2019 at 3:49 PM Dave Page wrote: > Hi Ganesh, > > It looks like this has broken the Jasmine tests (which

[pgAdmin4][patch] Reverse engineering sql test cases for FTS configuration

2019-07-09 Thread Ganesh Jaybhay
Hi Hackers, Please find the attached patch for reverse engineering sql test cases of FTS configuration. Kindly review. Regards, Ganesh Jaybhay re_sql_fts_configuration.patch Description: Binary data

[pgAdmin4][patch] Keyboard accessibility for sub-node control

2019-07-08 Thread Ganesh Jaybhay
Hi Hackers, Attached is the patch for keyboard accessibility of sub-node control. It also covers sub-node dialog forward/backward tab navigation with shortcuts. Kindly review. Regards, Ganesh Jaybhay subnode_control_accessibility.patch Description: Binary data

[pgAdmin][RM4219] Fix 404 flask error for popper.js

2019-04-30 Thread Ganesh Jaybhay
Hi Hackers, Attached is the patch for 404 flask error for popper.js. Kindly review. Regards, Ganesh Jaybhay RM4219.patch Description: Binary data

[pgAdmin4][patch] Few UI improvements and fixes

2019-01-21 Thread Ganesh Jaybhay
Hi Hackers, Attached is the patch for below minor fixes: 1. Proper alignment of help message with date time control 2. Added help-block class for helpMessageClassName Kindly review. Regards, Ganesh Jaybhay fix_help_message.patch Description: Binary data

[pgAdmin4][Patch] Rename DROP & DROP CASCADE in confirmation dialog title

2018-08-14 Thread Ganesh Jaybhay
Hi Hackers, Attached is the patch for renaming DROP and DROP CASCADE to Drop and Drop Cascade respectively from the title of confirmation dialog. Regards, Ganesh Jaybhay node.patch Description: Binary data