[pgAdmin][RM5480]Background job creation failure.

2020-05-05 Thread Nagesh Dhope
Hi Hacke The attached patch fixes background job creation failure when there is only version-specific python binary available in $PATH. -- Thanks,, Nagesh RM5480.patch Description: Binary data

[pgAdmin][RM3787] Issue with Stop Process button

2020-04-24 Thread Nagesh Dhope
Hi Hackers, After the process is terminated, it's taking some time to return exit_code and our frontend code is waiting for exit_code to notify the user that the process is terminated by the user. Also *Stop Process *button is not getting disabled and which is misleading the user that nothing is

Re: [pgAdmin][RM3269] Slider jumps up issue in DataView panel

2020-04-23 Thread Nagesh Dhope
On Wed, Apr 22, 2020 at 6:49 PM Akshay Joshi wrote: > Thanks, patch applied. > > On Wed, Apr 22, 2020 at 5:38 PM Nagesh Dhope < > nagesh.dh...@enterprisedb.com> wrote: > >> Hi Hackers, >> The attached patch makes an API call to fetch the next batch of rows on

Re: [pgAdmin][RM3269] Slider jumps up issue in DataView panel

2020-04-22 Thread Nagesh Dhope
Hi Hackers, The attached patch makes an API call to fetch the next batch of rows only after a user stops scrolling down(to detect added timeout of 250ms) using the slider. On Tue, Apr 21, 2020 at 1:32 PM Akshay Joshi wrote: > Thanks, patch applied. > > On Tue, Apr 21, 2020 at 12:10

Re: [pgAdmin][RM3947] Fixes related rows copy-paste in Query Tool.

2020-04-21 Thread Nagesh Dhope
Hi, Please find a patch, which will allow copying *[null]* and *[default] cell values.* RM3947_v3.patch Description: Binary data

[pgAdmin][RM3269] Slider jumps up issue in DataView panel

2020-04-21 Thread Nagesh Dhope
Hi Hackers, The attached patch fixes an issue where slider jumps up when new rows get loaded while scrolling down in the DataView panel in the query tool. Fix uses *rows_affected *field to create dummy rows (Apart from the first *batch of rows). *Dummy rows will be updated as and when they are

[pgAdmin][RM4573] Download csv as .csv when delimeter set comma(,)

2020-04-16 Thread Nagesh Dhope
Hi Hackers, This patch allows user to download CSV as a '.csv' file if delimiter character is set to comma(,) else it will download it as '.txt' file. This patch also contains test cases for some missing scenarios for download CSV API. -- Thanks, Nagesh RM4573.patch Description: Binary data

Re: [pgAdmin][RM3947] Fixes related rows copy-paste in Query Tool.

2020-04-15 Thread Nagesh Dhope
Please find an updated patch, which handles field separator and quote character from *Result Grid *preferences. On Wed, Apr 15, 2020 at 10:18 AM Nagesh Dhope wrote: > Hi Hackers, > Please find a patch which fixes, > >1. Copy table rows across two or more active query tool sess

[pgAdmin][RM3947] Fixes related rows copy-paste in Query Tool.

2020-04-14 Thread Nagesh Dhope
Hi Hackers, Please find a patch which fixes, 1. Copy table rows across two or more active query tool sessions. 2. Copied rows can be pasted multiple times without selecting a row in the query tool grid. 3. Adds an empty row at the end in the query tool grid after pasting rows. --

[pgAdmin][RM3972] Standard OSX keyboard behaviour in Query Tool.

2020-04-09 Thread Nagesh Dhope
Hi Hackers, Please find a patch, which fixes following OSX native keyboard shortcuts in Query Tool. 1. option+arrow (L/R) should skip by "word" 2. option+arrow (up/down) should go up/down one line 3. shift+option+arrow (L/R) should select/highlight by "word" -- Thanks, Nagesh

Re: [pgAdmin][RM5292] Alertify header buttons focus color issue

2020-03-25 Thread Nagesh Dhope
uld not be allowed to edit. It is a > structural variable and not a variable which affects theme change. > Please revert the $active-border change and send the patch. > > On Thu, Mar 26, 2020 at 10:14 AM Nagesh Dhope < > nagesh.dh...@enterprisedb.com> wrote: > >> Hi H

[pgAdmin][RM5292] Alertify header buttons focus color issue

2020-03-25 Thread Nagesh Dhope
Hi Hackers, Please find a patch which includes 1. Use *btn-secondary* styles for all buttons in alertify dialog header. 2. Added *!default *for $active-border variable, so that it can be overridden if required. 3. Added entry for *.scss *in .editorconfig -- Thanks, Nagesh

Re: [pgAdmin][RM4993] [Accessibility] Read-only controls and disabled controls needs to be separately identified

2020-03-05 Thread Nagesh Dhope
Hi Akshay, Please find a patch to make controls under *Active query details* subnode read-only on the dashboard. On Fri, Jan 31, 2020 at 12:38 PM Akshay Joshi wrote: > Thanks, patch applied. > > On Thu, Jan 30, 2020 at 1:55 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >>

Re: [pgAdmin4][RM5185] Option to override select2control's label className

2020-02-16 Thread Nagesh Dhope
Hi Akshay, Please find a patch for initializing the label and control className for select2, which was missing my last patch. On Mon, Feb 17, 2020 at 11:59 AM Akshay Joshi wrote: > Thanks patch applied > > On Fri, Feb 14, 2020 at 1:41 PM Nagesh Dhope < > nagesh.dh...@enterpri

[pgAdmin4][RM5185] Option to override select2control's label className

2020-02-14 Thread Nagesh Dhope
Hi Hackers, Please find a patch, which will allow overriding select2control's label className using *controlLabelClassName* option. -- Thanks, Nagesh RM5185.patch Description: Binary data

Re: [pgAdmin][Accessibility][RM4601] Tab navigation for panel buttons.

2020-02-03 Thread Nagesh Dhope
Hi Akshay, Please find the updated patch. On Fri, Jan 31, 2020 at 12:26 PM Akshay Joshi wrote: > Hi Nagesh > > I have tested the patch it is working for panels but for create/properties > dialog it doesn't work. Please fix that and resend the patch. > > On Tue, Jan 28, 2020

[pgAdmin][Accessibility][RM4601] Tab navigation for panel buttons.

2020-01-28 Thread Nagesh Dhope
Hi Hackers, Attached is a patch for tab navigation for all the panels, create/properties dialogs close buttons. Patch also fixes tab navigation for scroll left and scroll right buttons on main window. Note - Currently there is no shortcut added to trigger close/scroll left/scroll right current

[pgAdmin][RM4763][RM4762] Allow screen readers to identify errors and read description of non-textable elements.

2020-01-24 Thread Nagesh Dhope
Hi Hackers, Attached patch fixes RM4763 - Added role *alertdialog* for *confirm* and *alert* dialog. - Added role *status* for all status bars/banners. - Added role *alert* for error bars. RM4762 - Added *aria-labelledby* for charts on each dashboard, note that I have also

Re: Update wcDocker

2020-01-07 Thread Nagesh Dhope
Created https://redmine.postgresql.org/issues/5072 for the same.

Update wcDocker

2020-01-07 Thread Nagesh Dhope
Hi Hackers, Please find a patch for updating wcDocker package, update includes aria-label accessibility improvements. -- Thanks, Nagesh update_wcdocker.patch Description: Binary data

[RM4772] [Accessibility] aria-label in missing places

2019-12-31 Thread Nagesh Dhope
Hi Hackers, I have added an aria-label attribute where ever it is missing. PFA for the same. -- Thanks, Nagesh pgadmin_aria_label_v2.patch Description: Binary data

Re: [pgAdmin4][RM#4772] Add aria-label attribute to buttons used in graphical explain plan

2019-12-26 Thread Nagesh Dhope
Hi Hackers, Please find an updated patch. The patch includes fix for not to blur the focus from (Zoom in, Zoom out, Zoom to original and Download) button after a click. On Fri, Dec 20, 2019 at 5:47 PM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch for adding

[pgAdmin][RM4896] Close Open/Save Dialog in query tool on Escape key

2019-11-08 Thread Nagesh Dhope
Hi Hackers, Please find an attached patch for closing Open/Save dialog in the query tool on the escape key. -- Thanks, Nagesh RM4896.patch Description: Binary data

[pgAdmin][RM4850] Don't open Datetime Picker when clicked on field's label

2019-10-17 Thread Nagesh Dhope
Hi Hackers, Please find the attached patch for #4850 -- Thanks, Nagesh RM4850.patch Description: Binary data

MSQL test cases for FTS Dictionaries.

2019-09-06 Thread Nagesh Dhope
Hi, Please find a patch for MSQL test cases for FTS Dictionaries. -- Thanks, Nagesh fts_dictionaries_msql.patch Description: Binary data

MSQL test cases for Extension node

2019-09-06 Thread Nagesh Dhope
Hi, Please find a patch for MSQL test cases for Extension node -- Thanks, Nagesh extensions_msql.patch Description: Binary data

Skip a RE-SQL test on the bases of precondition

2019-07-21 Thread Nagesh Dhope
Hi Hackers, Please find patch for skipping a RE-SQL test if precondition to execute that test does not satisfy. -- Thanks, Nagesh precondition_sql_in_resql.patch Description: Binary data

patch for RE-SQL test cases for FTS Dictionaries.

2019-07-11 Thread Nagesh Dhope
Hi Hackers, PFA, patch for RE-SQL test cases for FTS Dictionaries. -- Thanks, Nagesh fts_dictionaries_resql_v1.patch Description: Binary data

Re: RE-SQL test patch for extension node

2019-07-11 Thread Nagesh Dhope
Please ignore this patch. Sending updated on new thread On Thu, Jul 11, 2019 at 11:40 AM Nagesh Dhope wrote: > Fixed failing extension resql test cases on PG 9.4 and PG 9.5. > PFA updated patch. > > On Tue, Jul 9, 2019 at 5:53 PM Dave Page wrote: > >> Thanks, applied! >

Updated patch for RM #4453

2019-07-11 Thread Nagesh Dhope
Hi, PFA, updated patch for RM #4453 Thanks, Nagesh extension_resql_tests_v5.patch Description: Binary data

Re: RE-SQL test patch for extension node

2019-07-09 Thread Nagesh Dhope
y", > line 832, in _baseAssertEqual > raise self.failureException(msg) > AssertionError: 500 != 200 > > > On Tue, Jul 9, 2019 at 6:16 AM Nagesh Dhope > wrote: > >> Hi Dave, >> >> Please find updated patch with *sslinfo.* >> >> On Mon, Jul

Re: RE-SQL test patch for extension node

2019-07-09 Thread Nagesh Dhope
Hi Dave, Please find updated patch with *sslinfo.* On Mon, Jul 8, 2019 at 2:03 PM Dave Page wrote: > Hi > > On Fri, Jul 5, 2019 at 5:16 PM Nagesh Dhope > wrote: > >> Hi Hackers, >> Please review attached patch for RE-SQL test cases for *extension* node. >

RE-SQL test patch for extension node

2019-07-05 Thread Nagesh Dhope
Hi Hackers, Please review attached patch for RE-SQL test cases for *extension* node. Thanks, Nagesh Dhope extension_resql_tests.patch Description: Binary data