Re: [pgAdmin4][patch] extract generate_url function from node.js and collection.js

2017-08-17 Thread Violet Cheng
>> >>> Thanks, >> Khushboo >> >> On Fri, Aug 11, 2017 at 12:08 PM, Ashesh Vashi < >> ashesh.va...@enterprisedb.com> wrote: >> >>> On Thu, Aug 10, 2017 at 1:15 PM, Violet Cheng <vch...@pivotal.io> wrote: >>> >>>&

Re: [pgAdmin4][patch] update the alert style in the sub-navigation

2017-08-16 Thread Violet Cheng
l.org/message-id/CAM5-9D8UJVgCD0MrKq6yPx0qx9k8v3r6_4e8SkHdGV1RBDnhbQ%40mail.gmail.com> > . > > Thanks, > Surinder > > On Wed, Aug 16, 2017 at 8:57 AM, Violet Cheng <vch...@pivotal.io> wrote: > >> Hi, >> >> Any update on this patch? Could it be committed soon? >> >> Thanks, &g

Re: [pgadmin4][patch] Fix the style of the alert when connecting/disconnecting from a server

2017-08-15 Thread Violet Cheng
Hi, Is there any update on this patch? Will it be committed soon? Thanks, Violet On Fri, Aug 11, 2017 at 2:46 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi > > I reviewed this patch and it looks good to me. > > Thanks, > Surinder > > On Fri, Aug 11, 2017 at 9:13 AM, Sarah

Re: [pgAdmin4][patch] update the alert style in the sub-navigation

2017-08-15 Thread Violet Cheng
zo9wUDtYE2jFz-%3DPbJr%2Btf20zyFncdEoAFdVMkTgoXzf3w%40mail.gmail.com> > . > > Thanks! > > On Thu, Aug 10, 2017 at 4:10 PM, Violet Cheng <vch...@pivotal.io> wrote: > >> Here's the Redmine link >> >> https://redmine.postgresql.org/issues/2644 >> >> On Thu, Aug 1

Re: [pgAdmin4][PATCH] Refactor and change of implementation of keyboard_shortcuts function dependencies

2017-08-15 Thread Violet Cheng
Hi, Is there any update on these patches? Will it be committed soon? Thanks, Violet On Thu, Aug 10, 2017 at 2:31 PM, Wenlin Zhang wrote: > Hi hackers, > >We have rebased all the three patches and they are ready to be applied. > > Thanks, > > Wenlin & Matt > > On Wed,

Re: [pgAdmin4][patch] update the alert style in the sub-navigation

2017-08-10 Thread Violet Cheng
Here's the Redmine link https://redmine.postgresql.org/issues/2644 On Thu, Aug 10, 2017 at 4:03 PM, Violet Cheng <vch...@pivotal.io> wrote: > Hi Surinder! > > Are you referring to the green message popup? If so, it also appears to be > happening on master. We'll log a

Re: [pgAdmin4][patch] update the alert style in the sub-navigation

2017-08-10 Thread Violet Cheng
Hi Surinder! Are you referring to the green message popup? If so, it also appears to be happening on master. We'll log a bug in our backlog and Redmine and prioritize it. We agree that it needs to be fixed, but don't think it's unrelated to this patch. Thanks! Violet & Sarah On Thu, Aug 10,