Re: [pgAdmin][RM5292] Alertify header buttons focus color issue
Thanks, patch applied. On Thu, Mar 26, 2020 at 11:00 AM Nagesh Dhope wrote: > Please find an updated patch, which fixes review comments. > > On Thu, Mar 26, 2020 at 10:24 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Nagesh, >> >> I cannot see any change related to $active-border variable apart from >> !default. Plus, $active-border should not be allowed to edit. It is a >> structural variable and not a variable which affects theme change. >> Please revert the $active-border change and send the patch. >> >> On Thu, Mar 26, 2020 at 10:14 AM Nagesh Dhope < >> nagesh.dh...@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Please find a patch which includes >>> >>>1. Use *btn-secondary* styles for all buttons in alertify dialog >>>header. >>>2. Added *!default *for $active-border variable, so that it can be >>>overridden if required. >>>3. Added entry for *.scss *in .editorconfig >>> >>> -- >>> Thanks, >>> Nagesh >>> >> >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune >> "Don't Complain about Heat, Plant a TREE" >> > > > -- > Thanks, > Nagesh > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
Re: [pgAdmin][RM5292] Alertify header buttons focus color issue
Please find an updated patch, which fixes review comments. On Thu, Mar 26, 2020 at 10:24 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Nagesh, > > I cannot see any change related to $active-border variable apart from > !default. Plus, $active-border should not be allowed to edit. It is a > structural variable and not a variable which affects theme change. > Please revert the $active-border change and send the patch. > > On Thu, Mar 26, 2020 at 10:14 AM Nagesh Dhope < > nagesh.dh...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Please find a patch which includes >> >>1. Use *btn-secondary* styles for all buttons in alertify dialog >>header. >>2. Added *!default *for $active-border variable, so that it can be >>overridden if required. >>3. Added entry for *.scss *in .editorconfig >> >> -- >> Thanks, >> Nagesh >> > > > -- > Thanks and Regards, > Aditya Toshniwal > pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- Thanks, Nagesh RM5292_v2.patch Description: Binary data
Re: [pgAdmin][RM5292] Alertify header buttons focus color issue
Hi Nagesh, I cannot see any change related to $active-border variable apart from !default. Plus, $active-border should not be allowed to edit. It is a structural variable and not a variable which affects theme change. Please revert the $active-border change and send the patch. On Thu, Mar 26, 2020 at 10:14 AM Nagesh Dhope wrote: > Hi Hackers, > > Please find a patch which includes > >1. Use *btn-secondary* styles for all buttons in alertify dialog >header. >2. Added *!default *for $active-border variable, so that it can be >overridden if required. >3. Added entry for *.scss *in .editorconfig > > -- > Thanks, > Nagesh > -- Thanks and Regards, Aditya Toshniwal pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE"
[pgAdmin][RM5292] Alertify header buttons focus color issue
Hi Hackers, Please find a patch which includes 1. Use *btn-secondary* styles for all buttons in alertify dialog header. 2. Added *!default *for $active-border variable, so that it can be overridden if required. 3. Added entry for *.scss *in .editorconfig -- Thanks, Nagesh RM5292.patch Description: Binary data
