Re: [pgAdmin4][PATCH] Highlighting greenplum keywords in sql editor

2017-09-11 Thread Akshay Joshi 
On Mon, Sep 11, 2017 at 5:34 PM, Dave Page  wrote:

> Akshay, can you review/commit this please?
>

Sure Dave.

>
> Thanks.
>
> On Mon, Sep 11, 2017 at 10:38 AM, Teng Zhang  wrote:
>
>> Hi Hackers,
>>
>> Attached is a patch that makes SQL editor show syntax highlighting with
>> Greenplum keywords.
>>
>> - Upgrade CodeMirror from 5.28 to 5.29 to include mime type "x-gpsql"
>> - Use "x-gpsql" mode for sql editor when connecting database is greenplum
>> - No behavior change to pg and ppas, still use "x-pgsql"
>>
>> Regards,
>> Hao Wang & Teng Zhang
>>
>>
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>



-- 
*Akshay Joshi*
*Principal Software Engineer *



*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

Re: [pgAdmin4][PATCH] Highlighting greenplum keywords in sql editor

2017-09-11 Thread Dave Page 
Akshay, can you review/commit this please?

Thanks.

On Mon, Sep 11, 2017 at 10:38 AM, Teng Zhang  wrote:

> Hi Hackers,
>
> Attached is a patch that makes SQL editor show syntax highlighting with
> Greenplum keywords.
>
> - Upgrade CodeMirror from 5.28 to 5.29 to include mime type "x-gpsql"
> - Use "x-gpsql" mode for sql editor when connecting database is greenplum
> - No behavior change to pg and ppas, still use "x-pgsql"
>
> Regards,
> Hao Wang & Teng Zhang
>
>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgAdmin4][PATCH] Highlighting greenplum keywords in sql editor

2017-09-11 Thread Jing Li 
Can we get this patch into the 2.0 release?  






On Mon, Sep 11, 2017 5:38 PM, Teng Zhang tezh...@pivotal.io  wrote:
Hi Hackers,
Attached is a patch that makes SQL editor show syntax highlighting with
Greenplum keywords.
- Upgrade CodeMirror from 5.28 to 5.29 to include mime type "x-gpsql"
- Use "x-gpsql" mode for sql editor when connecting database is greenplum- No
behavior change to pg and ppas, still use "x-pgsql"
Regards,Hao Wang & Teng Zhang