Patch committed (with some trivial editorial work on the docs).
Congratulations - that's impressive work!
On Tue, Jul 16, 2019 at 6:03 AM Yosry Muhammad wrote:
> Hi all,
>
> Please find attached an updated patch with the following modifications:
>
> - Fixed the bug noticed by Khushboo, it was c
I will look into it and get back to you.
Thanks !
On Fri, Jul 12, 2019, 11:20 AM Dave Page wrote:
>
>
> On Fri, Jul 12, 2019 at 5:57 AM Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>> Hi Yosry,
>>
>> On Thu, Jul 11, 2019 at 6:50 PM Yosry Muhammad
>> wrote:
>>
>>> Hi Khushboo,
>>
On Fri, Jul 12, 2019 at 5:57 AM Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:
> Hi Yosry,
>
> On Thu, Jul 11, 2019 at 6:50 PM Yosry Muhammad wrote:
>
>> Hi Khushboo,
>> Please find an updated patch attached with the mentioned import line
>> removed.
>>
>> Looks good to me.
>
>> On Thu,
Hi Khushboo,
Please find an updated patch attached with the mentioned import line
removed.
On Thu, Jul 11, 2019 at 6:45 AM Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:
> Hi,
>
> On Wed, Jul 10, 2019 at 3:11 PM Yosry Muhammad wrote:
>
>> Hi,
>>
>> On Wed, Jul 10, 2019, 9:14 AM Khushbo
Hi,
On Wed, Jul 10, 2019 at 3:11 PM Yosry Muhammad wrote:
> Hi,
>
> On Wed, Jul 10, 2019, 9:14 AM Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>> Some points I missed:
>> 1. I assumed that in this patch modification in case of OIDs= True
>> (without primary key) has not consider
Hi Yosry,
On Thu, Jul 11, 2019 at 4:10 AM Yosry Muhammad wrote:
> Hi,
> Please find an updated patch attached.
>
> On Wed, Jul 10, 2019 at 8:33 AM Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>> Hi Yosry,
>>
>> I liked the way you have refactored the code at some places in the JS
Hi,
On Wed, Jul 10, 2019, 9:14 AM Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:
> Some points I missed:
> 1. I assumed that in this patch modification in case of OIDs= True
> (without primary key) has not considered as that is not working.
>
This is not implemented yet. I will work o
Hi Khushboo,
On Wed, Jul 10, 2019, 8:33 AM Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:
> Hi Yosry,
>
> I liked the way you have refactored the code at some places in the JS file
> and made it cleaner.
>
Thanks ! I am doing my best.
Here are some points:
>
> 1. The table (including
Some points I missed:
1. I assumed that in this patch modification in case of OIDs= True
(without primary key) has not considered as that is not working.
2. As we are already showing the changed Data prompt on closing the Query
Tool, do we really need the Uncommitted Transaction prompt?
On Wed, J
Hi Yosry,
I liked the way you have refactored the code at some places in the JS file
and made it cleaner.
Here are some points:
1. The table (including partition table) with a single column having that
column primary key is editable but the save button is disabled, so,
ultimately I can't save the
On Fri, Jul 5, 2019 at 4:31 PM Dave Page wrote:
> Hi
>
> On Fri, Jul 5, 2019 at 6:28 AM Yosry Muhammad wrote:
>
>> - The patch won't apply with "git apply" and only partially applies with
>>> patch -p0. Please "git add" all your changes and new files in your repo,
>>> and then run "git diff --ca
Sounds good !
Looking forward to any feedback.
Thanks.
On Fri, Jul 5, 2019, 1:01 PM Dave Page wrote:
> Hi
>
> On Fri, Jul 5, 2019 at 6:28 AM Yosry Muhammad wrote:
>
>> - The patch won't apply with "git apply" and only partially applies with
>>> patch -p0. Please "git add" all your changes and
Hi
Apologies for the delay - I've finished travelling now.
I found a few issues, mostly minor:
- The patch won't apply with "git apply" and only partially applies with
patch -p0. Please "git add" all your changes and new files in your repo,
and then run "git diff --cached --binary", which should
13 matches
Mail list logo
