Re: [GSoC] Support editing resultsets from tables with OIDs

2019-07-29 Thread Yosry Muhammad
On Mon, Jul 29, 2019, 4:26 AM Dave Page wrote: > Hi Yosry and Akshay > > On Fri, Jul 26, 2019 at 1:02 PM Dave Page wrote: > >> Akshay; can you take a look at this and commit if appropriate please? I'm >> somewhat busy at the moment :-( >> >> On the subject of the regression test - I assume at on

Re: [GSoC] Support editing resultsets from tables with OIDs

2019-07-29 Thread Dave Page
Hi Yosry and Akshay On Fri, Jul 26, 2019 at 1:02 PM Dave Page wrote: > Akshay; can you take a look at this and commit if appropriate please? I'm > somewhat busy at the moment :-( > > On the subject of the regression test - I assume at one point the messages > window was including the command tag

Re: [GSoC] Support editing resultsets from tables with OIDs

2019-07-29 Thread Akshay Joshi
Thanks patch applied. On Mon, Jul 29, 2019 at 11:12 AM Akshay Joshi wrote: > > On Fri, Jul 26, 2019 at 5:33 PM Dave Page wrote: > >> Akshay; can you take a look at this and commit if appropriate please? I'm >> somewhat busy at the moment :-( >> > >Sure, I am looking it. > >> >> On the subje

Re: [GSoC] Support editing resultsets from tables with OIDs

2019-07-28 Thread Akshay Joshi
On Fri, Jul 26, 2019 at 5:33 PM Dave Page wrote: > Akshay; can you take a look at this and commit if appropriate please? I'm > somewhat busy at the moment :-( > Sure, I am looking it. > > On the subject of the regression test - I assume at one point the messages > window was including the co

Re: [GSoC] Support editing resultsets from tables with OIDs

2019-07-26 Thread Dave Page
Akshay; can you take a look at this and commit if appropriate please? I'm somewhat busy at the moment :-( On the subject of the regression test - I assume at one point the messages window was including the command tags in it's output. This failure would indicate we broken that. Anyone got any idea

[GSoC] Support editing resultsets from tables with OIDs

2019-07-25 Thread Yosry Muhammad
Hi, Please find a patch attached to add supporting of resultsets from tables with OIDs as updatable resultsets (with updated test cases and docs) - this is a part of a GSoC project. Please review ! This patch also includes a small refactor of the previous patch and a small bug fix that occurred whe