Re: [pgAdmin][RM3269] Slider jumps up issue in DataView panel

2020-04-24 Thread Akshay Joshi
Thanks, patch applied. On Fri, Apr 24, 2020 at 10:49 AM Nagesh Dhope wrote: > Hi Hackers, > After fixing the issue reported by Shubham, I observed that sometimes > browser is getting hanged and sometimes ViewData grid is getting disappear, > I suspect its due to the number of rows to update on

Re: [pgAdmin][RM3269] Slider jumps up issue in DataView panel

2020-04-23 Thread Nagesh Dhope
Hi Hackers, After fixing the issue reported by Shubham, I observed that sometimes browser is getting hanged and sometimes ViewData grid is getting disappear, I suspect its due to the number of rows to update on slick grid after fetching next of rows. FYI, I was running a query which was returning

Re: [pgAdmin][RM3269] Slider jumps up issue in DataView panel

2020-04-22 Thread Akshay Joshi
Thanks, patch applied. On Wed, Apr 22, 2020 at 5:38 PM Nagesh Dhope wrote: > Hi Hackers, > The attached patch makes an API call to fetch the next batch of rows only > after a user stops scrolling down(to detect added timeout of 250ms) using > the slider. > > On Tue, Apr 21, 2020 at 1:32 PM

Re: [pgAdmin][RM3269] Slider jumps up issue in DataView panel

2020-04-22 Thread Nagesh Dhope
Hi Hackers, The attached patch makes an API call to fetch the next batch of rows only after a user stops scrolling down(to detect added timeout of 250ms) using the slider. On Tue, Apr 21, 2020 at 1:32 PM Akshay Joshi wrote: > Thanks, patch applied. > > On Tue, Apr 21, 2020 at 12:10 PM Nagesh

Re: [pgAdmin][RM3269] Slider jumps up issue in DataView panel

2020-04-21 Thread Akshay Joshi
Thanks, patch applied. On Tue, Apr 21, 2020 at 12:10 PM Nagesh Dhope wrote: > Hi Hackers, > The attached patch fixes an issue where slider jumps up when new rows get > loaded while scrolling down in the DataView panel in the query tool. > Fix uses *rows_affected *field to create dummy rows

[pgAdmin][RM3269] Slider jumps up issue in DataView panel

2020-04-21 Thread Nagesh Dhope
Hi Hackers, The attached patch fixes an issue where slider jumps up when new rows get loaded while scrolling down in the DataView panel in the query tool. Fix uses *rows_affected *field to create dummy rows (Apart from the first *batch of rows). *Dummy rows will be updated as and when they are