Re: [pgAdmin][RM5292] Alertify header buttons focus color issue

2020-03-26 Thread Akshay Joshi
Thanks, patch applied. On Thu, Mar 26, 2020 at 11:00 AM Nagesh Dhope wrote: > Please find an updated patch, which fixes review comments. > > On Thu, Mar 26, 2020 at 10:24 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Nagesh, >> >> I cannot see any change related to

Re: [pgAdmin][RM5292] Alertify header buttons focus color issue

2020-03-25 Thread Nagesh Dhope
Please find an updated patch, which fixes review comments. On Thu, Mar 26, 2020 at 10:24 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Nagesh, > > I cannot see any change related to $active-border variable apart from > !default. Plus, $active-border should not be allowed

Re: [pgAdmin][RM5292] Alertify header buttons focus color issue

2020-03-25 Thread Aditya Toshniwal
Hi Nagesh, I cannot see any change related to $active-border variable apart from !default. Plus, $active-border should not be allowed to edit. It is a structural variable and not a variable which affects theme change. Please revert the $active-border change and send the patch. On Thu, Mar 26,

[pgAdmin][RM5292] Alertify header buttons focus color issue

2020-03-25 Thread Nagesh Dhope
Hi Hackers, Please find a patch which includes 1. Use *btn-secondary* styles for all buttons in alertify dialog header. 2. Added *!default *for $active-border variable, so that it can be overridden if required. 3. Added entry for *.scss *in .editorconfig -- Thanks, Nagesh