Re: [pgAdmin4][Patch]: Fixed RMs #1220 & #1221

On Tue, 8 May 2018, 13:35 Dave Page, wrote: > Could you update the 3.1 release notes to reflect that please? > Sure > > On Mon, May 7, 2018 at 10:40 AM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Thanks patch applied. >> >> On Mon, May 7, 2018 at 12:16 PM, Khushboo Vashi <

Re: [pgAdmin4][Patch]: Fixed RMs #1220 & #1221

Could you update the 3.1 release notes to reflect that please? On Mon, May 7, 2018 at 10:40 AM, Akshay Joshi wrote: > Thanks patch applied. > > On Mon, May 7, 2018 at 12:16 PM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> Please find the attached updated patch. >> >>

Re: [pgAdmin4][Patch]: Fixed RMs #1220 & #1221

Thanks patch applied. On Mon, May 7, 2018 at 12:16 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached updated patch. > > On Thu, May 3, 2018 at 9:02 PM, Dave Page wrote: > >> Hi >> >> On Thu, May 3, 2018 at 10:19 AM, Khushboo Vashi < >> khushboo.va...

Re: [pgAdmin4][Patch]: Fixed RMs #1220 & #1221

Hi, Please find the attached updated patch. On Thu, May 3, 2018 at 9:02 PM, Dave Page wrote: > Hi > > On Thu, May 3, 2018 at 10:19 AM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >> On Wed, May 2, 2018 at 5:56 PM, Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >>

Re: [pgAdmin4][Patch]: Fixed RMs #1220 & #1221

Hi On Thu, May 3, 2018 at 10:19 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Wed, May 2, 2018 at 5:56 PM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Khushboo >> >> I have reviewed your code and looks good to me. Can we change the message >> from "The d

Re: [pgAdmin4][Patch]: Fixed RMs #1220 & #1221

Hi Victoria, On Wed, May 2, 2018 at 9:20 PM, Victoria Henry wrote: > Hi Khushboo, > > Could you write tests for this change? > We don't have any tests for these utilities, so at this point not possible to write the test cases for the same. > These files are actually apart of the ACITree refacto

Re: [pgAdmin4][Patch]: Fixed RMs #1220 & #1221

On Wed, May 2, 2018 at 5:56 PM, Akshay Joshi wrote: > Hi Khushboo > > I have reviewed your code and looks good to me. Can we change the message > from "The database name is inappropriate" to some meaningful message, so > that user should know why it is inappropriate. If user will be able to > cre

Re: [pgAdmin4][Patch]: Fixed RMs #1220 & #1221

On Thu, May 3, 2018 at 7:59 AM, Ashesh Vashi wrote: > On Thu, May 3, 2018 at 12:25 PM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >> On Wed, May 2, 2018 at 6:03 PM, Ashesh Vashi < >> ashesh.va...@enterprisedb.com> wrote: >> >>> On Wed, May 2, 2018 at 5:56 PM, Akshay Joshi

Re: [pgAdmin4][Patch]: Fixed RMs #1220 & #1221

On Thu, May 3, 2018 at 12:25 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Wed, May 2, 2018 at 6:03 PM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> On Wed, May 2, 2018 at 5:56 PM, Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Hi Khushboo >>>

Re: [pgAdmin4][Patch]: Fixed RMs #1220 & #1221

On Wed, May 2, 2018 at 6:03 PM, Ashesh Vashi wrote: > On Wed, May 2, 2018 at 5:56 PM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Khushboo >> >> I have reviewed your code and looks good to me. Can we change the message >> from "The database name is inappropriate" to some meanin

Re: [pgAdmin4][Patch]: Fixed RMs #1220 & #1221

Hi Khushboo, Could you write tests for this change? These files are actually apart of the ACITree refactoring patch. If this patch was already in master the task of adding tests would be much easier. Victoria & Joao On Wed, May 2, 2018 at 8:33 AM, Ashesh Vashi wrote: > On Wed, May 2, 2018 at 5

Re: [pgAdmin4][Patch]: Fixed RMs #1220 & #1221

On Wed, May 2, 2018 at 5:56 PM, Akshay Joshi wrote: > Hi Khushboo > > I have reviewed your code and looks good to me. Can we change the message > from "The database name is inappropriate" to some meaningful message, so > that user should know why it is inappropriate. If user will be able to > cre

Re: [pgAdmin4][Patch]: Fixed RMs #1220 & #1221

Hi Khushboo I have reviewed your code and looks good to me. Can we change the message from "The database name is inappropriate" to some meaningful message, so that user should know why it is inappropriate. If user will be able to create database with "=" in name then why Backup, Maintenance and Re

[pgAdmin4][Patch]: Fixed RMs #1220 & #1221

Hi, Please find the attached patch which will fix RMs # 1220 and #1221. If the database name contains = then the backup, maintenance and restore jobs are failing. To fix these, we will display the error message regarding inappropriate database name. Thanks, Khushboo diff --git a/web/pgadmin/tool