Thanks, patch applied!
On Fri, Jul 6, 2018 at 6:44 AM, Akshay Joshi
wrote:
> Hi
>
> On Thu, Jul 5, 2018 at 7:17 PM, Dave Page wrote:
>
>> Hi
>>
>> Looks good to me - the only remaining issue is that the button still
>> isn't the same colours as the zoom ones. I haven't found all the
>> differen
Hi
On Thu, Jul 5, 2018 at 7:17 PM, Dave Page wrote:
> Hi
>
> Looks good to me - the only remaining issue is that the button still isn't
> the same colours as the zoom ones. I haven't found all the differences, but
> there seems to be an 'opacity: 0.5" on the stats area, and the disabled
> attrib
Hi
Looks good to me - the only remaining issue is that the button still isn't
the same colours as the zoom ones. I haven't found all the differences, but
there seems to be an 'opacity: 0.5" on the stats area, and the disabled
attribute is still being set.
On Thu, Jul 5, 2018 at 11:21 AM, Akshay J
Hi Dave
As per discussion attached is the modified patch with following review
comments has been fixed :
- Hide statistics button if not applicable(no statistics to show).
- Extract 'StatisticsModel' into a separate file and added jasmine test
for this.
On Tue, Jul 3, 2018 at 6:40 PM
Hi Dave,
Please ignore the previous patch, I have made some more changes related to
background colour on enabled/disabled state.
Attached is the modified patch. Please review it.
On Tue, Jul 3, 2018 at 12:35 PM, Akshay Joshi wrote:
> Hi Dave,
>
> On Mon, Jul 2, 2018 at 4:10 PM, Dave Page wrote
Hi Dave,
On Mon, Jul 2, 2018 at 4:10 PM, Dave Page wrote:
> Hi
>
> On Sat, Jun 30, 2018 at 9:15 AM, Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Hi Dave
>>
>> On Fri, Jun 29, 2018 at 7:45 PM, Dave Page wrote:
>>
>>>
>>>
>>> On Fri, Jun 29, 2018 at 3:12 PM, Akshay Joshi <
>>> aksh
Hi Dave
On Fri, Jun 29, 2018 at 7:45 PM, Dave Page wrote:
>
>
> On Fri, Jun 29, 2018 at 3:12 PM, Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Hi Dave
>>
>> On Fri, Jun 29, 2018 at 6:56 PM, Dave Page wrote:
>>
>>> Hi
>>>
>>> On Fri, Jun 29, 2018 at 9:55 AM, Akshay Joshi <
>>> aksh
On Fri, Jun 29, 2018 at 3:12 PM, Akshay Joshi wrote:
> Hi Dave
>
> On Fri, Jun 29, 2018 at 6:56 PM, Dave Page wrote:
>
>> Hi
>>
>> On Fri, Jun 29, 2018 at 9:55 AM, Akshay Joshi <
>> akshay.jo...@enterprisedb.com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Attached is the patch to fix the RM #3397 Add sup
Hi Dave
On Fri, Jun 29, 2018 at 6:56 PM, Dave Page wrote:
> Hi
>
> On Fri, Jun 29, 2018 at 9:55 AM, Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Hi Hackers,
>>
>> Attached is the patch to fix the RM #3397 Add support for JIT stats in
>> EXPLAIN output in PG11. Please review it.
>>
Hi
On Fri, Jun 29, 2018 at 9:55 AM, Akshay Joshi wrote:
> Hi Hackers,
>
> Attached is the patch to fix the RM #3397 Add support for JIT stats in
> EXPLAIN output in PG11. Please review it.
>
A couple of immediate thoughts:
- When the canvas is first rendered, there's a vertical scrollbar now.
Hi Hackers,
Attached is the patch to fix the RM #3397 Add support for JIT stats in
EXPLAIN output in PG11. Please review it.
--
*Akshay Joshi*
*Sr. Software Architect *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
RM_3397.patch
Description: Binary data
11 matches
Mail list logo
