Hi Ashesh,
The issue is still not fixed, the reason is:
In the first patch, I was setting `production` flag in `definePlugin` like:
const definePlugin = new webpack.DefinePlugin({
'process.env': {
'NODE_ENV': JSON.stringify('production'),
},
});
in development mode but we had the
Hi Ashesh,
Can you please review this patch please?
Thanks,
Surinder
On Wed, Aug 16, 2017 at 3:43 PM, Surinder Kumar <
surinder.ku...@enterprisedb.com> wrote:
> Hi,
>
> Updated patch contains changes:
>
>- Enable definePlugin for development environment as well. Just adding
>
Hi,
Updated patch contains changes:
- Enable definePlugin for development environment as well. Just adding
definePlugin in plugins array.
The variable process.env.NODE_ENV is useful to write conditional code in
pgAdmin4 JS modules.
For example:
if (process.env.NODE_ENV !==
Hi Ashesh,
1. Now we are using `envType` variable in definePlugin which sets
environment variable NODE_ENV globally which is used by React to create
development or production build.
where:
envType - determine build type is either `production` or
`development` depending on the environment
On Fri, Jul 28, 2017 at 12:42 PM, Surinder Kumar <
surinder.ku...@enterprisedb.com> wrote:
> Hi,
>
> I inspect the react code and in call stacks, found `process.env.NODE_ENV`
> is undefined due to which 'SyntheticEvent.call' is not callable.
>
> So, to fix this, i add 'definePlugin' to plugins
Ashesh, can you deal with this please? Thanks.
On Fri, Jul 28, 2017 at 8:12 AM, Surinder Kumar <
surinder.ku...@enterprisedb.com> wrote:
> Hi,
>
> I inspect the react code and in call stacks, found `process.env.NODE_ENV`
> is undefined due to which 'SyntheticEvent.call' is not callable.
>
> So,
Hi,
I inspect the react code and in call stacks, found `process.env.NODE_ENV`
is undefined due to which 'SyntheticEvent.call' is not callable.
So, to fix this, i add 'definePlugin' to plugins for `dev` environment in
`webpack.config.js`. Initially it was added only for `production`
environment.
