Re: [pgAdmin4][Patch] - RM 3605 & 2392 - View data fixes

2019-04-18 Thread Akshay Joshi
Thanks patch applied. On Thu, Apr 18, 2019 at 9:31 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Akshay, > > Please find the attached updated patch. > > On Tue, Apr 16, 2019 at 1:05 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Khushboo >> >> Following are

Re: [pgAdmin4][Patch] - RM 3605 & 2392 - View data fixes

2019-04-17 Thread Khushboo Vashi
Hi Akshay, Please find the attached updated patch. On Tue, Apr 16, 2019 at 1:05 PM Akshay Joshi wrote: > Hi Khushboo > > Following are my review comments: > >- Jasmine test case are failing. > > This is due to the Slickgrid upgrade. I will send the separate patch for the same. > >-

Re: [pgAdmin4][Patch] - RM 3605 & 2392 - View data fixes

2019-04-16 Thread Akshay Joshi
Hi Khushboo Following are my review comments: - Jasmine test case are failing. - Create a table with two columns *id bigint (must be primary key) *and *name text. *Insert couple of rows, now select any two rows and mark it for deletion, add new row and then click on *Save* button.

Re: [pgAdmin4][Patch] - RM 3605 & 2392 - View data fixes

2019-04-08 Thread Khushboo Vashi
Hi, Please find the attached updated patch. Thanks, Khushboo On Fri, Apr 5, 2019 at 11:32 AM Akshay Joshi wrote: > Hi Khushboo > > #3605 is fixed and found below issue in #2392 > >- As per steps given in RM, I have perform the same. But when I delete >the row, delete button is still

Re: [pgAdmin4][Patch] - RM 3605 & 2392 - View data fixes

2019-04-05 Thread Akshay Joshi
Hi Khushboo #3605 is fixed and found below issue in #2392 - As per steps given in RM, I have perform the same. But when I delete the row, delete button is still enabled and save button is disabled even though newly created row is still there. Apart from that code looks good to me.

[pgAdmin4][Patch] - RM 3605 & 2392 - View data fixes

2019-04-04 Thread Khushboo Vashi
Hi, Please find the attached patch to fix: 1. #3605 - Edit Data: Deleting N number of rows makes first N number of rows disable 2. #2392 - Datagrid: If we delete any row it also saves newly added row Thanks, Khushboo RM_3605_2392.patch Description: Binary data