Re: [pgAdmin4][patch] extract generate_url function from node.js and collection.js

2017-08-17 Thread Violet Cheng
Great! Thanks a lot. Violet On Fri, Aug 18, 2017 at 12:13 AM, Ashesh Vashi < ashesh.va...@enterprisedb.com> wrote: > On Wed, Aug 16, 2017 at 4:20 PM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> The patch looks good to me. >> >>> Thanks, >> Khushboo >> >> On Fri, Aug

Re: [pgAdmin4][patch] extract generate_url function from node.js and collection.js

2017-08-17 Thread Ashesh Vashi
On Wed, Aug 16, 2017 at 4:20 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > The patch looks good to me. > >> Thanks, > Khushboo > > On Fri, Aug 11, 2017 at 12:08 PM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> On Thu, Aug 10, 2017 at 1:15 PM, Violet Cheng w

Re: [pgAdmin4][patch] extract generate_url function from node.js and collection.js

2017-08-16 Thread Khushboo Vashi
Hi, The patch looks good to me. > Thanks, Khushboo On Fri, Aug 11, 2017 at 12:08 PM, Ashesh Vashi < ashesh.va...@enterprisedb.com> wrote: > On Thu, Aug 10, 2017 at 1:15 PM, Violet Cheng wrote: > >> Hi hackers, >> >> We tried to extract and refactor generate_url function in node.js and >> colle

Re: [pgAdmin4][patch] extract generate_url function from node.js and collection.js

2017-08-15 Thread Violet Cheng
Hi, Is there any update on this patch? Will it be committed soon? Thanks, Violet On Fri, Aug 11, 2017 at 2:38 PM, Ashesh Vashi wrote: > On Thu, Aug 10, 2017 at 1:15 PM, Violet Cheng wrote: > >> Hi hackers, >> >> We tried to extract and refactor generate_url function in node.js and >> collecti

Re: [pgAdmin4][patch] extract generate_url function from node.js and collection.js

2017-08-10 Thread Ashesh Vashi
On Thu, Aug 10, 2017 at 1:15 PM, Violet Cheng wrote: > Hi hackers, > > We tried to extract and refactor generate_url function in node.js and > collection.js. Please see the patch attached. > Khushboo, Please review this one. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise Pos

[pgAdmin4][patch] extract generate_url function from node.js and collection.js

2017-08-10 Thread Violet Cheng
Hi hackers, We tried to extract and refactor generate_url function in node.js and collection.js. Please see the patch attached. Thanks, Violet & Sarah diff --git a/web/pgadmin/browser/static/js/collection.js b/web/pgadmin/browser/static/js/collection.js index f97edcc0..c0cb0eb4 100644 --- a/web/