Re: Build failed in Jenkins: pgadmin4-master-python33 #507

On Thu, Mar 8, 2018 at 3:35 PM, Dave Page wrote: > > > On Thu, Mar 8, 2018 at 9:47 AM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >> On Thu, Mar 8, 2018 at 3:08 PM, Dave Page wrote: >> >>> Well, it looks like Python 3 might be happy now. 2.6 and 2.7 aren't >>> though (whi

Re: Build failed in Jenkins: pgadmin4-master-python33 #507

On Thu, Mar 8, 2018 at 9:47 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Thu, Mar 8, 2018 at 3:08 PM, Dave Page wrote: > >> Well, it looks like Python 3 might be happy now. 2.6 and 2.7 aren't >> though (which is odd, as it passed on my local 2.7). >> >> I am looking into

Re: Build failed in Jenkins: pgadmin4-master-python33 #507

On Thu, Mar 8, 2018 at 3:08 PM, Dave Page wrote: > Well, it looks like Python 3 might be happy now. 2.6 and 2.7 aren't though > (which is odd, as it passed on my local 2.7). > > I am looking into this. Btw, which command do you use to run tests? > On Thu, Mar 8, 2018 at 9:13 AM, Dave Page wrote

Re: Build failed in Jenkins: pgadmin4-master-python33 #507

Well, it looks like Python 3 might be happy now. 2.6 and 2.7 aren't though (which is odd, as it passed on my local 2.7). On Thu, Mar 8, 2018 at 9:13 AM, Dave Page wrote: > Thanks, applied. > > On Thu, Mar 8, 2018 at 4:26 AM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >> O

Re: Build failed in Jenkins: pgadmin4-master-python33 #507

Thanks, applied. On Thu, Mar 8, 2018 at 4:26 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Wed, Mar 7, 2018 at 11:13 PM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi Dave, >> >> Please find the patch to fix this. >> I have fixed this issue in the Star

Re: Build failed in Jenkins: pgadmin4-master-python33 #507

On Wed, Mar 7, 2018 at 11:13 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Dave, > > Please find the patch to fix this. > I have fixed this issue in the StartRunningQueryTest class, this test > class changes the behaviour of the methods through MagicMock and due to > this this

Re: Build failed in Jenkins: pgadmin4-master-python33 #507

Hi Dave, Please find the patch to fix this. I have fixed this issue in the StartRunningQueryTest class, this test class changes the behaviour of the methods through MagicMock and due to this this test case is failing. Thanks, Khushboo On Wed, Mar 7, 2018 at 10:34 PM, Khushboo Vashi < khushboo.v

Re: Build failed in Jenkins: pgadmin4-master-python33 #507

On Wed, Mar 7, 2018 at 10:33 PM, Dave Page wrote: > It still seems to be failing :-( > > :( > https://jenkins.pgadmin.org/job/pgadmin4-master-python26/ > lastFailedBuild/consoleFull > > On Wed, Mar 7, 2018 at 4:50 PM, Dave Page wrote: > >> Thanks, applied. Lets see what happens. >> >> On Wed, M

Re: Build failed in Jenkins: pgadmin4-master-python33 #507

It still seems to be failing :-( https://jenkins.pgadmin.org/job/pgadmin4-master-python26/lastFailedBuild/consoleFull On Wed, Mar 7, 2018 at 4:50 PM, Dave Page wrote: > Thanks, applied. Lets see what happens. > > On Wed, Mar 7, 2018 at 4:37 PM, Khushboo Vashi < > khushboo.va...@enterprisedb.com

Re: Build failed in Jenkins: pgadmin4-master-python33 #507

Thanks, applied. Lets see what happens. On Wed, Mar 7, 2018 at 4:37 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Please find the attached updated patch. > This should work. > > > On Wed, Mar 7, 2018 at 9:46 PM, Dave Page wrote: > >> >> >> On Wed, Mar 7, 2018 at 4:13 PM, Khushbo

Re: Build failed in Jenkins: pgadmin4-master-python33 #507

Please find the attached updated patch. This should work. On Wed, Mar 7, 2018 at 9:46 PM, Dave Page wrote: > > > On Wed, Mar 7, 2018 at 4:13 PM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >> On Wed, Mar 7, 2018 at 9:23 PM, Dave Page wrote: >> >>> Hi >>> >>> On Wed, Mar 7

Re: Build failed in Jenkins: pgadmin4-master-python33 #507

On Wed, Mar 7, 2018 at 4:13 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Wed, Mar 7, 2018 at 9:23 PM, Dave Page wrote: > >> Hi >> >> On Wed, Mar 7, 2018 at 3:10 PM, Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> Hi Dave, >>> >>> On Wed, Mar 7, 2018 at

Re: Build failed in Jenkins: pgadmin4-master-python33 #507

On Wed, Mar 7, 2018 at 9:23 PM, Dave Page wrote: > Hi > > On Wed, Mar 7, 2018 at 3:10 PM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi Dave, >> >> On Wed, Mar 7, 2018 at 7:34 PM, Dave Page wrote: >> >>> Khushboo, can you look at this ASAP please? It passed tests on my >>> m

Re: Build failed in Jenkins: pgadmin4-master-python33 #507

Hi On Wed, Mar 7, 2018 at 3:10 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Dave, > > On Wed, Mar 7, 2018 at 7:34 PM, Dave Page wrote: > >> Khushboo, can you look at this ASAP please? It passed tests on my >> machine, but Jenkins isn't happy. >> >> I have tried to reproduce

Re: Build failed in Jenkins: pgadmin4-master-python33 #507

Hi Dave, On Wed, Mar 7, 2018 at 7:34 PM, Dave Page wrote: > Khushboo, can you look at this ASAP please? It passed tests on my machine, > but Jenkins isn't happy. > > I have tried to reproduce the issue with many combination but couldn't reproduce it. With the help of logs, I have tried to fix it

Re: Build failed in Jenkins: pgadmin4-master-python33 #507

Khushboo, can you look at this ASAP please? It passed tests on my machine, but Jenkins isn't happy. Thanks. On Wed, Mar 7, 2018 at 2:01 PM, pgAdmin 4 Jenkins wrote: > See 507/display/redirect?page=changes> > > Changes: > > [Dave Page]

Build failed in Jenkins: pgadmin4-master-python33 #507

See Changes: [Dave Page] Ensure all messages are retrieved from the server in the Query Tool. -- [...truncated 605.81 KB...] PackageDeleteTestCase