Re: [pgadmin-hackers] detecting serials in 8.1

2006-02-19 Thread Kris Jurka
Andreas Pflug wrote: Kris Jurka wrote: Actually it turns out that whether the schema gets in there or not depends on the search path when the table is created. That's what pgSchema::GetPrefix does too. That's fine as long as you assume that the search path never changes and as long as

Re: [pgadmin-hackers] detecting serials in 8.1

2006-02-19 Thread Andreas Pflug
Kris Jurka wrote: Andreas Pflug wrote: Kris Jurka wrote: 8.1 has changed the default text for serials from something like nextval('public.tab_col_seq'::text) to nextval('tab_col_seq'::regclass) Applied with editing (didn't check for schema). Actually it turns out that whether the schem

Re: [pgadmin-hackers] SVN Commit by dpage: r5003 - in trunk/pgadmin3: . src/base

2006-02-19 Thread Dave Page
-Original Message- From: "Andreas Pflug"<[EMAIL PROTECTED]> Sent: 19/02/06 19:57:13 To: "Kris Jurka"<[EMAIL PROTECTED]> Cc: "dpage@vale-housing.co.uk", "pgadmin-hackers@postgresql.org" Subject: Re: [pgadmin-hackers] SVN Commit by dpage: r5003 - in trunk/pgadmin3: . src/base > Hmpf, see

Re: [pgadmin-hackers] detecting serials in 8.1

2006-02-19 Thread Kris Jurka
Andreas Pflug wrote: Kris Jurka wrote: 8.1 has changed the default text for serials from something like nextval('public.tab_col_seq'::text) to nextval('tab_col_seq'::regclass) Applied with editing (didn't check for schema). Actually it turns out that whether the schema gets in there or not

[pgadmin-hackers] SVN Commit by andreas: r5009 - trunk/pgadmin3/src/schema

2006-02-19 Thread svn
Author: andreas Date: 2006-02-19 20:06:19 + (Sun, 19 Feb 2006) New Revision: 5009 Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=5009&view=rev Log: gtk fix Modified: trunk/pgadmin3/src/schema/pgObject.cpp ---(end of broadcast)

Re: [pgadmin-hackers] detecting serials in 8.1

2006-02-19 Thread Andreas Pflug
Kris Jurka wrote: 8.1 has changed the default text for serials from something like nextval('public.tab_col_seq'::text) to nextval('tab_col_seq'::regclass) Applied with editing (didn't check for schema). + // Technically this serial check can still fail for sequences that + // get cre

Re: [pgadmin-hackers] SVN Commit by dpage: r5003 - in trunk/pgadmin3:

2006-02-19 Thread Andreas Pflug
Kris Jurka wrote: [EMAIL PROTECTED] wrote: Author: dpage Date: 2006-02-17 11:05:34 + (Fri, 17 Feb 2006) New Revision: 5003 Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=5003&view=rev Log: Mask the password when logging the connection string. This crashes for deb

[pgadmin-hackers] SVN Commit by andreas: r5008 - in trunk/pgadmin3: . src/base src/schema

2006-02-19 Thread svn
Author: andreas Date: 2006-02-19 19:56:21 + (Sun, 19 Feb 2006) New Revision: 5008 Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=5008&view=rev Log: Fix serial column detection for 8.1 per Kris Jurka Display column dependencies Modified: trunk/pgadmin3/CHANGELOG tr

[pgadmin-hackers] SVN Commit by andreas: r5007 - in branches/REL-1_4_0_PATCHES/pgadmin3/src: base schema

2006-02-19 Thread svn
Author: andreas Date: 2006-02-19 19:55:48 + (Sun, 19 Feb 2006) New Revision: 5007 Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=5007&view=rev Log: Fix serial column detection for 8.1 per Kris Jurka Modified: branches/REL-1_4_0_PATCHES/pgadmin3/src/base/pgConnBase.c

Re: [pgadmin-hackers] select inside transactions

2006-02-19 Thread Andreas Pflug
Magnus Hagander wrote: I had to revert the patch on pgSetBase.cpp (Rev4986) because to handle the very special case of selects inside transactions when executed in a single step (I'd recommend to execute them step by step) the standard case of a query returning no data (e.g. drop table foo) di

Re: [pgadmin-hackers] select inside transactions

2006-02-19 Thread Magnus Hagander
> I had to revert the patch on pgSetBase.cpp (Rev4986) because > to handle the very special case of selects inside > transactions when executed in a single step (I'd recommend to > execute them step by step) the standard case of a query > returning no data (e.g. drop table foo) didn't return >

[pgadmin-hackers] detecting serials in 8.1

2006-02-19 Thread Kris Jurka
8.1 has changed the default text for serials from something like nextval('public.tab_col_seq'::text) to nextval('tab_col_seq'::regclass) Kris Jurka Index: src/schema/pgColumn.cpp === *** src/schema/pgColumn.cpp (revision 5006) -

Re: [pgadmin-hackers] SVN Commit by dpage: r5003 - in trunk/pgadmin3: . src/base

2006-02-19 Thread Kris Jurka
[EMAIL PROTECTED] wrote: Author: dpage Date: 2006-02-17 11:05:34 + (Fri, 17 Feb 2006) New Revision: 5003 Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=5003&view=rev Log: Mask the password when logging the connection string. This crashes for debug builds. Need to us

Re: [pgadmin-hackers] SVN Commit by dpage: r5000 - in trunk/pgadmin3:

2006-02-19 Thread Andreas Pflug
Kris Jurka wrote: [EMAIL PROTECTED] wrote: Author: dpage Date: 2006-02-17 10:49:24 + (Fri, 17 Feb 2006) New Revision: 5000 Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=5000&view=rev Log: Properly escape single quotes in connection strings. This commit generate

[pgadmin-hackers] SVN Commit by andreas: r5006 - trunk/pgadmin3/src/include/base

2006-02-19 Thread svn
Author: andreas Date: 2006-02-19 17:00:00 + (Sun, 19 Feb 2006) New Revision: 5006 Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=5006&view=rev Log: Fix multiline comment warning Modified: trunk/pgadmin3/src/include/base/base.h ---(end of broa

Re: [pgadmin-hackers] SVN Commit by dpage: r5000 - in trunk/pgadmin3: . src/base src/include/base

2006-02-19 Thread Kris Jurka
[EMAIL PROTECTED] wrote: Author: dpage Date: 2006-02-17 10:49:24 + (Fri, 17 Feb 2006) New Revision: 5000 Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=5000&view=rev Log: Properly escape single quotes in connection strings. This commit generates a warning all over t

[pgadmin-hackers] SVN Commit by andreas: r5005 - in trunk/pgadmin3: . src/base src/frm

2006-02-19 Thread svn
Author: andreas Date: 2006-02-19 15:37:57 + (Sun, 19 Feb 2006) New Revision: 5005 Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=5005&view=rev Log: Rearrange "view data" position in toolbar/menu Revert 4986 "Allow SELECT inside xact.." to have messages back Modified:

[pgadmin-hackers] select inside transactions

2006-02-19 Thread Andreas Pflug
I had to revert the patch on pgSetBase.cpp (Rev4986) because to handle the very special case of selects inside transactions when executed in a single step (I'd recommend to execute them step by step) the standard case of a query returning no data (e.g. drop table foo) didn't return messages any