Re: Fwd: [pgadmin-hackers] Editing date values in frmEditGrid

2010-09-02 Thread Guillaume Lelarge
Le 02/09/2010 10:17, Guillaume Lelarge a écrit : > Le 01/09/2010 21:32, Steffen Kuhn a écrit : >> Hi Dave, >> >> this seems to be a Windows only problem. >> I could check this for: >> Ubuntu - works fine without the need of patch >> Windows Vista & XP - strange behavior; fixed by a few pixels more

[pgadmin-hackers] pgAdmin III commit: Fix an issue when editing date value in frmEditGrid

2010-09-02 Thread Guillaume Lelarge
Fix an issue when editing date value in frmEditGrid There was a bug which makes the date value invisible. Adding two pixels to the height of the widget fixes that. Patch from Steffen Kuhn. Branch -- REL-1_12_0_PATCHES Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitd

[pgadmin-hackers] pgAdmin III commit: Fix an issue when editing date value in frmEditGrid

2010-09-02 Thread Guillaume Lelarge
Fix an issue when editing date value in frmEditGrid There was a bug which makes the date value invisible. Adding two pixels to the height of the widget fixes that. Patch from Steffen Kuhn. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=ec4098

Re: [pgadmin-hackers] Problem with insert - 1.12.0 RC1

2010-09-02 Thread Guillaume Lelarge
Le 02/09/2010 13:59, Dave Page a écrit : > On Thu, Sep 2, 2010 at 12:30 PM, Guillaume Lelarge > wrote: >> Le 02/09/2010 10:28, Dave Page a écrit : >>> Anyway, can the code in the edit grid be modified to detect the empty >>> pgSet in place of null? >>> >> >> Yeah, by checking how many rows were in

[pgadmin-hackers] pgAdmin III commit: Check the number of rows inserted in frmEditGrid

2010-09-02 Thread Guillaume Lelarge
Check the number of rows inserted in frmEditGrid A previous commit (6b3b661244455951fccbed7895aa22fa7c2ed2a2) modified the return value of ExecuteSet from null to an empty pgSet when the query failed. So, we have to check the number of rows inserted to make sure the INSERT was successful. Report

[pgadmin-hackers] pgAdmin III commit: Check the number of rows inserted in frmEditGrid

2010-09-02 Thread Guillaume Lelarge
Check the number of rows inserted in frmEditGrid A previous commit (6b3b661244455951fccbed7895aa22fa7c2ed2a2) modified the return value of ExecuteSet from null to an empty pgSet when the query failed. So, we have to check the number of rows inserted to make sure the INSERT was successful. Report

Re: [pgadmin-hackers] Problem with insert - 1.12.0 RC1

2010-09-02 Thread Dave Page
On Thu, Sep 2, 2010 at 12:30 PM, Guillaume Lelarge wrote: > Le 02/09/2010 10:28, Dave Page a écrit : >> Anyway, can the code in the edit grid be modified to detect the empty >> pgSet in place of null? >> > > Yeah, by checking how many rows were inserted. See patch attached. It > fixes the issue. N

Re: [pgadmin-hackers] Problem with insert - 1.12.0 RC1

2010-09-02 Thread Guillaume Lelarge
Le 02/09/2010 10:28, Dave Page a écrit : > On Thu, Sep 2, 2010 at 9:16 AM, Guillaume Lelarge > wrote: >> In pgadmin/db/pgConn.cpp, method ExecuteSet, the line "return 0;" is >> replaced with "return new pgSet();". It fouls the frmEditGrid window, >> which thinks it has a valid return, and displays

Re: [pgadmin-hackers] Problem with insert - 1.12.0 RC1

2010-09-02 Thread Dave Page
On Thu, Sep 2, 2010 at 9:16 AM, Guillaume Lelarge wrote: > In pgadmin/db/pgConn.cpp, method ExecuteSet, the line "return 0;" is > replaced with "return new pgSet();". It fouls the frmEditGrid window, > which thinks it has a valid return, and displays an empty line. I have > no idea why this was ch

Re: Fwd: [pgadmin-hackers] Editing date values in frmEditGrid

2010-09-02 Thread Guillaume Lelarge
Le 01/09/2010 21:32, Steffen Kuhn a écrit : > Hi Dave, > > this seems to be a Windows only problem. > I could check this for: > Ubuntu - works fine without the need of patch > Windows Vista & XP - strange behavior; fixed by a few pixels more for > DefaultRowSize and attached patch > Working on t

Re: [pgadmin-hackers] Problem with insert - 1.12.0 RC1

2010-09-02 Thread Guillaume Lelarge
Le 02/09/2010 03:10, Erwin Brandstetter a écrit : > On 02.09.2010 01:14, Guillaume Lelarge wrote: >> Le 02/09/2010 00:41, Erwin Brandstetter a écrit : >>> On Aug 31, 7:19 pm,[email protected] (Sid) wrote: Hi, ~~~ Local installation: Windows