Re: [pgadmin-hackers] Save Query in frmEditGrid

2010-09-14 Thread Steffen Kuhn
Hi Guillaume, I tested it a bit. Your patch solves the issue: open editor, bringing a cell in editmode, do not change and then close the editor. - Really editing some values and then pressing 'ESC' does the same as 'Undo' with the new behaviour, - Really editing a value and the getting editmode

Re: [pgadmin-hackers] [pgAdmin III] #232: Smart defaults for new connection in query tool

2010-09-14 Thread Erwin Brandstetter
On Sep 9, 11:34 pm, t...@code.pgadmin.org ("pgAdmin Trac") wrote: > #232: Smart defaults for new connection in query tool (...) > Comment(by gleu): > >  Patch at >  http://github.com/gleu/pgadmin3/commit/8c358a7ead668bc7b2f7c845ab83b4... I am not fluent in C, but from what I see, that should do th

Re: [pgadmin-hackers] Fwd: pgAdmin 1.12 rc1 editing issue frmEditGrid

2010-09-14 Thread Guillaume Lelarge
Le 13/09/2010 21:21, Guillaume Lelarge a écrit : > Hi Steffen, > > First, I'm really sorry. I should have answer you in your private mail. > > Le 13/09/2010 20:02, Steffen Kuhn a écrit : >> [...] >> I could track down this issue a 'bit' more, it seems to be a linux only >> issue, in my case ubunt

Re: [pgadmin-hackers] Save Query in frmEditGrid

2010-09-14 Thread Guillaume Lelarge
Le 14/09/2010 13:09, Steffen Kuhn a écrit : > Hi Guillaume, > > checking for changed values is what I tried to, but my place was > sqlGridEditor::EndEdit because this is already checked there. Oh, yeah, I didn't see that. You're right. > But checking here, may be also in OnEditorHidden can be d

Re: [pgadmin-hackers] Save Query in frmEditGrid

2010-09-14 Thread Steffen Kuhn
Hi Guillaume, checking for changed values is what I tried to, but my place was sqlGridEditor::EndEdit because this is already checked there. But checking here, may be also in OnEditorHidden can be dangerous I think, because of there might be previous changes that might be lost by just disableing