Re: [pgadmin-hackers] wxWidgets 2.9 build

2011-01-31 Thread Peter Geoghegan
On 31 January 2011 20:27, Dave Page wrote: > I tried it on VC++ and it didn't complain. Didn't test gcc though. Can you produce a test case? I wasn't aware that it is possible to use the preprocessor to define C++ member function macros. > If it's not used, it can go. Good, done. >> I would li

[pgadmin-hackers] [pgAdmin III] #300: Add support for ALTER TABLE ADD UNIQUE/PRIMARY KEY USING INDEX.

2011-01-31 Thread pgAdmin Trac
#300: Add support for ALTER TABLE ADD UNIQUE/PRIMARY KEY USING INDEX. ---+ Reporter: gleu | Owner: dpage Type: feature| Status: new Priority: minor | Milestone: Component: pgadm

Re: [pgadmin-hackers] [pgAdmin III] #142: Support for SQL/Med objects

2011-01-31 Thread pgAdmin Trac
#142: Support for SQL/Med objects -+-- Reporter: gleu | Owner: gleu Type: feature | Status: assigned Priority: minor| Milestone: Component: pgadmin | Version: 1.12 Key

Re: [pgadmin-hackers] Bug in master when refreshing constraints node (though only when collapsed and with --enable-debug)

2011-01-31 Thread Peter Geoghegan
On 31 January 2011 23:00, Guillaume Lelarge wrote: > The tree has a big bug in its refresh, and noone has yet been able to > fix it. > > If you can give it a go, I'm more than happy about it. Seems like the kind of thing that is likely to require outside expertise. I'd like to have a go. I'll put

Re: [pgadmin-hackers] Bug in master when refreshing constraints node (though only when collapsed and with --enable-debug)

2011-01-31 Thread Guillaume Lelarge
Le 31/01/2011 23:43, Peter Geoghegan a écrit : > On 31 January 2011 21:22, Dave Page wrote: >> A couple of thoughts: >> >> - I committed a fix for a *very* similar issue (the same assertion) >> here: >> http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=9ec6b29fe3fbd9cc196d5e91b55f369

Re: [pgadmin-hackers] Bug in master when refreshing constraints node (though only when collapsed and with --enable-debug)

2011-01-31 Thread Peter Geoghegan
On 31 January 2011 21:22, Dave Page wrote: > A couple of thoughts: > > - I committed a fix for a *very* similar issue (the same assertion) > here: > http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=9ec6b29fe3fbd9cc196d5e91b55f3697f02bcad8 > > - Magnus reported another similar issue

Re: [pgadmin-hackers] Bug in master when refreshing constraints node (though only when collapsed and with --enable-debug)

2011-01-31 Thread Dave Page
On Mon, Jan 31, 2011 at 9:10 PM, Peter Geoghegan wrote: > I've found an odd bug that is only apparent in --enable-debug builds. > It's not clear that it's a PgAdmin bug. It's rather difficult to get a > useful back trace when the code that exhibits the bug is hidden behind > event loop indirection

[pgadmin-hackers] Bug in master when refreshing constraints node (though only when collapsed and with --enable-debug)

2011-01-31 Thread Peter Geoghegan
I've found an odd bug that is only apparent in --enable-debug builds. It's not clear that it's a PgAdmin bug. It's rather difficult to get a useful back trace when the code that exhibits the bug is hidden behind event loop indirection, and I'm still not very familiar with the codebase, so I though

Re: [pgadmin-hackers] wxWidgets 2.9 build

2011-01-31 Thread Dave Page
On Mon, Jan 31, 2011 at 3:35 PM, Peter Geoghegan wrote: > On 31 January 2011 13:02, Dave Page wrote: >> Similarly, I dislike uglifying code if we can help it - and this seems >> like a common enough case to me that a macro isn't the end of the >> world to improve readability. > > Bear in mind tha

Re: [pgadmin-hackers] wxWidgets 2.9 build

2011-01-31 Thread Peter Geoghegan
On 31 January 2011 13:02, Dave Page wrote: > Similarly, I dislike uglifying code if we can help it - and this seems > like a common enough case to me that a macro isn't the end of the > world to improve readability. Bear in mind that we don't have to live with those casts forever - when we drop 2

[pgadmin-hackers] pgAdmin III commit: Fix a bug in the way that stored procedures and fun

2011-01-31 Thread Dave Page
Fix a bug in the way that stored procedures and functions are identified in EDB Advanced Server, that could yield incorrect results Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=8c383d55956eb3a8c4aee57fc29126795b1c3c57 Author: Nikhil S Modi

[pgadmin-hackers] pgAdmin III commit: Fix a bug in the way that stored procedures and fun

2011-01-31 Thread Dave Page
Fix a bug in the way that stored procedures and functions are identified in EDB Advanced Server, that could yield incorrect results Branch -- REL-1_12_0_PATCHES Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=6861d498b619b39d0a083da115b8beaf1b771b89 Author: Nik

Re: [pgadmin-hackers] pgAdmin III: EDB procedures with non void return types not handled properly

2011-01-31 Thread Nikhil S
> Thanks. This seems to be a bug in fact, as it could mis-identify a > function that returns void as a procedure. > > Applied for 1.12.3 and master. > > Thanks Dave. Regards, Nikhils

Re: [pgadmin-hackers] pgAdmin III: EDB procedures with non void return types not handled properly

2011-01-31 Thread Dave Page
On Mon, Jan 31, 2011 at 7:17 AM, Nikhil S wrote: > Hi, > > With the latest refactorings in the EDBAS90 source base, procedures (CREATE > PROCEDURE objects) can have non void return types in some cases. For > example: > > edb=# create or replace procedure set_Order ( >     v_index    INOUT  int

Re: [pgadmin-hackers] wxWidgets 2.9 build

2011-01-31 Thread Dave Page
On Sat, Jan 29, 2011 at 6:08 PM, Peter Geoghegan wrote: > We're following the documented way of getting 2.8 and 2.9 > compatibility here. I generally dislike using macros for things like > this when working in C++. Similarly, I dislike uglifying code if we can help it - and this seems like a comm