This commit has eliminated the remaining OGL related warnings that I
mentioned on the main phase 2 thread, that are described here:
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39159.
I now build pgAdmin warning free on g++ 4.5.1.
I incorrectly assumed that attributes were consistent between
decla
I hesitate to substantially change the existing headers, which have
Julian's old copyright - this might be useful in the future.
What do you think?
I've noticed that OGL has mac style \r line endings. I'd like to
change this, if only because it causes the web interface to git from
displaying dirt
Do you think you can produce a Cocoa build? How much of a difference
will that have on pgAdmin's look and feel on Mac? It would be nice to
see a few screenshots of that.
--
Regards,
Peter Geoghegan
--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your
On Wed, Feb 16, 2011 at 8:52 PM, Peter Geoghegan
wrote:
> OGL source files incorrectly indicate that they're wxWindows licensed.
> How would you like to fix this?
We should probably replace the headers with our standard ones, but
include a copyright line naming Julian - much like the PG ones:
*
OGL source files incorrectly indicate that they're wxWindows licensed.
How would you like to fix this?
--
Regards,
Peter Geoghegan
--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
On Wed, Feb 16, 2011 at 8:04 PM, Peter Geoghegan
wrote:
> On 16 February 2011 19:59, Dave Page wrote:
>> Thanks applied - and then fixed on Windows :-)
>>
>> Next step - try a build with 2.9!
>>
>
> Cool. Don't forget - you need to build against wx SVN head.
I did - the one I checked out last we
On 16 February 2011 19:59, Dave Page wrote:
> Thanks applied - and then fixed on Windows :-)
>
> Next step - try a build with 2.9!
>
Cool. Don't forget - you need to build against wx SVN head.
--
Regards,
Peter Geoghegan
--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org
Thanks applied - and then fixed on Windows :-)
Next step - try a build with 2.9!
On Wed, Feb 16, 2011 at 6:34 PM, Peter Geoghegan
wrote:
> I've attached a new patch that applies cleanly. All existing patches
> from me that have not been applied yet should not be applied,
> including the one I se
Ensure the embedded version of OGL builds properly on Windows. While
we're here, update the installer, and the wxWidgets build script.
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=bc38a18228e9717e7157eccb484adf506b5933bd
Modified Files
-
Another set of wx2.9 updates. This patch includes the merge of wxOGL
into our source tree, under the PostgreSQL Licence, with the permission
of the author Julian Smart.
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=573638f4d1b3838cc803b0e73dc3
On Wed, Feb 16, 2011 at 6:50 PM, Peter Geoghegan
wrote:
> On 16 February 2011 18:42, Dave Page wrote:
>> The main issue I have with that is that we now have a bunch of
>> overloaded Write() members, and WriteBool(). If we're going to deviate
>> away from the API in wxConfig (which at least is pri
On 16 February 2011 18:42, Dave Page wrote:
> The main issue I have with that is that we now have a bunch of
> overloaded Write() members, and WriteBool(). If we're going to deviate
> away from the API in wxConfig (which at least is private), then we
> should do so consistently.
>
> FYI, in wxPyth
On Wed, Feb 16, 2011 at 4:20 PM, Peter Geoghegan
wrote:
> On 16 February 2011 15:47, Dave Page wrote:
>> Include a variant of sysSettings::Write() that takes a wxChar* value
>> to write, as they are currently being cast to bools and stored as
>> true/false.
>
> I anticipated this, and my latest p
On 16 February 2011 15:47, Dave Page wrote:
> Include a variant of sysSettings::Write() that takes a wxChar* value
> to write, as they are currently being cast to bools and stored as
> true/false.
I anticipated this, and my latest patch doesn't have this problem -
it's the same situation as ctlLi
Thanks - I've committed a fix for this, that hopefully didn't break
anything else!
On Tue, Feb 15, 2011 at 10:40 AM, Timon wrote:
> This commit 8f9c483868c587cc2ac6332a927338426ae9836c broke an ability
> to suppress different guru hints.
>
> reproduce steps.
> 1. remove [Hints] from .pgadmin3
> 2
Include a variant of sysSettings::Write() that takes a wxChar* value
to write, as they are currently being cast to bools and stored as
true/false.
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=6045df09a32326504720d4a165fb81cc7949c05d
Modified
On Wed, Feb 16, 2011 at 1:38 PM, Peter Geoghegan
wrote:
> Oh, okay.
>
> It doesn't actually build against 2.9 yet, due to a lack of this,
> because someone subsequently broke 2.9 compatibility:
That would be me :-p
> // Handle, and pass up child focus events
> void ctlAuiNotebook::OnChildFocus
Oh, okay.
It doesn't actually build against 2.9 yet, due to a lack of this,
because someone subsequently broke 2.9 compatibility:
// Handle, and pass up child focus events
void ctlAuiNotebook::OnChildFocus(wxChildFocusEvent &event)
{
+
+#if wxCHECK_VERSION(2, 9, 0)
+ wxAuiNotebook
On Wed, Feb 16, 2011 at 1:21 PM, Peter Geoghegan
wrote:
> uh, what about the patch I sent you last night,
> patch_with_ogl.patch.gz? It integrated OGL into our tree.
>
Gimme a chance - that was code which was in my tree when I applied
Nikhil's patch from last week! Yours is further back in the qu
Revert change to cast, per Peter.
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=302b4736d5532345b3d5861429e23b11437ab196
Modified Files
--
pgadmin/frm/frmQuery.cpp |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
--
S
uh, what about the patch I sent you last night,
patch_with_ogl.patch.gz? It integrated OGL into our tree.
By the way, this shouldn't have been changed, and has been changed
back in that patch:
//Create SQL editor notebook
sqlNotebook = new ctlAuiNotebook(this, CTL_NTBKCENTER,
wxDefaultPos
On Wed, Feb 16, 2011 at 1:04 PM, Thom Brown wrote:
> On 16 February 2011 13:03, Dave Page wrote:
>> On Wed, Feb 16, 2011 at 12:56 PM, Thom Brown wrote:
>>> On 16 February 2011 12:54, Dave Page wrote:
Somehow forgot to commit this.
Branch
--
master
Details
On 16 February 2011 13:03, Dave Page wrote:
> On Wed, Feb 16, 2011 at 12:56 PM, Thom Brown wrote:
>> On 16 February 2011 12:54, Dave Page wrote:
>>> Somehow forgot to commit this.
>>>
>>> Branch
>>> --
>>> master
>>>
>>> Details
>>> ---
>>> http://git.postgresql.org/gitweb?p=pgadmin3.git
On Wed, Feb 16, 2011 at 12:56 PM, Thom Brown wrote:
> On 16 February 2011 12:54, Dave Page wrote:
>> Somehow forgot to commit this.
>>
>> Branch
>> --
>> master
>>
>> Details
>> ---
>> http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=9b1673f4efc1ebcbf40750af1cfaede2da753380
Thanks Dave!
> On Mon, Feb 14, 2011 at 12:53 PM, Nikhil S wrote:
> >
> >> > Ok. One way that I can think of is that since we have the typeoids
> >> > handily
> >> > available, we can check the same and see if it is of stringlike type
> >> > (PGOID_TYPE_CHAR, PGOID_TYPE_NAME, PGOID_TYPE_TEXT, et
On 16 February 2011 12:54, Dave Page wrote:
> Somehow forgot to commit this.
>
> Branch
> --
> master
>
> Details
> ---
> http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=9b1673f4efc1ebcbf40750af1cfaede2da753380
> Author: Peter Geoghegan
>
> Modified Files
> --
>
Thanks - applied.
On Mon, Feb 14, 2011 at 12:53 PM, Nikhil S wrote:
>
>> > Ok. One way that I can think of is that since we have the typeoids
>> > handily
>> > available, we can check the same and see if it is of stringlike type
>> > (PGOID_TYPE_CHAR, PGOID_TYPE_NAME, PGOID_TYPE_TEXT, etc..). If
Somehow forgot to commit this.
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=9b1673f4efc1ebcbf40750af1cfaede2da753380
Author: Peter Geoghegan
Modified Files
--
acinclude.m4|4 ++--
pgadmin/frm/frmQuery.cpp|
Use function parameter default values as defaults in the debugger.
Branch
--
master
Details
---
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=c5f1359e31768e9efe18df481087740ea9b3f136
Author: Nikhil S
Modified Files
--
CHANGELOG
29 matches
Mail list logo
