Re: [pgadmin-hackers] pgAdmin III commit: Revert the previous change that introduced sysSetti

2011-02-17 Thread Dave Page
On Thu, Feb 17, 2011 at 2:59 PM, Peter Geoghegan wrote: > Whoops. I had a false sense of security from ctlListView, where the > ambiguity between which is the preferred cast from the double and long > overloads prevents AppendItem(true) type calls from compiling at all. > I thought that there were

Re: [pgadmin-hackers] pgAdmin III commit: Revert the previous change that introduced sysSetti

2011-02-17 Thread Peter Geoghegan
Whoops. I had a false sense of security from ctlListView, where the ambiguity between which is the preferred cast from the double and long overloads prevents AppendItem(true) type calls from compiling at all. I thought that there were no such calls to Write() overloads here - however, there was an

Re: [pgadmin-hackers] pgAdmin III commit: Revert the previous change that introduced sysSetti

2011-02-17 Thread Dave Page
On Thu, Feb 17, 2011 at 1:14 PM, Peter Geoghegan wrote: > On 17 February 2011 11:33, Dave Page wrote: >> Hi Peter; >> >> Just so you're aware of this... > > I don't mind, but I also don't understand. How could changing the name > of the function possibly affect the sort of datatype stored in the

Re: [pgadmin-hackers] pgAdmin III commit: Revert the previous change that introduced sysSetti

2011-02-17 Thread Peter Geoghegan
On 17 February 2011 11:33, Dave Page wrote: > Hi Peter; > > Just so you're aware of this... I don't mind, but I also don't understand. How could changing the name of the function possibly affect the sort of datatype stored in the registry? -- Regards, Peter Geoghegan -- Sent via pgadmin-hacke

Re: [pgadmin-hackers] pgAdmin III commit: Revert the previous change that introduced sysSetti

2011-02-17 Thread Dave Page
Hi Peter; Just so you're aware of this... On Thu, Feb 17, 2011 at 11:31 AM, Dave Page wrote: > Revert the previous change that introduced sysSettings::WriteBool(), > and restore the previous Write() overload. Whilst the change was, in > theory, good, it failed to take into account that users of

[pgadmin-hackers] pgAdmin III commit: Revert the previous change that introduced sysSetti

2011-02-17 Thread Dave Page
Revert the previous change that introduced sysSettings::WriteBool(), and restore the previous Write() overload. Whilst the change was, in theory, good, it failed to take into account that users of previous versions of pgAdmin would have true/false values stored in the Windows registry as REG_SZ val

Re: [pgadmin-hackers] phase 2 of wxWidgets 2.9 build

2011-02-17 Thread Dave Page
On Wed, Feb 16, 2011 at 10:41 PM, Peter Geoghegan wrote: > Do you think you can produce a Cocoa build? How much of a difference > will that have on pgAdmin's look and feel on Mac? It would be nice to > see a few screenshots of that. Seems like SVN Trunk of wxWidgets is broken :-(. I haven't had a

Re: [pgadmin-hackers] wxOGL licence change

2011-02-17 Thread Dave Page
On Thu, Feb 17, 2011 at 2:40 AM, Peter Geoghegan wrote: > I hesitate to substantially change the existing headers, which have > Julian's old copyright - this might be useful in the future. > > What do you think? Well, we can add ours above them I suppose. I'm not that worried about keeping them t

[pgadmin-hackers] pgAdmin III commit: Make style.

2011-02-17 Thread Dave Page
Make style. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=923d03dcb981dd845766b3a9610fef6537d26730 Modified Files -- pgadmin/ctl/ctlAuiNotebook.cpp |2 +- pgadmin/gqb/gqbController.cpp |4 +- pgadmin/include/ogl/basic.h

Re: [pgadmin-hackers] pgAdmin III commit: Ensure the embedded version of OGL builds properly

2011-02-17 Thread Dave Page
On Thu, Feb 17, 2011 at 2:57 AM, Peter Geoghegan wrote: > This commit has eliminated the remaining OGL related warnings that I > mentioned on the main phase 2 thread, that are described here: > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39159. > > I now build pgAdmin warning free on g++ 4.5.1. >