[pgadmin-hackers] Beta 3 tomorrow - maybe

2011-07-07 Thread Dave Page
Looks like we'll probably be building PG 9.1b3 tomorrow, so I'll wrap pgAdmin 1.14b3 immediately beforehand if so. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing

Re: [pgadmin-hackers] Prevent function rewrite when changing owner

2011-07-07 Thread Thom Brown
On 8 July 2011 01:18, Dave Page wrote: > Thanks - patch applied. Cheers! Thom -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin III commit: Prep for beta 3.

2011-07-07 Thread Dave Page
Prep for beta 3. Branch -- REL-1_14_0_PATCHES Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=4def3ce2d40e77ce1c211365b67fd8d7ba404648 Modified Files -- pgadmin/include/version.h |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) -- S

Re: [pgadmin-hackers] Prevent function rewrite when changing owner

2011-07-07 Thread Dave Page
Thanks - patch applied. On Fri, Jul 8, 2011 at 1:04 AM, Thom Brown wrote: > Hi all, > > Tiny patch attached to prevent a function being completely rewritten > when just the owner changes.  Not sure if you regard it as a bug fix > or merely an efficiency feature. > > -- > Thom Brown > Twitter: @da

[pgadmin-hackers] pgAdmin III commit: Don't rewrite entire functions when changing the ow

2011-07-07 Thread Dave Page
Don't rewrite entire functions when changing the owner. Branch -- REL-1_14_0_PATCHES Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=6d4d50187be9e90754168846741b2ce56965bb3f Author: Thom Brown Modified Files -- pgadmin/dlg/dlgFunction.cpp |1 -

[pgadmin-hackers] pgAdmin III commit: Don't rewrite entire functions when changing the ow

2011-07-07 Thread Dave Page
Don't rewrite entire functions when changing the owner. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=709de45a9c8f2cb268eb3a2a5c46426bb55b7576 Author: Thom Brown Modified Files -- pgadmin/dlg/dlgFunction.cpp |1 - 1 files chan

[pgadmin-hackers] pgAdmin III commit: Add a missing ;

2011-07-07 Thread Dave Page
Add a missing ; Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=fdd3a163b789d092fa2aa06b0240698ab9fe087b Modified Files -- pgadmin/pgAdmin3.cpp |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- Sent via pgadmin-hacker

[pgadmin-hackers] Prevent function rewrite when changing owner

2011-07-07 Thread Thom Brown
Hi all, Tiny patch attached to prevent a function being completely rewritten when just the owner changes. Not sure if you regard it as a bug fix or merely an efficiency feature. -- Thom Brown Twitter: @darkixion IRC (freenode): dark_ixion Registered Linux user: #516935 EnterpriseDB UK: http://

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-07 Thread Thom Brown
On 7 July 2011 23:20, Guillaume Lelarge wrote: > On Wed, 2011-07-06 at 11:59 +0100, Thom Brown wrote: >> add_schemas_to_all_items_filtered.patch - same patch as before, but >> with the above patch contents removed or adjusted to assume the fixes >> have been applied. >> > > Not yet done. I'll try

Re: [pgadmin-hackers] [FEATURE] Add schema option to all relevant objects

2011-07-07 Thread Guillaume Lelarge
On Wed, 2011-07-06 at 11:59 +0100, Thom Brown wrote: > On 5 July 2011 20:47, Guillaume Lelarge wrote: > > On Tue, 2011-07-05 at 20:23 +0100, Thom Brown wrote: > >> but left it where it > >> was. In order to implement these changes, I had to also fix quite a > >> few bugs, and while I was at it,

[pgadmin-hackers] pgAdmin III commit: Fix quote name for FTS objects

2011-07-07 Thread Guillaume Lelarge
Fix quote name for FTS objects These remove the overloading of the GetQuotedIdentifier() function which fail to quote the object name. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=7a109a414162cd8705d7fb29727ce5f079a6b9a0 Author: Thom Brown

[pgadmin-hackers] pgAdmin III commit: Fix quote name for FTS objects

2011-07-07 Thread Guillaume Lelarge
Fix quote name for FTS objects These remove the overloading of the GetQuotedIdentifier() function which fail to quote the object name. Branch -- REL-1_14_0_PATCHES Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=794ee2183bc3c4374a37a51b9d0e9c573101e279 Author:

[pgadmin-hackers] pgAdmin III commit: Fix changing new owner for FTS objects

2011-07-07 Thread Guillaume Lelarge
Fix changing new owner for FTS objects Per report from Thom Brown. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=8e9dd6145120f37ea655eddd73279db41161300b Modified Files -- pgadmin/dlg/dlgTextSearchConfiguration.cpp |1 + pgadm

[pgadmin-hackers] pgAdmin III commit: Fix changing new owner for FTS objects

2011-07-07 Thread Guillaume Lelarge
Fix changing new owner for FTS objects Per report from Thom Brown. Branch -- REL-1_14_0_PATCHES Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=ed6c89ef1aee5c253e1a0fb40a4e371b905002c0 Modified Files -- pgadmin/dlg/dlgTextSearchConfiguration.cpp |

[pgadmin-hackers] pgAdmin III commit: Fix invalid syntax when renaming FTS objects

2011-07-07 Thread Guillaume Lelarge
Fix invalid syntax when renaming FTS objects Branch -- REL-1_14_0_PATCHES Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=c412fb5cfe72fdb355e2add43a05824083c615e5 Author: Thom Brown Modified Files -- pgadmin/dlg/dlgTextSearchConfiguration.cpp |

[pgadmin-hackers] pgAdmin III commit: Fix invalid syntax when renaming FTS objects

2011-07-07 Thread Guillaume Lelarge
Fix invalid syntax when renaming FTS objects Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=679295084ffd7ec302f2f84509b6e7cf70ce9985 Author: Thom Brown Modified Files -- pgadmin/dlg/dlgTextSearchConfiguration.cpp |2 +- pgadmin

Re: [pgadmin-hackers] [pgAdmin III] #325: Wrong statistics for overloaded functions

2011-07-07 Thread pgAdmin Trac
#325: Wrong statistics for overloaded functions --+- Reporter: brsa | Owner: gleu Type: bug | Status: closed Priority: minor| Milestone: 1.14 Component: pgadmin |

Re: [pgadmin-hackers] [pgAdmin III] #325: Wrong statistics for overloaded functions

2011-07-07 Thread pgAdmin Trac
#325: Wrong statistics for overloaded functions +--- Reporter: brsa| Owner: gleu Type: bug | Status: assigned Priority: minor | Milestone: Component: pgadmin |

Re: [pgadmin-hackers] Wrong statistics for overloaded functions

2011-07-07 Thread Guillaume Lelarge
On Thu, 2011-07-07 at 14:08 +0200, Erwin Brandstetter wrote: > On 07.07.2011 08:52, Guillaume Lelarge wrote: > > On Wed, 2011-07-06 at 21:22 +0200, Erwin Brandstetter wrote: > >> Aloha! > >> > >> I have been observing irregularities in the function statistics for some > >> time. Now I have investi

[pgadmin-hackers] pgAdmin III commit: Fix display of a function's statistics

2011-07-07 Thread Guillaume Lelarge
Fix display of a function's statistics We cannot rely on the name f the function because of the overloading feature in PostgreSQL. So we now use the OID for filtering. Fixes #325. Report from Erwin Brandstetter. Branch -- REL-1_14_0_PATCHES Details --- http://git.postgresql.org/gitweb?

[pgadmin-hackers] pgAdmin III commit: Fix display of a function's statistics

2011-07-07 Thread Guillaume Lelarge
Fix display of a function's statistics We cannot rely on the name f the function because of the overloading feature in PostgreSQL. So we now use the OID for filtering. Fixes #325. Report from Erwin Brandstetter. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.g

[pgadmin-hackers] [pgAdmin III] #326: Check availabiliy of new pgadmin's version

2011-07-07 Thread pgAdmin Trac
#326: Check availabiliy of new pgadmin's version -+-- Reporter: gleu | Owner: dpage Type: feature | Status: new Priority: minor| Milestone: Component: pgadmin | Version: trunk

[pgadmin-hackers] pgAdmin III commit: Ensure the query complete notification is sent when

2011-07-07 Thread Dave Page
Ensure the query complete notification is sent when the query tool is minimised. Primarily for Mac, where IsActive() seems to be unreliable with wxAuiNotebooks in use. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=35c4fa1f7ad8a7170a2d7d4443aad

[pgadmin-hackers] pgAdmin III commit: Ensure the query complete notification is sent when

2011-07-07 Thread Dave Page
Ensure the query complete notification is sent when the query tool is minimised. Primarily for Mac, where IsActive() seems to be unreliable with wxAuiNotebooks in use. Branch -- REL-1_14_0_PATCHES Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=9964e86abbcf07773

Re: [pgadmin-hackers] [pgAdmin III] #325: Wrong statistics for overloaded functions

2011-07-07 Thread pgAdmin Trac
#325: Wrong statistics for overloaded functions +--- Reporter: brsa| Owner: dpage Type: bug | Status: new Priority: minor | Milestone: Component: pgadmin | Versio

Re: [pgadmin-hackers] Wrong statistics for overloaded functions

2011-07-07 Thread Erwin Brandstetter
On 07.07.2011 08:52, Guillaume Lelarge wrote: On Wed, 2011-07-06 at 21:22 +0200, Erwin Brandstetter wrote: Aloha! I have been observing irregularities in the function statistics for some time. Now I have investigated and believe to have found the cause. Everything is here, including a proposed